From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A994C5B543 for ; Tue, 10 Jun 2025 14:06:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 895C410E57A; Tue, 10 Jun 2025 14:06:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ErSiYJuH"; dkim-atps=neutral Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id C88B610E57B for ; Tue, 10 Jun 2025 14:06:23 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-45306976410so630715e9.3 for ; Tue, 10 Jun 2025 07:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749564382; x=1750169182; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=c08nNQiRjpMuZiP/f1jVDn68latr5bwhdLQgcHIbV2Q=; b=ErSiYJuHCONjKrrQk2NqgJdTru3VAtozSiUEZd3M1k5e54B6upk8tlnbK2p/Wxwmkc XGDhG78hyEoZOopYBs0HWQ3/hLnwCWuIvUETwu9JevrRPLIIdzmD7XToCiACA3HIh7UG Obpj1M7DIDi9NIJFrtKbLahIVc+p1d8oLANZotHTwhma7u1bPispOtHaBTNLYZ5hedRn QhumD7NsCz88tHCSNiiJiUKAU6XVQAeVX2auA3CNDE4t45OB/Mzqj95zn8jaPiY87+pa t8TGx4/zpNAbpOOku5+ChsaNO2nBKNPFxiOHmJL+UQUAcRwKhQC8DOK9FzenCl/Ud+ir hy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749564382; x=1750169182; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c08nNQiRjpMuZiP/f1jVDn68latr5bwhdLQgcHIbV2Q=; b=fDIVSH50RMocKSOMe7tvxw8+sZO/ZOIgOkH+4N95qT/4083P+tJKznDhpMvaa3Kk3K 4ICqo8h7d1hTQwV4u/uai8794s1+SWnyXMD+I2OvzlXaRTZVIjkglDPHpodaNaiK6/0M +7Wv4bny/nmnwFe+gbuXFmW9+9d+lAxaswKTDWejd0g5ZVuDhqXhW8tX9WWTjgw0ze2s ycqpyfuiECcpxXX55VzD9WjOziuqkaSvkv8UGrMRRcL8KBsF4fRJ9k+37KHpIIq0PXbl nw9iEr87AJr6tOBt9rd/qRrYaBY51DK5wJI2EIp5MSKM8fa7wVST8q1iM+sP9TowX75l 2XHA== X-Forwarded-Encrypted: i=1; AJvYcCWobN/O01DcdDnCcX5uLu92J2GThD9Fl3ZJhpufozHw8dwsh6KUlcRioZnRtV2/tG5s+DZDvAhQJeQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzLZ+RUMhHH4FY962mbhbeW8HKFhsSbbYsJiiHRMbDEqyzqOg3L CX31EfXzg9od2Z2NIkRHRMRlUr4QYMHwr1WpAmCo9okBNCiLMdu18tOnO4pQyCokvbY= X-Gm-Gg: ASbGncuxEVAyO386JbRlsCNisqVt0NciXkVGFGTEAF5twucoqzjBBuGQeEB1BCFo5Mt cWkKRhZCqCOnRWKxeKqNNKpYciBOOwW+7PeTkEpyLnQRoG2mvb36mRxdW/4qfyUTcRZWC5ERZMz 234Cg/kdbfUZqALZixIgNG3+u9vinB44JUkqFEFMYxlmdMcJwZ0842e+Y+LDOz4JFPGrLcQ8lUi TMVMV8drSali/nBJDGZcEpqROoeEXBOkMiaBFvdMpUn1I4gIk3bRTUIBZ+6RxuzdLLTc7lzuNUv onIkkNCxlv3buMEupBaA5PTt0DQ5TeH7fB7uUb5QYAcBniPS33zT/TUq3hVylp29TlaqDB8JSdb DADBcVw== X-Google-Smtp-Source: AGHT+IHDxukPheSrxBOvxKpZYaa8h9T+95Gg5jKYThUcUHQbgCqlc/EbIO/Sp6kjBnRf7HNWZ6eJEQ== X-Received: by 2002:a05:600c:c04b:20b0:441:c5ee:cdb4 with SMTP id 5b1f17b1804b1-452a470122cmr33063215e9.4.1749564381956; Tue, 10 Jun 2025 07:06:21 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244df06sm12734469f8f.69.2025.06.10.07.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 07:06:21 -0700 (PDT) From: Krzysztof Kozlowski Date: Tue, 10 Jun 2025 16:05:44 +0200 Subject: [PATCH v6 06/17] drm/msm/dsi/phy: Toggle back buffer resync after preparing PLL MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250610-b4-sm8750-display-v6-6-ee633e3ddbff@linaro.org> References: <20250610-b4-sm8750-display-v6-0-ee633e3ddbff@linaro.org> In-Reply-To: <20250610-b4-sm8750-display-v6-0-ee633e3ddbff@linaro.org> To: Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Clark Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, Abel Vesa , Srinivas Kandagatla , Rob Clark , Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1275; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=hOZPlM1KyWeQGK+fAet9Nxs5Wt17jNDUM1Ff6e36WS0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoSDvEFaGVfcvc7I+WsKnLa00SN5QPTkSzfiWGJ PahrGboSN2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaEg7xAAKCRDBN2bmhouD 1/FCD/996DPQkeSTgHdKYXZwdFyt3uizbqcoRQhLkEEg860tSjn7Kte3DUkvlR7EWtxQc1vwNij h6zflWghpo2l50dYyFTsw/N7CR6NRHryv3B7+nv+2r33l7WcaoFYkGM4FsAkCJKMPl6bGpRNQvA 9jYFY0BIHeuFg8AXYSEvLhDdZ8R+Zdx37F7ax1PugZeMApDCjDLkq9ba2ok7D7AoApGrHVyuZce kRFTFCEytra1l3KwEc4Mn+XdmielljNWWsKSC6JX9ReyWvrwewEpGU7twwfCxB7LwVqmnbhzP/Y OpmQ2JKetVRFnfrvaNuaTttsyTjub1lLnKUP5t23B8qKg2BrTwdsdVbvD8j6L0ykRwn9BMAaOAu z9dNv2P7/vnLpPNE1JmD8TbtHsmK15kV34zypREhkFVycSF8QAeMOA1Mr2SY5MXginxjTNRkS3H DHBBUWus08o+ao5tXURP0ryJuFyaWOJ+omsvAmjClWK2RIWoZLvhOAoPHumWwrZ7c/FLW3Fm3XN 7CIJpoOxTfq/cRbfsadOyaALh7+jFh5l6qhA5aFXQionaHY2c+4Nxh680d/6/sTx/hEyXCmoXD6 wl5tCEHIljBGjnYYUs2fMNCaFMtpUQeNbctmXaAWguGng2Fehbc2OAm4mwDti2rpffedGvjZJix lW03btC9avV5Gvg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" According to Hardware Programming Guide for DSI PHY, the retime buffer resync should be done after PLL clock users (byte_clk and intf_byte_clk) are enabled. Downstream also does it as part of configuring the PLL. Driver was only turning off the resync FIFO buffer, but never bringing it on again. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- Changes in v6: 1. Fix typo in commit msg Changes in v5: 1. New patch --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c index c19890358b7479c85c793aa7470904127c2d0206..f0ff6c9fbc2e6d28c96c08114c0f417708d70b10 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -467,6 +467,10 @@ static int dsi_pll_7nm_vco_prepare(struct clk_hw *hw) if (pll_7nm->slave) dsi_pll_enable_global_clk(pll_7nm->slave); + writel(0x1, pll_7nm->phy->base + REG_DSI_7nm_PHY_CMN_RBUF_CTRL); + if (pll_7nm->slave) + writel(0x1, pll_7nm->slave->phy->base + REG_DSI_7nm_PHY_CMN_RBUF_CTRL); + error: return rc; } -- 2.45.2