* [PATCH] nouveau/gsp: get zeroed pages for any device allocations we need
@ 2025-06-17 5:09 Dave Airlie
2025-06-17 16:27 ` Danilo Krummrich
0 siblings, 1 reply; 2+ messages in thread
From: Dave Airlie @ 2025-06-17 5:09 UTC (permalink / raw)
To: dri-devel; +Cc: nouveau
From: Dave Airlie <airlied@redhat.com>
This seems to remove some random behaviour around suspend/resume
operations, and ordering of memory allocations.
Cc: stable@vger.kernel.org
Reviewed-by: Ben Skeggs <bskeggs@nvidia.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
index baf42339f93e..4460da3239b5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
@@ -1583,7 +1583,7 @@ nvkm_gsp_sg(struct nvkm_device *device, u64 size, struct sg_table *sgt)
return ret;
for_each_sgtable_sg(sgt, sgl, i) {
- struct page *page = alloc_page(GFP_KERNEL);
+ struct page *page = alloc_page(GFP_KERNEL | __GFP_ZERO);
if (!page) {
nvkm_gsp_sg_free(device, sgt);
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nouveau/gsp: get zeroed pages for any device allocations we need
2025-06-17 5:09 [PATCH] nouveau/gsp: get zeroed pages for any device allocations we need Dave Airlie
@ 2025-06-17 16:27 ` Danilo Krummrich
0 siblings, 0 replies; 2+ messages in thread
From: Danilo Krummrich @ 2025-06-17 16:27 UTC (permalink / raw)
To: Dave Airlie; +Cc: dri-devel, nouveau
On 6/17/25 7:09 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This seems to remove some random behaviour around suspend/resume
> operations, and ordering of memory allocations.
What do you mean with ordering of memory allocations?
>
> Cc: stable@vger.kernel.org
I think we should add:
Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
> Reviewed-by: Ben Skeggs <bskeggs@nvidia.com>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> index baf42339f93e..4460da3239b5 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> @@ -1583,7 +1583,7 @@ nvkm_gsp_sg(struct nvkm_device *device, u64 size, struct sg_table *sgt)
> return ret;
>
> for_each_sgtable_sg(sgt, sgl, i) {
> - struct page *page = alloc_page(GFP_KERNEL);
> + struct page *page = alloc_page(GFP_KERNEL | __GFP_ZERO);
>
> if (!page) {
> nvkm_gsp_sg_free(device, sgt);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 5:09 [PATCH] nouveau/gsp: get zeroed pages for any device allocations we need Dave Airlie
2025-06-17 16:27 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).