dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags
@ 2025-06-18  8:09 Andy Yan
  2025-06-30 15:32 ` neil.armstrong
  2025-06-30 15:41 ` Neil Armstrong
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Yan @ 2025-06-18  8:09 UTC (permalink / raw)
  To: neil.armstrong
  Cc: quic_jesszhan, mripard, simona, tzimmermann, dri-devel,
	linux-kernel, Andy Yan

From: Andy Yan <andy.yan@rock-chips.com>

Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC
flags. Those are used by various bridges(e.g. dw-mipi-dsi) in the
pipeline to correctly configure its sync signals polarity.

Tested on rk3568/rk3576/rk3588 EVB.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 drivers/gpu/drm/panel/panel-raydium-rm67200.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67200.c b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
index add6099ae8a64..92c3e20b903f0 100644
--- a/drivers/gpu/drm/panel/panel-raydium-rm67200.c
+++ b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
@@ -478,6 +478,7 @@ static const struct raydium_rm67200_panel_info w552793baa_info = {
 		.vtotal = 1952,
 		.width_mm = 68, /* 68.04mm */
 		.height_mm = 121, /* 120.96mm */
+		.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
 		.type = DRM_MODE_TYPE_DRIVER,
 	},
 	.regulators = w552793baa_regulators,
-- 
2.43.0

base-commit: e1070ed6f01f471547b67ee23b0cb8febaaccaca
branch: rk356x_rk3588_rk3576_dsi


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags
  2025-06-18  8:09 [PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags Andy Yan
@ 2025-06-30 15:32 ` neil.armstrong
  2025-06-30 15:41 ` Neil Armstrong
  1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2025-06-30 15:32 UTC (permalink / raw)
  To: Andy Yan
  Cc: quic_jesszhan, mripard, simona, tzimmermann, dri-devel,
	linux-kernel, Andy Yan

On 18/06/2025 10:09, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC
> flags. Those are used by various bridges(e.g. dw-mipi-dsi) in the
> pipeline to correctly configure its sync signals polarity.
> 
> Tested on rk3568/rk3576/rk3588 EVB.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> 
>   drivers/gpu/drm/panel/panel-raydium-rm67200.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67200.c b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
> index add6099ae8a64..92c3e20b903f0 100644
> --- a/drivers/gpu/drm/panel/panel-raydium-rm67200.c
> +++ b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
> @@ -478,6 +478,7 @@ static const struct raydium_rm67200_panel_info w552793baa_info = {
>   		.vtotal = 1952,
>   		.width_mm = 68, /* 68.04mm */
>   		.height_mm = 121, /* 120.96mm */
> +		.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
>   		.type = DRM_MODE_TYPE_DRIVER,
>   	},
>   	.regulators = w552793baa_regulators,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags
  2025-06-18  8:09 [PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags Andy Yan
  2025-06-30 15:32 ` neil.armstrong
@ 2025-06-30 15:41 ` Neil Armstrong
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-06-30 15:41 UTC (permalink / raw)
  To: Andy Yan
  Cc: quic_jesszhan, mripard, simona, tzimmermann, dri-devel,
	linux-kernel, Andy Yan

Hi,

On Wed, 18 Jun 2025 16:09:55 +0800, Andy Yan wrote:
> Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC
> flags. Those are used by various bridges(e.g. dw-mipi-dsi) in the
> pipeline to correctly configure its sync signals polarity.
> 
> Tested on rk3568/rk3576/rk3588 EVB.
> 
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/panel: raydium-rm67200: Add missing drm_display_mode flags
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/4dfed55bfb4b500bbc45867c1b83789cc4dbd106

-- 
Neil


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-30 15:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-18  8:09 [PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags Andy Yan
2025-06-30 15:32 ` neil.armstrong
2025-06-30 15:41 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).