From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D77ECC7115A for ; Wed, 18 Jun 2025 09:40:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5628A10E7B8; Wed, 18 Jun 2025 09:40:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Zdo3izJJ"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6260610E1C3 for ; Wed, 18 Jun 2025 09:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750239636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rDJSn7lZBwyjuX5zqRMyk4Cm9Q70Xmc4Tn4BSpOgdus=; b=Zdo3izJJAgjoNlJa27pO4ux4OtxWxsfbVUXnJxFZfnmyzB+LmAsfRePbW9r70eq4cJGMhQ r0MzgVIUTIGpWOOgowCz0/0w7Z7wdO1iepgROztLuWbju6dBNBrNvCMqRYWyN1/Trm3Lvb s3IPsOcCidgLxLOEBoQUyitTQebDyzE= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-gSykbj8SNcWm4dq_Rfpqag-1; Wed, 18 Jun 2025 05:40:32 -0400 X-MC-Unique: gSykbj8SNcWm4dq_Rfpqag-1 X-Mimecast-MFC-AGG-ID: gSykbj8SNcWm4dq_Rfpqag_1750239630 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1DE3B195608B; Wed, 18 Jun 2025 09:40:29 +0000 (UTC) Received: from hydra.redhat.com (unknown [10.45.225.137]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EACF419560A3; Wed, 18 Jun 2025 09:40:22 +0000 (UTC) From: Jocelyn Falempe To: Maarten Lankhorst , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , David Airlie , Simona Vetter , Christian Koenig , Huang Rui , Matthew Auld , Matthew Brost , Maxime Ripard , Thomas Zimmermann , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jocelyn Falempe Subject: [PATCH v10 00/10] drm/i915: Add drm_panic support Date: Wed, 18 Jun 2025 11:31:18 +0200 Message-ID: <20250618094011.238154-1-jfalempe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This adds drm_panic support for i915 and xe driver. I've tested it on the 4 intel laptops I have at my disposal. * Haswell with 128MB of eDRAM. * Comet Lake i7-10850H * Raptor Lake i7-1370P (with DPT, and Y-tiling). * Lunar Lake Ultra 5 228V (with DPT, and 4-tiling, and using the Xe driver. I tested panic in both fbdev console and gnome desktop. I think it won't work yet on discrete GPU, but that can be added later. Best regards, v2: * Add the proper abstractions to build also for Xe. * Fix dim checkpatch issues. v3: * Add support for Y-tiled framebuffer when DPT is enabled. v4: * Add support for Xe driver, which shares most of the code. * Add support for 4-tiled framebuffer found in newest GPU. v5: * Rebase on top of git@gitlab.freedesktop.org:drm/i915/kernel.git drm-intel-next * Use struct intel_display instead of drm_i915_private. * Use iosys_map for intel_bo_panic_map(). v6: * Rebase on top of git@gitlab.freedesktop.org:drm/i915/kernel.git drm-intel-next * Use struct intel_display instead of drm_i915_private for intel_atomic_plane.c v7: * Fix mismatch {} in intel_panic_flush() (Jani Nikula) * Return int for i915_gem_object_panic_map() (Ville Syrjälä) * Reword commit message about alignment/size when disabling tiling (Ville Syrjälä) v8: * Use kmap_try_from_panic() instead of vmap, to access the framebuffer. * Add ttm_bo_kmap_try_from_panic() for the xe driver, that uses ttm. * Replace intel_bo_panic_map() with a setup() and finish() function, to allow mapping only one page of teh framebuffer at a time. * Configure psr to send the full framebuffer update. v9: * Fix comment in ttm_bo_kmap_try_from_panic(), this can *only* be called from the panic handler (Christian König) * Fix missing kfree() for i915_panic_pages in i915_gem_object_panic_finish() Also change i915_panic_pages allocation to kmalloc, as kvmalloc is not safe to call from the panic handler. * Fix dim checkpatch warnings. v10: * Add a private field to struct drm_scanout_buffer * Replace static variables with new fields in struct intel_framebuffer (Maarten Lankhorst) * Add error handling if i915_gem_object_panic_pages() returns NULL * Declare struct drm_scanout_buffer instead of including in intel_bo.h Jocelyn Falempe (10): drm/panic: Add a private field to struct drm_scanout_buffer drm/i915/fbdev: Add intel_fbdev_get_map() drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes drm/i915/display: Add a disable_tiling() for skl planes drm/ttm: Add ttm_bo_kmap_try_from_panic() drm/i915: Add intel_bo_panic_setup and intel_bo_panic_finish drm/i915/display: Add drm_panic support drm/i915/display: Add drm_panic support for Y-tiling with DPT drm/i915/display: Add drm_panic support for 4-tiling with DPT drm/i915/psr: Add intel_psr2_panic_force_full_update drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++ .../gpu/drm/i915/display/intel_atomic_plane.c | 170 +++++++++++++++++- drivers/gpu/drm/i915/display/intel_bo.c | 12 ++ drivers/gpu/drm/i915/display/intel_bo.h | 4 + .../drm/i915/display/intel_display_types.h | 11 ++ drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 + drivers/gpu/drm/i915/display/intel_fb_pin.h | 2 + drivers/gpu/drm/i915/display/intel_fbdev.c | 5 + drivers/gpu/drm/i915/display/intel_fbdev.h | 6 +- drivers/gpu/drm/i915/display/intel_psr.c | 20 +++ drivers/gpu/drm/i915/display/intel_psr.h | 2 + .../drm/i915/display/skl_universal_plane.c | 27 +++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 5 + drivers/gpu/drm/i915/gem/i915_gem_pages.c | 112 ++++++++++++ drivers/gpu/drm/i915/i915_vma.h | 5 + drivers/gpu/drm/ttm/ttm_bo_util.c | 27 +++ drivers/gpu/drm/xe/display/intel_bo.c | 61 +++++++ drivers/gpu/drm/xe/display/xe_fb_pin.c | 5 + include/drm/drm_panic.h | 6 + include/drm/ttm/ttm_bo.h | 1 + 20 files changed, 507 insertions(+), 2 deletions(-) base-commit: b2f7e30d2e4a34fcee8111d713bef4f29dc23c77 -- 2.49.0