From: Janne Grunau <j@jannau.net>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: lee@kernel.org, danielt@kernel.org, jingoohan1@gmail.com,
neil.armstrong@linaro.org, jessica.zhang@oss.qualcomm.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch, fnkl.kernel@gmail.com,
hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
sven@kernel.org, alyssa@rosenzweig.io, neal@gompa.dev,
deller@gmx.de, support.opensource@diasemi.com,
duje.mihanovic@skole.hr, dri-devel@lists.freedesktop.org,
asahi@lists.linux.dev, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 04/12] drm/panel: panel-summit: Include <linux/of.h>
Date: Wed, 18 Jun 2025 17:19:06 +0200 [thread overview]
Message-ID: <20250618151906.GA103923@robin.jannau.net> (raw)
In-Reply-To: <20250618122436.379013-5-tzimmermann@suse.de>
On Wed, Jun 18, 2025 at 02:16:36PM +0200, Thomas Zimmermann wrote:
> Include <linux/of.h> to declare device_property_read_u32() and
> struct of_device_id. Avoids dependency on backlight header to include
> it.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/panel/panel-summit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-summit.c b/drivers/gpu/drm/panel/panel-summit.c
> index 4854437e2899..02aa1ec287d6 100644
> --- a/drivers/gpu/drm/panel/panel-summit.c
> +++ b/drivers/gpu/drm/panel/panel-summit.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
>
> #include <linux/backlight.h>
> +#include <linux/of.h>
> #include <drm/drm_device.h>
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_mode.h>
Reviewed-by: Janne Grunau <j@jannau.net>
next prev parent reply other threads:[~2025-06-18 15:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 12:16 [PATCH 00/12] backlight: Do not include <linux/fb.h> in header file Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 01/12] platform/x86: dell-uart-backlight: Use blacklight power constant Thomas Zimmermann
2025-06-18 13:01 ` Hans de Goede
2025-06-24 11:36 ` Ilpo Järvinen
2025-06-18 12:16 ` [PATCH 02/12] drm/panel: panel-samsung-s6e63m0: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 03/12] drm/panel: panel-samsung-s6e88a0-ams427ap24: " Thomas Zimmermann
2025-06-18 13:42 ` neil.armstrong
2025-06-18 12:16 ` [PATCH 04/12] drm/panel: panel-summit: " Thomas Zimmermann
2025-06-18 15:19 ` Janne Grunau [this message]
2025-06-18 12:16 ` [PATCH 05/12] fbcon: Add necessary include statements and forward declarations Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 06/12] backlight: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 07/12] backlight: apple_dwi_bl: Include <linux/mod_devicetable.h> Thomas Zimmermann
2025-06-18 15:08 ` Nick Chan
2025-06-18 12:16 ` [PATCH 08/12] backlight: as3711_bl: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 09/12] backlight: da9052_bl: Include <linux/mod_devicetable.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 10/12] backlight: ktd2801: " Thomas Zimmermann
2025-06-18 15:04 ` Nick Chan
2025-06-24 16:41 ` Duje Mihanović
2025-06-18 12:16 ` [PATCH 11/12] backlight: led_bl: Include <linux/of.h> Thomas Zimmermann
2025-06-18 12:16 ` [PATCH 12/12] backlight: Do not include <linux/fb.h> in header file Thomas Zimmermann
2025-06-19 5:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618151906.GA103923@robin.jannau.net \
--to=j@jannau.net \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=duje.mihanovic@skole.hr \
--cc=fnkl.kernel@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=support.opensource@diasemi.com \
--cc=sven@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).