From: Jocelyn Falempe <jfalempe@redhat.com>
To: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Christian Koenig" <christian.koenig@amd.com>,
"Huang Rui" <ray.huang@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Jocelyn Falempe <jfalempe@redhat.com>
Subject: [PATCH v11 00/11] drm/i915: Add drm_panic support
Date: Tue, 24 Jun 2025 11:01:09 +0200 [thread overview]
Message-ID: <20250624091501.257661-1-jfalempe@redhat.com> (raw)
This adds drm_panic support for i915 and xe driver.
I've tested it on the 4 intel laptops I have at my disposal.
* Haswell with 128MB of eDRAM.
* Comet Lake i7-10850H
* Raptor Lake i7-1370P (with DPT, and Y-tiling).
* Lunar Lake Ultra 5 228V (with DPT, and 4-tiling, and using the Xe driver.
I tested panic in both fbdev console and gnome desktop.
I think it won't work yet on discrete GPU, but that can be added later.
Best regards,
v2:
* Add the proper abstractions to build also for Xe.
* Fix dim checkpatch issues.
v3:
* Add support for Y-tiled framebuffer when DPT is enabled.
v4:
* Add support for Xe driver, which shares most of the code.
* Add support for 4-tiled framebuffer found in newest GPU.
v5:
* Rebase on top of git@gitlab.freedesktop.org:drm/i915/kernel.git drm-intel-next
* Use struct intel_display instead of drm_i915_private.
* Use iosys_map for intel_bo_panic_map().
v6:
* Rebase on top of git@gitlab.freedesktop.org:drm/i915/kernel.git drm-intel-next
* Use struct intel_display instead of drm_i915_private for intel_atomic_plane.c
v7:
* Fix mismatch {} in intel_panic_flush() (Jani Nikula)
* Return int for i915_gem_object_panic_map() (Ville Syrjälä)
* Reword commit message about alignment/size when disabling tiling (Ville Syrjälä)
v8:
* Use kmap_try_from_panic() instead of vmap, to access the framebuffer.
* Add ttm_bo_kmap_try_from_panic() for the xe driver, that uses ttm.
* Replace intel_bo_panic_map() with a setup() and finish() function,
to allow mapping only one page of teh framebuffer at a time.
* Configure psr to send the full framebuffer update.
v9:
* Fix comment in ttm_bo_kmap_try_from_panic(), this can *only* be called
from the panic handler (Christian König)
* Fix missing kfree() for i915_panic_pages in i915_gem_object_panic_finish()
Also change i915_panic_pages allocation to kmalloc, as kvmalloc is not
safe to call from the panic handler.
* Fix dim checkpatch warnings.
v10:
* Add a private field to struct drm_scanout_buffer
* Replace static variables with new fields in struct intel_framebuffer
(Maarten Lankhorst)
* Add error handling if i915_gem_object_panic_pages() returns NULL
* Declare struct drm_scanout_buffer instead of including <drm/drm_panic.h>
in intel_bo.h
v11:
* Encapsulate the struct intel_framebuffer into a xe_framebuffer or
i915_framebuffer, to make it easier to add a struct xe_res_cursor
to support discrete GPU later.
Jocelyn Falempe (11):
drm/panic: Add a private field to struct drm_scanout_buffer
drm/i915/fbdev: Add intel_fbdev_get_map()
drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes
drm/i915/display: Add a disable_tiling() for skl planes
drm/ttm: Add ttm_bo_kmap_try_from_panic()
drm/i915: Add intel_bo_alloc_framebuffer()
drm/i915: Add intel_bo_panic_setup() and intel_bo_panic_finish()
drm/i915/display: Add drm_panic support
drm/i915/display: Add drm_panic support for Y-tiling with DPT
drm/i915/display: Add drm_panic support for 4-tiling with DPT
drm/i915/psr: Add intel_psr2_panic_force_full_update
drivers/gpu/drm/i915/display/i9xx_plane.c | 26 ++-
drivers/gpu/drm/i915/display/intel_bo.c | 17 ++
drivers/gpu/drm/i915/display/intel_bo.h | 5 +
.../drm/i915/display/intel_display_types.h | 4 +
drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 +
drivers/gpu/drm/i915/display/intel_fb_pin.h | 2 +
drivers/gpu/drm/i915/display/intel_fbdev.c | 5 +
drivers/gpu/drm/i915/display/intel_fbdev.h | 6 +-
drivers/gpu/drm/i915/display/intel_plane.c | 170 +++++++++++++++++-
drivers/gpu/drm/i915/display/intel_psr.c | 20 +++
drivers/gpu/drm/i915/display/intel_psr.h | 2 +
.../drm/i915/display/skl_universal_plane.c | 29 ++-
drivers/gpu/drm/i915/gem/i915_gem_object.h | 6 +
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 142 +++++++++++++++
drivers/gpu/drm/i915/i915_vma.h | 5 +
drivers/gpu/drm/ttm/ttm_bo_util.c | 27 +++
drivers/gpu/drm/xe/display/intel_bo.c | 91 ++++++++++
drivers/gpu/drm/xe/display/xe_fb_pin.c | 5 +
include/drm/drm_panic.h | 6 +
include/drm/ttm/ttm_bo.h | 1 +
21 files changed, 571 insertions(+), 5 deletions(-)
base-commit: 266907bb491f2bdd731139792b5a5056b6d0a482
--
2.49.0
next reply other threads:[~2025-06-24 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 9:01 Jocelyn Falempe [this message]
2025-06-24 9:01 ` [PATCH v11 01/11] drm/panic: Add a private field to struct drm_scanout_buffer Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 02/11] drm/i915/fbdev: Add intel_fbdev_get_map() Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 03/11] drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 04/11] drm/i915/display: Add a disable_tiling() for skl planes Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 05/11] drm/ttm: Add ttm_bo_kmap_try_from_panic() Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 06/11] drm/i915: Add intel_bo_alloc_framebuffer() Jocelyn Falempe
2025-09-02 14:59 ` Jani Nikula
2025-06-24 9:01 ` [PATCH v11 07/11] drm/i915: Add intel_bo_panic_setup() and intel_bo_panic_finish() Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 08/11] drm/i915/display: Add drm_panic support Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 09/11] drm/i915/display: Add drm_panic support for Y-tiling with DPT Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 10/11] drm/i915/display: Add drm_panic support for 4-tiling " Jocelyn Falempe
2025-06-24 9:01 ` [PATCH v11 11/11] drm/i915/psr: Add intel_psr2_panic_force_full_update Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624091501.257661-1-jfalempe@redhat.com \
--to=jfalempe@redhat.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=ray.huang@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).