dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: David Airlie <airlied@linux.ie>
Cc: Hans de Goede <hansg@kernel.org>, Lukas Wunner <lukas@wunner.de>,
	Andi Kleen <ak@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 2/3] agp/amd64: Change agp_try_unsupported default to 0
Date: Mon,  7 Jul 2025 19:37:09 +0200	[thread overview]
Message-ID: <20250707173710.313701-3-hansg@kernel.org> (raw)
In-Reply-To: <20250707173710.313701-1-hansg@kernel.org>

AMD64 boards with AGP support are so old that the agp_amd64_pci_table
should be complete and there is no need to probe unlisted PCI devices
by default.

This also brings the driver inline with the global agp=try_unsupported
(agp_try_unsupported_boot) parameter which also default to 0 and brings
things inline with the Kconfig which says that agp_try_unsupported=1
should be passed to try unsupported bridges.

Suggested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Hans de Goede <hansg@kernel.org>
---
 drivers/char/agp/amd64-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index 2505df1f4e69..f883c06b538a 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -34,7 +34,7 @@
 #define ULI_X86_64_ENU_SCR_REG		0x54
 
 static struct resource *aperture_resource;
-static bool __initdata agp_try_unsupported = 1;
+static bool agp_try_unsupported __initdata;
 static int agp_bridges_found;
 
 static void amd64_tlbflush(struct agp_memory *temp)
-- 
2.49.0


  parent reply	other threads:[~2025-07-07 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 17:37 [PATCH 0/3] agp/amd64: Remove support for probing unlisted PCI devices Hans de Goede
2025-07-07 17:37 ` [PATCH 1/3] agp/amd64: Check AGP Capability before binding to unsupported devices Hans de Goede
2025-07-07 17:37 ` Hans de Goede [this message]
2025-07-07 17:37 ` [PATCH 3/3] agp/amd64: Remove support for probing unlisted PCI devices Hans de Goede
2025-07-07 18:00   ` Lukas Wunner
2025-07-07 18:12 ` [PATCH 0/3] " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707173710.313701-3-hansg@kernel.org \
    --to=hansg@kernel.org \
    --cc=airlied@linux.ie \
    --cc=ak@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).