From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0089EC87FCB for ; Wed, 30 Jul 2025 13:21:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6360D10E69C; Wed, 30 Jul 2025 13:21:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="CBtfodzL"; dkim-atps=neutral X-Greylist: delayed 472 seconds by postgrey-1.36 at gabe; Wed, 30 Jul 2025 13:21:18 UTC Received: from forward501a.mail.yandex.net (forward501a.mail.yandex.net [178.154.239.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 676AA10E695 for ; Wed, 30 Jul 2025 13:21:18 +0000 (UTC) Received: from mail-nwsmtp-smtp-production-main-74.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-74.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:515:0:640:ed11:0]) by forward501a.mail.yandex.net (Yandex) with ESMTPS id BAA55890DB; Wed, 30 Jul 2025 16:13:23 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-74.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id HDa5Jx4MmuQ0-xh2DFQNF; Wed, 30 Jul 2025 16:13:22 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1753881202; bh=8z4SLApFyWRAw7OvW1QUAJYsAMQ8uODmFgZDAW4+n+8=; h=Cc:Message-ID:Subject:Date:References:To:From:In-Reply-To; b=CBtfodzLXuMQ1iE/wsmVgHKHCGhM5lKI7kTA0WejqL/SdLSQbiZUs1wHZUwqpdFRj AII25WPIzloHL+fN+fo/buDX8g6W85n66v90wd7K3cvK/yId+vscFchrBiZeTtdymC KLSd7b8ZYUPbjDqpZx+7ZZB8UfVEOqg0SKQvuAAQ= Authentication-Results: mail-nwsmtp-smtp-production-main-74.iva.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev Date: Wed, 30 Jul 2025 16:13:16 +0300 From: Onur =?UTF-8?B?w5Z6a2Fu?= To: Miguel Ojeda Cc: Alex Gaynor , Andreas Hindborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Boqun Feng , Gary Guo , =?UTF-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: Re: [PATCH 3/3] rust: warn if `srctree/` links do not exist Message-ID: <20250730161316.57bd7745@nimda.home> In-Reply-To: <20250730130716.3278285-4-ojeda@kernel.org> References: <20250730130716.3278285-1-ojeda@kernel.org> <20250730130716.3278285-4-ojeda@kernel.org> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 30 Jul 2025 15:07:16 +0200 Miguel Ojeda wrote: > `srctree/` links may point to nonexistent files, e.g. due to renames > that missed to update the files or simply because of typos. >=20 > Since they can be easily checked for validity, do so and print a > warning in the file does not exist. >=20 > This found the following cases already in-tree: >=20 > warning: srctree/ link to include/linux/blk_mq.h does not exist > warning: srctree/ link to include/linux/drm/drm_gem.h does not > exist warning: srctree/ link to include/linux/drm/drm_drv.h does not > exist warning: srctree/ link to include/linux/drm/drm_ioctl.h does > not exist warning: srctree/ link to include/linux/drm/drm_file.h does > not exist warning: srctree/ link to include/linux/drm/drm_device.h > does not exist >=20 > Inspired-by: "Onur =C3=96zkan" > Link: > https://lore.kernel.org/rust-for-linux/CANiq72=3DxCYA7z7_rxpzzKkkhJs6m7L_= xEaLMuArVn3ZAcyeHdA@mail.gmail.com/ > Signed-off-by: Miguel Ojeda --- > rust/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/rust/Makefile b/rust/Makefile > index 4e675d210dd8..a27503028216 100644 > --- a/rust/Makefile > +++ b/rust/Makefile > @@ -93,6 +93,12 @@ quiet_cmd_rustdoc =3D RUSTDOC $(if > $(rustdoc_host),H, ) $< # and then retouch the generated files. > rustdoc: rustdoc-core rustdoc-macros rustdoc-compiler_builtins \ > rustdoc-kernel rustdoc-pin_init > + $(Q)grep -Ehro ' | \ > + cut -d'"' -f2 | cut -d/ -f2- | while read f; do \ > + if [ ! -e "$(srctree)/$$f" ]; then \ > + echo "warning: srctree/ link to $$f > does not exist"; \ > + fi \ > + done > $(Q)cp $(srctree)/Documentation/images/logo.svg > $(rustdoc_output)/static.files/ $(Q)cp > $(srctree)/Documentation/images/COPYING-logo > $(rustdoc_output)/static.files/ $(Q)find $(rustdoc_output) -name > '*.html' -type f -print0 | xargs -0 sed -Ei \ That's awesome! This would help a lot. :) Reviewed-by: Onur =C3=96zkan -- Regards, Onur