From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Damon Ding <damon.ding@rock-chips.com>,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com,
heiko@sntech.de, andy.yan@rock-chips.com,
dmitry.baryshkov@oss.qualcomm.com, l.stach@pengutronix.de,
dianders@chromium.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: Re: [PATCH v4 13/13] drm/bridge: analogix_dp: Apply panel_bridge helper
Date: Sat, 16 Aug 2025 13:31:36 +0300 [thread overview]
Message-ID: <202508161345.sfsLHzY7-lkp@intel.com> (raw)
In-Reply-To: <20250814104753.195255-14-damon.ding@rock-chips.com>
Hi Damon,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Damon-Ding/drm-bridge-analogix_dp-Formalize-the-struct-analogix_dp_device/20250814-185009
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link: https://lore.kernel.org/r/20250814104753.195255-14-damon.ding%40rock-chips.com
patch subject: [PATCH v4 13/13] drm/bridge: analogix_dp: Apply panel_bridge helper
config: hexagon-randconfig-r072-20250815 (https://download.01.org/0day-ci/archive/20250816/202508161345.sfsLHzY7-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 93d24b6b7b148c47a2fa228a4ef31524fa1d9f3f)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202508161345.sfsLHzY7-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1595 analogix_dp_bind() warn: passing a valid pointer to 'PTR_ERR'
vim +/PTR_ERR +1595 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
152cce0006abf7e Marek Szyprowski 2020-03-10 1560 int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
152cce0006abf7e Marek Szyprowski 2020-03-10 1561 {
41dc71b87962d41 Damon Ding 2025-08-14 1562 struct drm_bridge *bridge = &dp->bridge;
152cce0006abf7e Marek Szyprowski 2020-03-10 1563 int ret;
152cce0006abf7e Marek Szyprowski 2020-03-10 1564
3424e3a4f844c0a Yakir Yang 2016-03-29 1565 dp->drm_dev = drm_dev;
3424e3a4f844c0a Yakir Yang 2016-03-29 1566 dp->encoder = dp->plat_data->encoder;
3424e3a4f844c0a Yakir Yang 2016-03-29 1567
6cba3fe433415b2 Lyude Paul 2021-04-23 1568 dp->aux.drm_dev = drm_dev;
0d97ad03f4220ca Tomeu Vizoso 2016-08-24 1569
0d97ad03f4220ca Tomeu Vizoso 2016-08-24 1570 ret = drm_dp_aux_register(&dp->aux);
2d192f4a3acc1c6 Lucas Stach 2024-06-19 1571 if (ret) {
2d192f4a3acc1c6 Lucas Stach 2024-06-19 1572 DRM_ERROR("failed to register AUX (%d)\n", ret);
c71db051142a74b Damon Ding 2025-03-10 1573 return ret;
2d192f4a3acc1c6 Lucas Stach 2024-06-19 1574 }
0d97ad03f4220ca Tomeu Vizoso 2016-08-24 1575
41dc71b87962d41 Damon Ding 2025-08-14 1576 bridge->ops = DRM_BRIDGE_OP_DETECT |
41dc71b87962d41 Damon Ding 2025-08-14 1577 DRM_BRIDGE_OP_EDID |
41dc71b87962d41 Damon Ding 2025-08-14 1578 DRM_BRIDGE_OP_MODES;
41dc71b87962d41 Damon Ding 2025-08-14 1579 bridge->of_node = dp->dev->of_node;
41dc71b87962d41 Damon Ding 2025-08-14 1580 bridge->type = DRM_MODE_CONNECTOR_eDP;
41dc71b87962d41 Damon Ding 2025-08-14 1581 ret = devm_drm_bridge_add(dp->dev, &dp->bridge);
41dc71b87962d41 Damon Ding 2025-08-14 1582 if (ret)
41dc71b87962d41 Damon Ding 2025-08-14 1583 goto err_unregister_aux;
41dc71b87962d41 Damon Ding 2025-08-14 1584
41dc71b87962d41 Damon Ding 2025-08-14 1585 ret = drm_bridge_attach(dp->encoder, bridge, NULL, 0);
3424e3a4f844c0a Yakir Yang 2016-03-29 1586 if (ret) {
3424e3a4f844c0a Yakir Yang 2016-03-29 1587 DRM_ERROR("failed to create bridge (%d)\n", ret);
2d192f4a3acc1c6 Lucas Stach 2024-06-19 1588 goto err_unregister_aux;
3424e3a4f844c0a Yakir Yang 2016-03-29 1589 }
3424e3a4f844c0a Yakir Yang 2016-03-29 1590
dbd8040a6d0dedc Damon Ding 2025-08-14 1591 if (dp->plat_data->panel) {
dbd8040a6d0dedc Damon Ding 2025-08-14 1592 dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
dbd8040a6d0dedc Damon Ding 2025-08-14 1593 dp->plat_data->panel);
dbd8040a6d0dedc Damon Ding 2025-08-14 1594 if (IS_ERR(dp->plat_data->next_bridge)) {
dbd8040a6d0dedc Damon Ding 2025-08-14 @1595 ret = PTR_ERR(bridge);
Wrong variable. s/bridge/dp->plat_data->next_bridge/.
dbd8040a6d0dedc Damon Ding 2025-08-14 1596 goto err_unregister_aux;
dbd8040a6d0dedc Damon Ding 2025-08-14 1597 }
dbd8040a6d0dedc Damon Ding 2025-08-14 1598 }
dbd8040a6d0dedc Damon Ding 2025-08-14 1599
dbd8040a6d0dedc Damon Ding 2025-08-14 1600 ret = drm_bridge_attach(dp->encoder, dp->plat_data->next_bridge, bridge,
dbd8040a6d0dedc Damon Ding 2025-08-14 1601 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
dbd8040a6d0dedc Damon Ding 2025-08-14 1602 if (ret) {
dbd8040a6d0dedc Damon Ding 2025-08-14 1603 dev_err(dp->dev, "failed to attach following panel or bridge (%d)\n", ret);
dbd8040a6d0dedc Damon Ding 2025-08-14 1604 goto err_unregister_aux;
dbd8040a6d0dedc Damon Ding 2025-08-14 1605 }
dbd8040a6d0dedc Damon Ding 2025-08-14 1606
152cce0006abf7e Marek Szyprowski 2020-03-10 1607 return 0;
3424e3a4f844c0a Yakir Yang 2016-03-29 1608
2d192f4a3acc1c6 Lucas Stach 2024-06-19 1609 err_unregister_aux:
2d192f4a3acc1c6 Lucas Stach 2024-06-19 1610 drm_dp_aux_unregister(&dp->aux);
f0a8b49c03d22a5 Marek Szyprowski 2016-12-30 1611
152cce0006abf7e Marek Szyprowski 2020-03-10 1612 return ret;
3424e3a4f844c0a Yakir Yang 2016-03-29 1613 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-08-16 10:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250814104818eucas1p2c5029f6d5997f4fafd6370f9e7fb2264@eucas1p2.samsung.com>
2025-08-14 10:47 ` [PATCH v4 00/13] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2025-08-14 10:47 ` [PATCH v4 01/13] drm/bridge: analogix_dp: Formalize the struct analogix_dp_device Damon Ding
2025-08-14 10:47 ` [PATCH v4 02/13] drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to &drm_bridge_funcs.atomic_enable Damon Ding
2025-08-14 10:47 ` [PATCH v4 03/13] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2025-08-14 10:47 ` [PATCH v4 04/13] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2025-08-14 10:47 ` [PATCH v4 05/13] drm/bridge: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2025-08-14 10:47 ` [PATCH v4 06/13] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2025-08-14 10:47 ` [PATCH v4 07/13] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2025-08-16 16:43 ` Dmitry Baryshkov
2025-08-20 9:18 ` Damon Ding
2025-08-29 8:48 ` Dmitry Baryshkov
2025-08-14 10:47 ` [PATCH v4 08/13] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2025-08-16 0:35 ` kernel test robot
2025-08-14 10:47 ` [PATCH v4 09/13] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2025-08-14 10:47 ` [PATCH v4 10/13] drm/exynos: exynos_dp: " Damon Ding
2025-08-14 10:47 ` [PATCH v4 11/13] drm/bridge: analogix_dp: Remove panel disabling and enabling in analogix_dp_set_bridge() Damon Ding
2025-08-14 10:47 ` [PATCH v4 12/13] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2025-08-14 10:47 ` [PATCH v4 13/13] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2025-08-16 10:31 ` Dan Carpenter [this message]
2025-08-14 14:33 ` [PATCH v4 00/13] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Marek Szyprowski
2025-08-14 21:16 ` Marek Szyprowski
2025-08-15 2:59 ` Damon Ding
2025-08-19 21:20 ` Marek Szyprowski
2025-08-29 8:08 ` Damon Ding
2025-08-29 8:23 ` Marek Szyprowski
2025-09-01 3:41 ` Damon Ding
2025-09-01 10:25 ` Marek Szyprowski
2025-09-04 3:19 ` Damon Ding
2025-08-15 2:04 ` Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508161345.sfsLHzY7-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=damon.ding@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=sw0312.kim@samsung.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).