From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A5DCCA0FE7 for ; Thu, 21 Aug 2025 20:08:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84F2510E3B3; Thu, 21 Aug 2025 20:08:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Ad2SbL3V"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E535110EA17 for ; Thu, 21 Aug 2025 20:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uIthYg0x+2djveHghlw2Jb9wmVGYKVQz7R4ULrPQfiU=; b=Ad2SbL3VzCw5l98GDkSDmQDvI8gCSlUffGOOOsaIvG6VzQnMrer7ytK9zzP15Iw+f94ACr abBGg3HqdZPydGLS68ofELxFnY/kxgXolQw37tlZkumUsyXineFJc/kL32kImLYk9nI2X2 KksZz6+4lVY6R0EjHm/kYQ8V7yOyifg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-edOznn0VP5mu7YHPWOOsmg-1; Thu, 21 Aug 2025 16:08:33 -0400 X-MC-Unique: edOznn0VP5mu7YHPWOOsmg-1 X-Mimecast-MFC-AGG-ID: edOznn0VP5mu7YHPWOOsmg_1755806912 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45a1b0045a0so8439675e9.0 for ; Thu, 21 Aug 2025 13:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806912; x=1756411712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIthYg0x+2djveHghlw2Jb9wmVGYKVQz7R4ULrPQfiU=; b=NnJMtafQyiD0QtqralXADjLgEWSTlK9wknH67CpVqdVKIDDEGbMFx7wIAXfUVGEe5g QDeYLnWiIAVPsVaZJjr5p6xODiXuD6U3h+k1f7XnIf/MHLHQyPfAqFnxwC3HCrerrlnV MIAs+HjpYNwmIuDVNx3GXihiwMj8PppEIna+XFp49SSL2xEDNhwONgCcnyMsBlpQHNTm Xm1XBY1l6ju9ukwJUeQ2XK3Dut8QutyknzxfRaMJWyFgPHfnLXTUf1Uo5P48idAi3Var lik0O3+8vVfNB+jAKBCYbuvpwUkCYkfaC0p65Af8Xx9LE32SRUqoervqTytpykb+8iG6 dF+A== X-Forwarded-Encrypted: i=1; AJvYcCVLXiDMx8EDYHXVPDKVCCemqve/rwXoTWZjykW8Sru02aXRBmqZOjAH3ZJ3dcC9Aw8m3en+PPkW3hQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw9e2ygT69VeDRgyEa5Maqbllc+g2nAdpPuPQfXlJP1ZuWsIhxL IfVhGr6T03YCRIRZ6L7qEdp3XNZzUDO3Ohj5JFZ+C9YjFcOnF+GYtvOHNcYYFayG5Hrx2aAJwTj L0yDjal2y+2Y6zLKjAIADVaJyiwoh7Q75oNA3o7zuc1TMuKOLdChUOuu6e4uXvTPPjhodVg== X-Gm-Gg: ASbGnctwBfGz0Y0UKzaitNZniQMF/LxdCQIQWfSlOeEbaji6AxpqoCHbzpvdY05TC63 msv+6rGk1L0/yghMHUdicgei3P/lnGWNESWfxdjFWpf+Wpkd2sVs5BrUtwSxShFbBDg5tipQbu3 PqnU0kQ6ohv7Q43/AMrZSVKyAJ9/KLpr0JPuPCvo5S/lCD/UjuRcY51PJBeF8ye6z/cz0PnZKii LtQE0ZkoP7olhd6lbxd5bL0ZsCYlaqCPNTZdg+BnQLSLanfrf47R73+s8cBCPiW4qUd6l17PwBa CCri1f8Ich+JmUII5Z9ytgnYc4LPS40s16SvrLkM4TRCF38A/b+CU4Qsjd2+bUVmlPH2xgrdeg6 ZiiJu0SZM9Hu4xmiSKzUmBw== X-Received: by 2002:a05:6000:40de:b0:3a5:783f:528a with SMTP id ffacd0b85a97d-3c5dcefee22mr195265f8f.59.1755806912310; Thu, 21 Aug 2025 13:08:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRe/VOMg0cdir08bDTWMwU06A85Ixelypa7wMbtHpunFYS8URS38ofNnAO5nDnYJmoWLlWSQ== X-Received: by 2002:a05:6000:40de:b0:3a5:783f:528a with SMTP id ffacd0b85a97d-3c5dcefee22mr195231f8f.59.1755806911819; Thu, 21 Aug 2025 13:08:31 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b50f16eb1sm7598185e9.3.2025.08.21.13.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:08:31 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Brett Creeley , Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 30/35] vfio/pci: drop nth_page() usage within SG entry Date: Thu, 21 Aug 2025 22:06:56 +0200 Message-ID: <20250821200701.1329277-31-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mOD1Cy6Q_5haWgjXNYG-QmSGj1vwGgC_NFjEVHE6a74_1755806912 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It's no longer required to use nth_page() when iterating pages within a single SG entry, so let's drop the nth_page() usage. Cc: Brett Creeley Cc: Jason Gunthorpe Cc: Yishai Hadas Cc: Shameer Kolothum Cc: Kevin Tian Cc: Alex Williamson Signed-off-by: David Hildenbrand --- drivers/vfio/pci/pds/lm.c | 3 +-- drivers/vfio/pci/virtio/migrate.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c index f2673d395236a..4d70c833fa32e 100644 --- a/drivers/vfio/pci/pds/lm.c +++ b/drivers/vfio/pci/pds/lm.c @@ -151,8 +151,7 @@ static struct page *pds_vfio_get_file_page(struct pds_vfio_lm_file *lm_file, lm_file->last_offset_sg = sg; lm_file->sg_last_entry += i; lm_file->last_offset = cur_offset; - return nth_page(sg_page(sg), - (offset - cur_offset) / PAGE_SIZE); + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; } cur_offset += sg->length; } diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c index ba92bb4e9af94..7dd0ac866461d 100644 --- a/drivers/vfio/pci/virtio/migrate.c +++ b/drivers/vfio/pci/virtio/migrate.c @@ -53,8 +53,7 @@ virtiovf_get_migration_page(struct virtiovf_data_buffer *buf, buf->last_offset_sg = sg; buf->sg_last_entry += i; buf->last_offset = cur_offset; - return nth_page(sg_page(sg), - (offset - cur_offset) / PAGE_SIZE); + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; } cur_offset += sg->length; } -- 2.50.1