From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 280D3CA0EFA for ; Mon, 25 Aug 2025 13:43:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AF8210E476; Mon, 25 Aug 2025 13:43:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="sqFlSdR6"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2F2010E473; Mon, 25 Aug 2025 13:43:35 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 12C985C5D69; Mon, 25 Aug 2025 13:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38BB9C4CEED; Mon, 25 Aug 2025 13:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756129414; bh=wsGg4o5rIk6iWnwj3c0e+ddrWYACRADM//93hdU20w4=; h=From:Subject:Date:To:Cc:From; b=sqFlSdR6wzioHCIWCTuXe4gIb398iawEGQ0noC6vq3qfSpKD/GhQbNFo/BZMPrL04 fKiuK5wA+i9NFKyGHsjC/hJ22L6DxIOxsIDCQWlHDlbpVj4xLCLv/3e48GURiiSEpo CpRm/oIfhfcKqoepBNvwkntHaXlfSkrgtiWe3FtbOG2bPeTeDS1nsYCI+SbIpjF4oW nclGltUfOEK7eUrRlCc238qoG8MsuEdWy35bURpgLz+Tisfc/MMY954heq9Pnfqqmt RuDCuulMO26sW/CkrFyLalMIN8EiP3wn/2vWATpdOdqe7dd/1NPRg1OQrbh1TYYeIh wB6/rJBuExbaQ== From: Maxime Ripard Subject: [PATCH 00/39] drm/atomic: Get rid of existing states (not really) Date: Mon, 25 Aug 2025 15:43:05 +0200 Message-Id: <20250825-drm-no-more-existing-state-v1-0-f08ccd9f85c9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGlorGgC/x3MwQqDMAwA0F+RnBeoKQW3XxEPrUaXg+1IyhCk/ 76y47u8G4xV2OA13KD8FZOSO8bHAOs75oNRtm4gR8FNFHDTE3PBsygjX2JV8oFWY2V8Jk+B1jF 6n6AHH+Vdrn8+L639AIn9C4BsAAAA X-Change-ID: 20250825-drm-no-more-existing-state-9b3252c1a33b To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen , Jyri Sarha , Tomi Valkeinen , Paul Cercueil , Liviu Dudau , Russell King , Manikandan Muralidharan , Dharma Balasubiramani , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Anitha Chrisanthus , Edmund Dea , Paul Kocialkowski , Sui Jingfeng , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Hans de Goede , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5301; i=mripard@kernel.org; h=from:subject:message-id; bh=wsGg4o5rIk6iWnwj3c0e+ddrWYACRADM//93hdU20w4=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDBlrMoqmcab9SaxeoL8+8fGLztO2hw5uF8s7cXj22mXn5 tepO9/r7ZjKwiDMySArpsjyRCbs9PL2xVUO9it/wMxhZQIZwsDFKQATuXKdsaHn3ankZUatfg2R r99tjDXavWHDnETW9lnXphXduWK1i3/PAUFhlmbnCXk1p2ez1uZ9qmBseF0nvzr8bH5d1fUWnkc 9/asdYqdWijaknuX6vvl6Q5LYkrt7xcpMPwdtYnle5sEVXLUIAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Here's a series to get rid of the drm_atomic_helper_get_existing_*_state accessors. The initial intent was to remove the __drm_*_state->state pointer to only rely on old and new states, but we still need it now to know which of the two we need to free: if a state has not been committed (either dropped or checked only), then we need to free the new one, if it has been committed we need to free the old state. Thus, the state pointer is kept (and documented) only to point to the state we should free eventually. All users have been converted to the relevant old or new state accessors. This was build tested only. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Maxime Ripard (39): drm/atomic: Make drm_atomic_get_connector_state() early return consistent drm/atomic: Convert drm_atomic_get_connector_state() to state accessor drm/atomic: Convert drm_atomic_get_connector_state() to use new connector state drm/atomic: Remove unused drm_atomic_get_existing_connector_state() drm/atomic: Document __drm_connectors_state state pointer drm/atomic: Convert __drm_atomic_get_current_plane_state() to modern accessor drm/atomic: Convert drm_atomic_get_plane_state() to use new plane state drm/vkms: Convert vkms_crtc_atomic_check() to use new plane state drm/tilcdc: crtc: Use drm_atomic_helper_check_crtc_primary_plane() drm/atomic: Remove unused drm_atomic_get_existing_plane_state() drm/atomic: Document __drm_planes_state state pointer drm/atomic: Convert drm_atomic_get_crtc_state() to use new connector state drm/ingenic: ipu: Switch to drm_atomic_get_new_crtc_state() drm/arm/malidp: Switch to drm_atomic_get_new_crtc_state() drm/armada: Switch to drm_atomic_get_new_crtc_state() drm/atmel-hlcdc: Switch to drm_atomic_get_new_crtc_state() drm/exynos: Switch to drm_atomic_get_new_crtc_state() drm/imx-dc: Switch to drm_atomic_get_new_crtc_state() drm/imx-dcss: Switch to drm_atomic_get_new_crtc_state() drm/imx-ipuv3: Switch to drm_atomic_get_new_crtc_state() drm/ingenic: Switch to drm_atomic_get_new_crtc_state() drm/kmb: Switch to drm_atomic_get_new_crtc_state() drm/logicvc: Switch to drm_atomic_get_new_crtc_state() drm/loongson: Switch to drm_atomic_get_new_crtc_state() drm/mediatek: Switch to drm_atomic_get_new_crtc_state() drm/msm/mdp5: Switch to drm_atomic_get_new_crtc_state() drm/omap: Switch to drm_atomic_get_new_crtc_state() drm/rockchip: Switch to drm_atomic_get_new_crtc_state() drm/sun4i: Switch to drm_atomic_get_new_crtc_state() drm/tegra: Switch to drm_atomic_get_new_crtc_state() drm/tilcdc: Switch to drm_atomic_get_new_crtc_state() drm/vboxvideo: Switch to drm_atomic_get_new_crtc_state() drm/vc4: Switch to drm_atomic_get_new_crtc_state() drm/atomic: Switch to drm_atomic_get_new_crtc_state() drm/framebuffer: Switch to drm_atomic_get_new_crtc_state() drm/atomic: Remove unused drm_atomic_get_existing_crtc_state() drm/atomic: Document __drm_crtcs_state state pointer drm/atomic: Convert drm_atomic_get_private_obj_state() to use new plane state drm/atomic: Document __drm_private_objs_state state pointer drivers/gpu/drm/arm/malidp_planes.c | 2 +- drivers/gpu/drm/armada/armada_plane.c | 3 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- drivers/gpu/drm/drm_atomic.c | 23 ++-- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +- drivers/gpu/drm/imx/dc/dc-plane.c | 2 +- drivers/gpu/drm/imx/dcss/dcss-plane.c | 4 +- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 3 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 3 +- drivers/gpu/drm/ingenic/ingenic-ipu.c | 4 +- drivers/gpu/drm/kmb/kmb_plane.c | 3 +- drivers/gpu/drm/logicvc/logicvc_layer.c | 4 +- drivers/gpu/drm/loongson/lsdc_plane.c | 2 +- drivers/gpu/drm/mediatek/mtk_plane.c | 3 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 7 +- drivers/gpu/drm/omapdrm/omap_plane.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 3 +- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 3 +- drivers/gpu/drm/tegra/dc.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +- drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 +- drivers/gpu/drm/vboxvideo/vbox_mode.c | 8 +- drivers/gpu/drm/vc4/vc4_plane.c | 6 +- drivers/gpu/drm/vkms/vkms_crtc.c | 4 +- include/drm/drm_atomic.h | 144 ++++++++++++------------ 28 files changed, 125 insertions(+), 136 deletions(-) --- base-commit: 7fa4d8dc380fbd81a9d702a855c50690c9c6442c change-id: 20250825-drm-no-more-existing-state-9b3252c1a33b Best regards, -- Maxime Ripard