From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE901CA0FE7 for ; Mon, 25 Aug 2025 13:44:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5344D10E493; Mon, 25 Aug 2025 13:44:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Yo7uFRbY"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F2A710E48E; Mon, 25 Aug 2025 13:44:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0819244D7D; Mon, 25 Aug 2025 13:44:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 680F5C116D0; Mon, 25 Aug 2025 13:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756129456; bh=jwpa6CJEP2ubfKRCAjsrSSxCi0tUyYxFZe/THLd4Tak=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Yo7uFRbYFma10rAkRJpRBze4IKA64QXDoB0MxcmOsrLbWcD2b2Hb95zr5wIcLK3fG 9BVLxJl84DBZb6Qispw7CkAldKM7cs9RaSiCDJqlIIfLanWNMqLm3mqHES7aYzj7s0 RiXPMsSE/lXKPGHcWxL6+4Vq+lDx3ldG/2pyUS9xIC+lHbqOhPJ2LAedLj5IlWd2AR SNbPPJ/21ATJvXSxlfJieEItgrjCEL0Ts+aEHVskc0+blUwmKUG+ttJZ4Hy7otZKiN cMpiA6WvBeE6s7kYeuL1VaVC1q3Wve4M7Ul0d2Rne3o2888drckmSWUmMRMY5Kg8e3 wajjZRdr8rlyw== From: Maxime Ripard Date: Mon, 25 Aug 2025 15:43:20 +0200 Subject: [PATCH 15/39] drm/armada: Switch to drm_atomic_get_new_crtc_state() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250825-drm-no-more-existing-state-v1-15-f08ccd9f85c9@kernel.org> References: <20250825-drm-no-more-existing-state-v1-0-f08ccd9f85c9@kernel.org> In-Reply-To: <20250825-drm-no-more-existing-state-v1-0-f08ccd9f85c9@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen , Jyri Sarha , Tomi Valkeinen , Paul Cercueil , Liviu Dudau , Russell King , Manikandan Muralidharan , Dharma Balasubiramani , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Anitha Chrisanthus , Edmund Dea , Paul Kocialkowski , Sui Jingfeng , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Hans de Goede , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1178; i=mripard@kernel.org; h=from:subject:message-id; bh=jwpa6CJEP2ubfKRCAjsrSSxCi0tUyYxFZe/THLd4Tak=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDBlrMipm1jo8C4w8YL9pvd4vpZDJZ6qnTo+fuF/zjc0Zz auPut4rdUxlYRDmZJAVU2R5IhN2enn74ioH+5U/YOawMoEMYeDiFICJlP5grBUO0Uidz7hA7Hqk yqwPp50ScjPSX7AWJnelRfxZIzP9fKzqf+uVFaFXM5ZmT3s65cW8t4y1kjbeacxLZmq7+Rx8Uuq 4yrcjyudehn+yz3E/wfeK85bt+Vhw7FGB7Q/5G2n53SbrlB4CAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The armada atomic_check implementation uses the deprecated drm_atomic_get_existing_crtc_state() helper. This hook is called as part of the global atomic_check, thus before the states are swapped. The existing state thus points to the new state, and we can use drm_atomic_get_new_crtc_state() instead. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/armada/armada_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_plane.c b/drivers/gpu/drm/armada/armada_plane.c index cc47c032dbc151a463cbd0b0d048c74c2828f253..786bcce0dc20eadab14c5bee97593ae3e05732b1 100644 --- a/drivers/gpu/drm/armada/armada_plane.c +++ b/drivers/gpu/drm/armada/armada_plane.c @@ -93,12 +93,11 @@ int armada_drm_plane_atomic_check(struct drm_plane *plane, new_plane_state->visible = false; return 0; } if (state) - crtc_state = drm_atomic_get_existing_crtc_state(state, - crtc); + crtc_state = drm_atomic_get_new_crtc_state(state, crtc); else crtc_state = crtc->state; ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state, 0, -- 2.50.1