From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F40F8CA0FE7 for ; Mon, 25 Aug 2025 14:17:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69DC810E4BA; Mon, 25 Aug 2025 14:17:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="bj3zrLUB"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36B8710E4BE for ; Mon, 25 Aug 2025 14:17:48 +0000 (UTC) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57P8Ae1I006172 for ; Mon, 25 Aug 2025 14:17:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4ZQpVtqMzNy57YEFxSSc+VOVJ/6Kni0tmKKCMTUEH7Q=; b=bj3zrLUBFYMN7pV3 wy47Ih7DTQvll4qZs1lnzelO5Mul7V4gjrX4Qfin4u2nHCvkhYv4QTa43WC9ipI1 PW885/v01v1Zpfr4GUixWTk0RSmj8lFzJovVM4pmm+WvUsA/vjE4cFPk6O9UBnRN zvXlwUsE2VNzhv4aIn3N/mmvprCUQxNpT9PGq1g5B2+CiZInREjup2FWhtGiNI17 Sb0CCD/vrNCMhjZpriJnIv8o64nPttynsydz/Fk4iObgCjvhPaTahaRqis0wTycL UUycY/QJ8+3wbPgsZrrglsLGiyPokHer3NYxdMq4TJm+hrWG99eED4SK0ZPttnzX 1PeIDA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q6thwb8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 25 Aug 2025 14:17:47 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-771d7aa1470so923843b3a.2 for ; Mon, 25 Aug 2025 07:17:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756131467; x=1756736267; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ZQpVtqMzNy57YEFxSSc+VOVJ/6Kni0tmKKCMTUEH7Q=; b=lF8em5YuVe+oKwSvsFZzDjWpWxpZjmpyD+uYVgC2hQd+0K1Iym02gO2CWvQfM7PpB9 AfvvfNKvHDFEFV/UdRXfyIHJ1VXh/ALUim9KgkMicX1X1+QlT+7UgREZ9XJ6fXUtnu+j xUEb0sT9ql0hYqcerIuty7NNrmsWiruFIW1WNTr8v9FxTZtxiXj0oIMabe0nyq6EsnFV 2tRniiFxTmbaiMcoadmiuVMkI0wsjmanlc8gzd6ZJKhUMsgMSeZdIyMYK0rzED32ea7P /GQn+8PWgvRv72nJXuNh1tfz+SZS23IgTtlVCpHlFEc0B6tkmuidbt1J5Ni9I+rw+U1k fHng== X-Forwarded-Encrypted: i=1; AJvYcCVnZf/NdxofKDomiPQI9Cv3PB/aY8usgieS0CjqFE0oUxeAB3jSl03zi3hkcpr/tRHZp24yBokf2Zs=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzF5widyQQVmUz5GbFHLT7nZzD8sDrfN9HXpW2k6zPKE4Zs9b7R vkScn2Yh4tBI49LDFi14mMRbsR4Htxt+vFD8M1mkvee9XQUWqQOYrj4WDESCML6mKKUzbUU5R3G RV0p3Tpg9uAgtpMvs4Qn/9ysEdLJ4iPDjCtrEBDPU3iTIQuAfw1mLn2Sr85l/JUvpm6LizA4= X-Gm-Gg: ASbGnctb7zT7kG/thAINjsRaqof6402zLTFSItg22uPWvq5+epuHpYvHmlQl0TmaoFt rLl+qiqSo1tDl55uYWwVzl5O9KM5mL0oPi83x8pC1+HaTt5ajN9GabmdWt4+sfvRxD9GqvupYhi pOqW70XJ1gfZVPspnTC+ThDmzLT5ViDUETpdq01xT/P9Y0teaa9hKbMZSV8jbxoC9gBnehu1XrJ q36DrJ3Mhd3QFOEsEFfYEOF5T5wJdBN7Anf08qo8JDVHD0eFT3FRw3HiAkBb/m+6V5nDMM4D4gB fpxGCtjGrC3Zld9UvXaMMke7oVgRrcnLrT2DVIYSmO2Ws2USkRxr4fi8EBs4uDcUWfJxHuE= X-Received: by 2002:a05:6a00:4095:b0:771:e434:6c80 with SMTP id d2e1a72fcca58-771e43485c6mr2974435b3a.11.1756131466414; Mon, 25 Aug 2025 07:17:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+Jr0mP2nSand5ZXOOfqSwSeW0fpa8FmcZugfpErsaJhDtP/GLcW5jzX9aJVdVBXmre/4Zfg== X-Received: by 2002:a05:6a00:4095:b0:771:e434:6c80 with SMTP id d2e1a72fcca58-771e43485c6mr2974409b3a.11.1756131465935; Mon, 25 Aug 2025 07:17:45 -0700 (PDT) Received: from cse-cd01-lnx.ap.qualcomm.com ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-770401eb20dsm7672339b3a.79.2025.08.25.07.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:17:45 -0700 (PDT) From: Yongxing Mou Date: Mon, 25 Aug 2025 22:15:55 +0800 Subject: [PATCH v3 09/38] drm/msm/dp: split dp_ctrl_off() into stream and link parts MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250825-msm-dp-mst-v3-9-01faacfcdedd@oss.qualcomm.com> References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> In-Reply-To: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756131419; l=3961; i=yongxing.mou@oss.qualcomm.com; s=20241121; h=from:subject:message-id; bh=+g0HjmHzCDQXI6sBnIuFR57IMToALs8q5AH6Jj3XDa8=; b=P4vXdvybIYIJKpZ9XXDRsTLNqtzIEdT2hbx4huEOozKqnoR71Rvl44rHeXKIwyyOGxpcx3Ixe h/wGlldqGggAaekA/Ok4Ctyo1kOMzDAehF4P9xMsAmnAlVYSd58N788 X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=zeCnFRUqtOQMeFvdwex2M5o0Yf67UHYfwCyBRQ3kFbU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDA0MyBTYWx0ZWRfX3vOrRS8omtXR xKa+BQi1W5SXz1Rm6PrQkRVmLJCtpvRVFfeUejpX/qcEWAo64T8x8fN04sLRt8I3JKFqlBeh6a5 hq1CbBPOyOHpWSf9ehRajE5eKvwrRG75BWkmTkzdTGAAjlLBD9fqVDmuTTru/9FxT8UapP30zq0 rYBSsjgU0RYl9Q9aW6QOt7AN8a/PAoOw6Cd3wwRuWkOeRgYrpRAnMflUTyfmttDUegkEjv2UaUx 8lBmzh3gt94FzbjcMs7t6ZuqYwK1z4Km2QjL3PN4ZF3O+jUpfCWjHwAwQ8+hlinIVXX32N/WM4r sZT/0JgYoPpoi0y3MAH9j924hFOTxyObgwXEz+vmda6x7r4PWbBpR63h2RIbac2rv8NC/YoF7lZ FsDuBkGw X-Proofpoint-ORIG-GUID: Da75R5ofDyoqCiKkElc39UDXPQtI8BY_ X-Proofpoint-GUID: Da75R5ofDyoqCiKkElc39UDXPQtI8BY_ X-Authority-Analysis: v=2.4 cv=W544VQWk c=1 sm=1 tr=0 ts=68ac708b cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=OtQsdMd2eBjxU-v0TgUA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-25_06,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230043 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Abhinav Kumar Split dp_ctrl_off() into stream and link parts so that for MST cases we can control the link and pixel parts separately. Signed-off-by: Abhinav Kumar Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 ++- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index c0001b93a194821927507028f392877db585fd2c..b25eb2fa2835f660073b5109496ac9f2f4e038d2 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -2186,7 +2186,7 @@ static int msm_dp_ctrl_on_pixel_clk(struct msm_dp_ctrl_private *ctrl, unsigned l return ret; } -static void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl) +void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl) { struct msm_dp_ctrl_private *ctrl; @@ -2214,7 +2214,8 @@ static int msm_dp_ctrl_process_phy_test_request(struct msm_dp_ctrl_private *ctrl * running. Add the global reset just before disabling the * link clocks and core clocks. */ - msm_dp_ctrl_off(&ctrl->msm_dp_ctrl); + msm_dp_ctrl_off_pixel_clk(&ctrl->msm_dp_ctrl); + msm_dp_ctrl_off_link(&ctrl->msm_dp_ctrl); ret = msm_dp_ctrl_on_link(&ctrl->msm_dp_ctrl); if (ret) { @@ -2595,7 +2596,7 @@ void msm_dp_ctrl_reinit_phy(struct msm_dp_ctrl *msm_dp_ctrl) phy, phy->init_count, phy->power_count); } -void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl) +void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl) { struct msm_dp_ctrl_private *ctrl; struct phy *phy; @@ -2609,7 +2610,6 @@ void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl) msm_dp_ctrl_reset(&ctrl->msm_dp_ctrl); - msm_dp_ctrl_off_pixel_clk(msm_dp_ctrl); dev_pm_opp_set_rate(ctrl->dev, 0); msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl); diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_ctrl.h index 78406c757eccf95e82f1a9d4437ebdbbc4f8ea46..6ff3e9d9fa6ff0afa325a7a6f72a15009635f340 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h @@ -19,7 +19,8 @@ struct phy; int msm_dp_ctrl_on_link(struct msm_dp_ctrl *msm_dp_ctrl); int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, struct msm_dp_panel *msm_dp_panel); int msm_dp_ctrl_prepare_stream_on(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train); -void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl); +void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl); +void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl); void msm_dp_ctrl_push_idle(struct msm_dp_ctrl *msm_dp_ctrl); irqreturn_t msm_dp_ctrl_isr(struct msm_dp_ctrl *msm_dp_ctrl); void msm_dp_ctrl_handle_sink_request(struct msm_dp_ctrl *msm_dp_ctrl); diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index d07bb40f848e0e13a0fa32aa70ffb1621edca159..c5c502e51b94a6ac4b9a893b43eb88e87a0c0d46 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -784,7 +784,8 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) /* set dongle to D3 (power off) mode */ msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); - msm_dp_ctrl_off(dp->ctrl); + msm_dp_ctrl_off_pixel_clk(dp->ctrl); + msm_dp_ctrl_off_link(dp->ctrl); /* re-init the PHY so that we can listen to Dongle disconnect */ msm_dp_ctrl_reinit_phy(dp->ctrl); } else { @@ -792,7 +793,8 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) * unplugged interrupt * dongle unplugged out of DUT */ - msm_dp_ctrl_off(dp->ctrl); + msm_dp_ctrl_off_pixel_clk(dp->ctrl); + msm_dp_ctrl_off_link(dp->ctrl); msm_dp_display_host_phy_exit(dp); } -- 2.34.1