dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Shengyu Qu <wiagn233@outlook.com>,
	 Marius Vlad <marius.vlad@collabora.com>,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	 airlied@gmail.com, simona@ffwll.ch, harry.wentland@amd.com,
	sunpeng.li@amd.com, siqueira@igalia.com,
	maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
	 contact@rafaelrc.com, lijo.lazar@amd.com, jesse.zhang@amd.com,
	tim.huang@amd.com,  dark_sylinc@yahoo.com.ar,
	mario.limonciello@amd.com, alex.hung@amd.com,
	 aurabindo.pillai@amd.com, sunil.khatri@amd.com,
	chiahsuan.chung@amd.com, mwen@igalia.com,  Roman.Li@amd.com,
	Wayne.Lin@amd.com, dominik.kaszewski@amd.com, alvin.lee2@amd.com,
	 Aric.Cyr@amd.com, Austin.Zheng@amd.com, Sung.Lee@amd.com,
	PeiChen.Huang@amd.com, dillon.varone@amd.com,
	Richard.Chiang@amd.com, ryanseto@amd.com, linux@treblig.org,
	 haoping.liu@amd.com, Relja.Vojvodic@amd.com, Yihan.Zhu@amd.com,
	Samson.Tam@amd.com,  amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 0/2] Add "pixel_encoding" to switch between RGB & YUV color modes
Date: Wed, 27 Aug 2025 13:21:19 +0200	[thread overview]
Message-ID: <20250827-enchanted-merciful-badger-d51816@houat> (raw)
In-Reply-To: <CAPj87rPhK+E2FP62fnNxFySDOkqqKxo_oa94i7DR3_6a1j1o1A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]

On Wed, Aug 27, 2025 at 11:39:25AM +0100, Daniel Stone wrote:
> Hey,
> 
> On Wed, 27 Aug 2025 at 10:41, Maxime Ripard <mripard@kernel.org> wrote:
> > On Wed, Aug 27, 2025 at 12:26:56AM +0800, Shengyu Qu wrote:
> > > 1.Can you send patch with only i915/amdgpu first? It's a long-needed feature
> > > to deal with some monitors/TVs with broken EDID.
> >
> > If it's to workaround broken monitors, then it's really not something we
> > should be doing using a property.
> >
> > Most likely, those monitors don't support YUV* output and will just need
> > to be forced to RGB, so it's not something that the user (or the
> > compositor, really) has to care about.
> >
> > And it would be broken with every driver, not just i915 and amdgpu.
> >
> > We already have some quirks infrastructure in place, the only thing we
> > need to do is create an EDID_QUIRK_NO_$FORMAT, clear
> > drm_display_info->color_formats based on it, and you're done. No uapi to
> > agree upon, support, test, and it works with every driver.
> 
> There are other reasons to have uAPI though ...
> 
> One is because you really care about the colour properties, and you'd
> rather have better fidelity than anything else, even if it means some
> modes are unusable.
> 
> Another is for situations which static quirks can't handle. If you
> want to keep headroom on the link (either to free up bandwidth for
> other uses), or you accidentally bought a super-long cable so have a
> flaky link, you might well want to force it to use lower fidelity so
> you can negotiate a lower link rate.
> 
> I'm all for just dtrt automatically, but there are definitely reasons
> to expose it to userspace regardless.

Oh, yeah, definitely.

But bringing the big guns and the requirements we have for those to
address the point initially discussed by the gitlab issues seems like
biting off more than they can chew.

Even more so since whatever uapi we come up with would still depend on
the EDIDs, and they would still be broken for these monitors.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

  parent reply	other threads:[~2025-08-27 11:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 18:39 [PATCH v2 0/2] Add "pixel_encoding" to switch between RGB & YUV color modes Shengyu Qu
2025-08-26  7:24 ` Marius Vlad
2025-08-26 16:26   ` Shengyu Qu
2025-08-27  8:21     ` Marius Vlad
2025-08-27  9:41     ` Maxime Ripard
2025-08-27 10:39       ` Daniel Stone
2025-08-27 11:08         ` Sebastian Wick
2025-09-01 21:32           ` Sebastian Wick
2025-08-27 11:21         ` Maxime Ripard [this message]
2025-08-27 11:36           ` Daniel Stone
2025-08-27 11:40             ` Maxime Ripard
2025-08-27 15:36             ` Shengyu Qu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827-enchanted-merciful-badger-d51816@houat \
    --to=mripard@kernel.org \
    --cc=Aric.Cyr@amd.com \
    --cc=Austin.Zheng@amd.com \
    --cc=PeiChen.Huang@amd.com \
    --cc=Relja.Vojvodic@amd.com \
    --cc=Richard.Chiang@amd.com \
    --cc=Roman.Li@amd.com \
    --cc=Samson.Tam@amd.com \
    --cc=Sung.Lee@amd.com \
    --cc=Wayne.Lin@amd.com \
    --cc=Yihan.Zhu@amd.com \
    --cc=airlied@gmail.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alvin.lee2@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=chiahsuan.chung@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=contact@rafaelrc.com \
    --cc=daniel@fooishbar.org \
    --cc=dark_sylinc@yahoo.com.ar \
    --cc=dillon.varone@amd.com \
    --cc=dominik.kaszewski@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haoping.liu@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=jesse.zhang@amd.com \
    --cc=lijo.lazar@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=marius.vlad@collabora.com \
    --cc=mwen@igalia.com \
    --cc=ryanseto@amd.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunil.khatri@amd.com \
    --cc=sunpeng.li@amd.com \
    --cc=tim.huang@amd.com \
    --cc=tzimmermann@suse.de \
    --cc=wayland-devel@lists.freedesktop.org \
    --cc=wiagn233@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).