* [PATCH v2] drm/gem-shmem: Use drm_gem_shmem_unpin() to unpin the backing pages for a shmem GEM
@ 2025-08-28 12:08 Xiaolei Wang
0 siblings, 0 replies; only message in thread
From: Xiaolei Wang @ 2025-08-28 12:08 UTC (permalink / raw)
To: boris.brezillon, maarten.lankhorst, mripard, tzimmermann,
dmitry.baryshkov, airlied, simona, dmitry.osipenko
Cc: dri-devel, linux-kernel
Although drm_gem_shmem_free() will decrease the use count
on the backing pages and free backing pages for a GEM object,
the pages_pin_count count is not decremented, which results
in a warning. Therefore, use drm_gem_shmem_unpin() to unpin
the backing pages for a shmem GEM.
WARNING: CPU: 2 PID: 1106 at drivers/gpu/drm/drm_gem_shmem_helper.c:180 drm_gem_shmem_free+0x4d0/0x6f0
Call trace:
drm_gem_shmem_free+0x4d0/0x6f0 (P)
drm_gem_shmem_free_wrapper+0x10/0x1c
__kunit_action_free+0x50/0x70
kunit_remove_resource+0x144/0x1e4
kunit_cleanup+0x64/0xfc
kunit_try_run_case_cleanup+0xa0/0xd4
kunit_generic_run_threadfn_adapter+0x80/0xec
kthread+0x3b8/0x6c0
ret_from_fork+0x10/0x20
Fixes: 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by shmem")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
---
v1: https://patchwork.kernel.org/project/dri-devel/patch/20250827022516.2890226-1-xiaolei.wang@windriver.com/
v2: compared with v1, update subject
drivers/gpu/drm/tests/drm_gem_shmem_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tests/drm_gem_shmem_test.c b/drivers/gpu/drm/tests/drm_gem_shmem_test.c
index 68f2c3162354..e0a9f3a917ed 100644
--- a/drivers/gpu/drm/tests/drm_gem_shmem_test.c
+++ b/drivers/gpu/drm/tests/drm_gem_shmem_test.c
@@ -227,6 +227,7 @@ static void drm_gem_shmem_test_get_pages_sgt(struct kunit *test)
len += sg->length;
}
+ drm_gem_shmem_unpin(shmem);
KUNIT_EXPECT_GE(test, len, TEST_SIZE);
}
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-08-28 12:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-28 12:08 [PATCH v2] drm/gem-shmem: Use drm_gem_shmem_unpin() to unpin the backing pages for a shmem GEM Xiaolei Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).