Re: [PATCH i-g-t 3/4] lib: initial panthor infrastructure

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Daniel,
On 2025-08-28 at 10:03:59 -0300, Daniel Almeida wrote:
> Add the basic infrastructure that will be used by the Panthor tests
> themselves.
> 
> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
> ---
>  lib/igt_panthor.c | 14 ++++++++++++++
>  lib/igt_panthor.h |  8 ++++++++
>  lib/meson.build   |  1 +

Could you squash patch 2 and this one plus one basic test?
imho panthor_query.c is a good candidate for a first
working test, simple enough.

>  3 files changed, 23 insertions(+)
>  create mode 100644 lib/igt_panthor.c
>  create mode 100644 lib/igt_panthor.h
> 
> diff --git a/lib/igt_panthor.c b/lib/igt_panthor.c
> new file mode 100644
> index 000000000..3e2c29b17
> --- /dev/null
> +++ b/lib/igt_panthor.c
> @@ -0,0 +1,14 @@
> +// SPDX-License-Identifier: MIT
> +// SPDX-FileCopyrightText: Copyright (C) 2025 Collabora Ltd.
> +
> +#include "igt_panthor.h"
> +
> +/**
> + * SECTION:igt_panthor
> + * @short_description: Panthor support library
> + * @title: Panthor
> + * @include: igt.h
> + *
> + * This library provides various auxiliary helper functions for writing Panthor
> + * tests.
> + */
> diff --git a/lib/igt_panthor.h b/lib/igt_panthor.h
> new file mode 100644
> index 000000000..c4bee1838
> --- /dev/null
> +++ b/lib/igt_panthor.h
> @@ -0,0 +1,8 @@
> +// SPDX-License-Identifier: MIT

In headers you should use C-ctyle comments:

/* SPDX-License-Identifier: MIT */

> +// SPDX-FileCopyrightText: Copyright (C) 2025 Collabora Ltd.

Same here.

Regards,
Kamil

> +
> +#ifndef IGT_PANTHOR_H
> +#define IGT_PANTHOR_H
> +
> +
> +#endif /* IGT_PANTHOR_H */
> diff --git a/lib/meson.build b/lib/meson.build
> index f078dad4e..1738f1b54 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -104,6 +104,7 @@ lib_sources = [
>  	'igt_kmod.c',
>  	'igt_ktap.c',
>  	'igt_panfrost.c',
> +	'igt_panthor.c',
>  	'igt_v3d.c',
>  	'igt_vc4.c',
>  	'igt_vmwgfx.c',
> -- 
> 2.50.1
>