Re: [PATCH i-g-t 0/4] Add initial Panthor tests

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Daniel,
On 2025-08-28 at 10:03:56 -0300, Daniel Almeida wrote:
> 
> This series adds basic Panthor tests. In particular, these are being
> used to test both Panthor and Tyr, i.e.: the new Rust GPU driver that
> implements Panthor's uAPI. Most of the initial tests were chosen in

Could you give link(s) to both driver and uAPI? Preferably on
lore.kernel.org. Also could you write which real hardware GPUs
are tested?

> order to have something to test Tyr with, but this series lays the
> groundwork so that more interesting tests can be added to test more of
> Panthor itself.

Imho you could also write this paragraph in you first patch
for drmtest.

> 
> Also, please note that this is my first IGT patch, so apologies in
> advance in case I forgot to follow any IGT-specific workflow when
> submitting this. I don't see a checkpatch.pl equivalent, so there was
> nothing to check this submission with as far as I am aware.

There is info about patchwork in CONTRIBUTING.md, you could just
reuse kernel one. Also there is config .checkpatch.conf in IGTs.

Regards,
Kamil

> 
> Daniel Almeida (4):
>   lib: add support for opening Panthor devices
>   tests: panthor: add initial infrastructure
>   lib: initial panthor infrastructure
>   tests/panthor: add panthor tests
> 
>  lib/drmtest.c                 |   1 +
>  lib/drmtest.h                 |   1 +
>  lib/igt_panthor.c             | 150 +++++++++++++++++++
>  lib/igt_panthor.h             |  28 ++++
>  lib/meson.build               |   1 +
>  meson.build                   |   8 ++
>  tests/meson.build             |   2 +
>  tests/panthor/meson.build     |  15 ++
>  tests/panthor/panthor_gem.c   |  59 ++++++++
>  tests/panthor/panthor_group.c | 264 ++++++++++++++++++++++++++++++++++
>  tests/panthor/panthor_query.c |  25 ++++
>  tests/panthor/panthor_vm.c    |  73 ++++++++++
>  12 files changed, 627 insertions(+)
>  create mode 100644 lib/igt_panthor.c
>  create mode 100644 lib/igt_panthor.h
>  create mode 100644 tests/panthor/meson.build
>  create mode 100644 tests/panthor/panthor_gem.c
>  create mode 100644 tests/panthor/panthor_group.c
>  create mode 100644 tests/panthor/panthor_query.c
>  create mode 100644 tests/panthor/panthor_vm.c
> 
> -- 
> 2.50.1
>