From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 863CFCA1000 for ; Fri, 29 Aug 2025 11:48:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD30710EB91; Fri, 29 Aug 2025 11:48:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HlTIbhtk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B47910EB8F; Fri, 29 Aug 2025 11:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756468108; x=1788004108; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OR9EgNKhP8sKC/gBwydNR680+dklCAxg+EGNsCSykUY=; b=HlTIbhtkN2+1G5BhsmqXVp54NrEQgKvWQGXcpmjnt9bS1hlP9Qz7DXyc 5LIaKpSQXFBhXGz75lw90zNDhy1K0puh/KbpkZTFb6U+L/pr/z2dvT69X aljss1Q8zQnZAfHC+JosUsX0MDt6DGOTdHgOH/CDp2SKpdY6ePKUeyqH4 7xqbcBlZQbnTeKeOeVE5ygrq5rdVk0RvmS7/OC94Cmm89BhtuX/jFdjpH yBzTYsu3xXT2BZgmVbsLwWnQFn/8ooQ30UuZpE6CuL9kKxtZ43Y9cPh5K aEfimO2exFrdLjuC4Yglm0pJj2hH+sz76cco4UxYMnrxPcl5cPmlxeK9e A==; X-CSE-ConnectionGUID: 0AJZ9gMuSbmzaXdgm8W/xg== X-CSE-MsgGUID: k7+VwrvBS7WdjZut8gcUKg== X-IronPort-AV: E=McAfee;i="6800,10657,11536"; a="58818070" X-IronPort-AV: E=Sophos;i="6.18,221,1751266800"; d="scan'208";a="58818070" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2025 04:48:28 -0700 X-CSE-ConnectionGUID: 6S63SxXXToG+XS+BHcxIpg== X-CSE-MsgGUID: ad3jSbutTbmTqMw7PdHr6g== X-ExtLoop1: 1 Received: from kamilkon-desk.igk.intel.com (HELO localhost) ([10.211.136.201]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2025 04:48:25 -0700 Date: Fri, 29 Aug 2025 13:48:23 +0200 From: Kamil Konieczny To: Daniel Almeida Cc: adrinael@adrinael.net, arek@hiler.eu, juhapekka.heikkila@gmail.com, bhanuprakash.modem@gmail.com, ashutosh.dixit@intel.com, karthik.b.s@intel.com, boris.brezillon@collabora.com, liviu.dudau@arm.com, steven.price@arm.com, intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH i-g-t 0/4] Add initial Panthor tests Message-ID: <20250829114823.kxqjjrqdanbywsb6@kamilkon-DESK.igk.intel.com> Mail-Followup-To: Kamil Konieczny , Daniel Almeida , adrinael@adrinael.net, arek@hiler.eu, juhapekka.heikkila@gmail.com, bhanuprakash.modem@gmail.com, ashutosh.dixit@intel.com, karthik.b.s@intel.com, boris.brezillon@collabora.com, liviu.dudau@arm.com, steven.price@arm.com, intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20250828130402.2549948-1-daniel.almeida@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250828130402.2549948-1-daniel.almeida@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, On 2025-08-28 at 10:03:56 -0300, Daniel Almeida wrote: > > This series adds basic Panthor tests. In particular, these are being > used to test both Panthor and Tyr, i.e.: the new Rust GPU driver that > implements Panthor's uAPI. Most of the initial tests were chosen in Could you give link(s) to both driver and uAPI? Preferably on lore.kernel.org. Also could you write which real hardware GPUs are tested? > order to have something to test Tyr with, but this series lays the > groundwork so that more interesting tests can be added to test more of > Panthor itself. Imho you could also write this paragraph in you first patch for drmtest. > > Also, please note that this is my first IGT patch, so apologies in > advance in case I forgot to follow any IGT-specific workflow when > submitting this. I don't see a checkpatch.pl equivalent, so there was > nothing to check this submission with as far as I am aware. There is info about patchwork in CONTRIBUTING.md, you could just reuse kernel one. Also there is config .checkpatch.conf in IGTs. Regards, Kamil > > Daniel Almeida (4): > lib: add support for opening Panthor devices > tests: panthor: add initial infrastructure > lib: initial panthor infrastructure > tests/panthor: add panthor tests > > lib/drmtest.c | 1 + > lib/drmtest.h | 1 + > lib/igt_panthor.c | 150 +++++++++++++++++++ > lib/igt_panthor.h | 28 ++++ > lib/meson.build | 1 + > meson.build | 8 ++ > tests/meson.build | 2 + > tests/panthor/meson.build | 15 ++ > tests/panthor/panthor_gem.c | 59 ++++++++ > tests/panthor/panthor_group.c | 264 ++++++++++++++++++++++++++++++++++ > tests/panthor/panthor_query.c | 25 ++++ > tests/panthor/panthor_vm.c | 73 ++++++++++ > 12 files changed, 627 insertions(+) > create mode 100644 lib/igt_panthor.c > create mode 100644 lib/igt_panthor.h > create mode 100644 tests/panthor/meson.build > create mode 100644 tests/panthor/panthor_gem.c > create mode 100644 tests/panthor/panthor_group.c > create mode 100644 tests/panthor/panthor_query.c > create mode 100644 tests/panthor/panthor_vm.c > > -- > 2.50.1 >