From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D2F2CA0FFE for ; Tue, 2 Sep 2025 09:36:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD7BC10E637; Tue, 2 Sep 2025 09:36:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X7LMb2Lc"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9EF0F10E636; Tue, 2 Sep 2025 09:36:30 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 028B36020A; Tue, 2 Sep 2025 09:36:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D8AAC4CEF5; Tue, 2 Sep 2025 09:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756805789; bh=mF1oMNAAswMysU9IefhfhbtwBJF8lom60qn+fQ7AykQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=X7LMb2LcuK6lK1jbkun6qugktd0u0OwwNGyh699IIhUkN9R7boHjnuBw46uJrUT9S Lv5uBthMtyWOONgvsyMLAy+u6wJ+qBDnwdfJCNvrHjynf0TvbCTPgMKSAzfxY59UrK 4XP1lhQPBXHkqSOzRVqv/4j974uLUvRdSPtWsQD6Lh264gsU6Im4dgf/CslOTr8LLb A7gKUng6wgbqHpJWoDbYcglAJj6EvoBo5N7SrdHvBbL8MhnW7HKqd1Om68s64T2Bsd WtLL+C7a1wNsuzwJsjrzL49B+QYzSZzzQwCKj1kMnRBsGrx7J2fBiJRUQ5aLMyLou0 OjmrfbbGSIalQ== From: Maxime Ripard Date: Tue, 02 Sep 2025 11:35:23 +0200 Subject: [PATCH v2 24/37] drm/msm/mdp5: Switch to drm_atomic_get_new_crtc_state() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250902-drm-no-more-existing-state-v2-24-de98fc5f6d66@kernel.org> References: <20250902-drm-no-more-existing-state-v2-0-de98fc5f6d66@kernel.org> In-Reply-To: <20250902-drm-no-more-existing-state-v2-0-de98fc5f6d66@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2294; i=mripard@kernel.org; h=from:subject:message-id; bh=mF1oMNAAswMysU9IefhfhbtwBJF8lom60qn+fQ7AykQ=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDBnbdoXlpGtK28T4vEiv1dxVZDbvHbvyyokPyy55xC9Iq L//5sS0jqksDMKcDLJiiixPZMJOL29fXOVgv/IHzBxWJpAhDFycAjARhvmMDWf6XdyKpRY8/RN8 VluRcbam/OJ5icLK+6T3SBhWXrso9Uz29MU+l1LnuKs3buY6Pz/5hrHh9vm9wY9YXq7d6vJiX8Y OY35z3z9ya/M/656+YnSRqSqgNW/S/JPPqu5P1+v9setO8acXAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The msm atomic_check implementation uses the deprecated drm_atomic_get_existing_crtc_state() helper. This hook is called as part of the global atomic_check, thus before the states are swapped. The existing state thus points to the new state, and we can use drm_atomic_get_new_crtc_state() instead. Reviewed-by: Dmitry Baryshkov Acked-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- To: Rob Clark To: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Jessica Zhang Cc: Sean Paul Cc: Marijn Suijten Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org --- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c index 7c790406d533fbabb330c438419efb18204cc4b7..4ca183fb61a95af60ef5a2c011ae6b2a0df963f0 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c @@ -334,12 +334,11 @@ static int mdp5_plane_atomic_check(struct drm_plane *plane, crtc = new_plane_state->crtc ? new_plane_state->crtc : old_plane_state->crtc; if (!crtc) return 0; - crtc_state = drm_atomic_get_existing_crtc_state(state, - crtc); + crtc_state = drm_atomic_get_new_crtc_state(state, crtc); if (WARN_ON(!crtc_state)) return -EINVAL; return mdp5_plane_atomic_check_with_state(crtc_state, new_plane_state); } @@ -371,12 +370,12 @@ static int mdp5_plane_atomic_async_check(struct drm_plane *plane, struct mdp5_plane_state *mdp5_state = to_mdp5_plane_state(new_plane_state); struct drm_crtc_state *crtc_state; int min_scale, max_scale; int ret; - crtc_state = drm_atomic_get_existing_crtc_state(state, - new_plane_state->crtc); + crtc_state = drm_atomic_get_new_crtc_state(state, + new_plane_state->crtc); if (WARN_ON(!crtc_state)) return -EINVAL; if (!crtc_state->active) return -EINVAL; -- 2.50.1