From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC4B2CA1005 for ; Tue, 2 Sep 2025 08:33:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 599BB10E5E2; Tue, 2 Sep 2025 08:33:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="rVDAv5rs"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF76910E5E2 for ; Tue, 2 Sep 2025 08:33:29 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 23E136020E; Tue, 2 Sep 2025 08:33:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E4F0C4CEF7; Tue, 2 Sep 2025 08:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756802008; bh=1R/cmhynuL7ZkKUF0HfDvx8YnoSqeyk82pR1KuKcrL0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rVDAv5rsYs5Eg2FMQbAnvGb/nmo0/W1SCh+813xyTz0ayU50iPpplEQOh+VWYZy64 sm1ap9xpC4Da6PvBWw5jDvru+wpLDM/2LWu0Mb878h2ZCj8EU7KSBUukSOJCvd9B+z 4a5piVrvodkd3KIDZ47tk/uOPulwzjyKGGjEBTb/wWs1zFeQZaXfYOp4MUhAVwmFQ1 JgOXVfWP4MJZeJGnmvKYujVOjT2D7S8h/tSXDE/d3o1iPKwojKncoVuzeiXKsptcSZ mmO85QXTe+pLOHOHr7vakv/0QXLWR8388MZJvpfqoLixY6lne0Du6amRlrWGca8xYm g3LTEk75Z5jIg== From: Maxime Ripard Date: Tue, 02 Sep 2025 10:32:35 +0200 Subject: [PATCH 07/29] drm/atomic: Implement drm_atomic_print_old_state MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250902-drm-state-readout-v1-7-14ad5315da3f@kernel.org> References: <20250902-drm-state-readout-v1-0-14ad5315da3f@kernel.org> In-Reply-To: <20250902-drm-state-readout-v1-0-14ad5315da3f@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen Cc: Devarsh Thakkar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3588; i=mripard@kernel.org; h=from:subject:message-id; bh=1R/cmhynuL7ZkKUF0HfDvx8YnoSqeyk82pR1KuKcrL0=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDBnbVm9/c31t2Dx/6at9gnwPTixN2/RMXiL83dzp0WceK z/VLIni6ZjKwiDMySArpsjyRCbs9PL2xVUO9it/wMxhZQIZwsDFKQATUf3PWJ9T7tX42PfpbKcn iquSluzj8j3qc/hQqo3T0dkZ/qFCDmc0jXWmFT9StJUr+7+YbY70T8aGB04uqnuDJhc7K+cxTPD OPHfK79xnjqPTtl6verjgVnPzPa34Ux1J259PEnXYY7y7Su8KAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We currently have a helper to print the new states associated to a drm_atomic_state, but we don't have a variant to print the old state. It's somewhat expected, since we almost never care about what the new state looks like when we commit a new state, but we're about to change that. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c | 45 +++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_crtc_internal.h | 2 ++ 2 files changed, 47 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 9b198610791d19c7fd276ca59264a961d21caf43..38f2b2633fa992b3543e8c425c7faeab1ce69765 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1875,10 +1875,55 @@ void drm_atomic_print_new_state(const struct drm_atomic_state *state, for_each_new_private_obj_in_state(state, obj, obj_state, i) drm_atomic_private_obj_print_state(p, obj_state); } EXPORT_SYMBOL(drm_atomic_print_new_state); +/** + * drm_atomic_print_old_state - prints drm atomic state + * @state: atomic configuration to check + * @p: drm printer + * + * This functions prints the drm atomic state snapshot using the drm printer + * which is passed to it. This snapshot can be used for debugging purposes. + * + * Note that this function looks into the old state objects and hence its not + * safe to be used after the call to drm_atomic_helper_commit_hw_done(). + */ +void drm_atomic_print_old_state(const struct drm_atomic_state *state, + struct drm_printer *p) +{ + struct drm_plane *plane; + struct drm_plane_state *plane_state; + struct drm_crtc *crtc; + struct drm_crtc_state *crtc_state; + struct drm_connector *connector; + struct drm_connector_state *connector_state; + struct drm_private_obj *obj; + struct drm_private_state *obj_state; + int i; + + if (!p) { + drm_err(state->dev, "invalid drm printer\n"); + return; + } + + drm_dbg_atomic(state->dev, "checking %p\n", state); + + for_each_old_plane_in_state(state, plane, plane_state, i) + drm_atomic_plane_print_state(p, plane_state); + + for_each_old_crtc_in_state(state, crtc, crtc_state, i) + drm_atomic_crtc_print_state(p, crtc_state); + + for_each_old_connector_in_state(state, connector, connector_state, i) + drm_atomic_connector_print_state(p, connector_state); + + for_each_old_private_obj_in_state(state, obj, obj_state, i) + drm_atomic_private_obj_print_state(p, obj_state); +} +EXPORT_SYMBOL(drm_atomic_print_old_state); + static void __drm_state_dump(struct drm_device *dev, struct drm_printer *p, bool take_locks) { struct drm_mode_config *config = &dev->mode_config; struct drm_plane *plane; diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index 89706aa8232fc0b2830af67c7588985a29653299..a8139fda1a1015c2ac8d8af3b12c5ac0b00cfc1a 100644 --- a/drivers/gpu/drm/drm_crtc_internal.h +++ b/drivers/gpu/drm/drm_crtc_internal.h @@ -249,10 +249,12 @@ int __drm_atomic_helper_disable_plane(struct drm_plane *plane, int __drm_atomic_helper_set_config(struct drm_mode_set *set, struct drm_atomic_state *state); void drm_atomic_print_new_state(const struct drm_atomic_state *state, struct drm_printer *p); +void drm_atomic_print_old_state(const struct drm_atomic_state *state, + struct drm_printer *p); /* drm_atomic_uapi.c */ int drm_atomic_connector_commit_dpms(struct drm_atomic_state *state, struct drm_connector *connector, int mode); -- 2.50.1