From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@gmail.com>,
Hyun Kwon <hyun.kwon@xilinx.com>, Simona Vetter <simona@ffwll.ch>,
Michal Simek <michal.simek@amd.com>,
linux-arm-kernel@lists.infradead.org,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH 2/3] drm: zynqmp_dp: Use smp_load/store for status
Date: Fri, 24 Oct 2025 15:17:06 -0400 [thread overview]
Message-ID: <20251024191707.2310589-3-sean.anderson@linux.dev> (raw)
In-Reply-To: <20251024191707.2310589-1-sean.anderson@linux.dev>
dp->status is read asynchronously by the AUX bus. Therefore, all reads
outside of dp->lock must be atomic. Similarly, writes must be atomic as
well. Reads with dp->lock held do not need to be atomic.
Fixes: a7d5eeaa57d7 ("drm: zynqmp_dp: Add locking")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index f39c78b08e6a..caf2e0ce3644 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -1111,7 +1111,7 @@ zynqmp_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
return msg->size;
}
- if (dp->status == connector_status_disconnected) {
+ if (READ_ONCE(dp->status) == connector_status_disconnected) {
dev_dbg(dp->dev, "no connected aux device\n");
if (dp->ignore_aux_errors)
goto fake_response;
@@ -1697,7 +1697,7 @@ static enum drm_connector_status __zynqmp_dp_bridge_detect(struct zynqmp_dp *dp)
}
if (state & ZYNQMP_DP_INTERRUPT_SIGNAL_STATE_HPD) {
- dp->status = connector_status_connected;
+ WRITE_ONCE(dp->status, connector_status_connected);
ret = drm_dp_dpcd_read(&dp->aux, 0x0, dp->dpcd,
sizeof(dp->dpcd));
if (ret < 0) {
@@ -1716,7 +1716,7 @@ static enum drm_connector_status __zynqmp_dp_bridge_detect(struct zynqmp_dp *dp)
}
disconnected:
- dp->status = connector_status_disconnected;
+ WRITE_ONCE(dp->status, connector_status_disconnected);
return connector_status_disconnected;
}
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2025-10-24 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 19:17 [PATCH 0/3] drm: zynqmp_dp: Retrain link after HPD if necessary Sean Anderson
2025-10-24 19:17 ` [PATCH 1/3] drm: zynqmp_dp: Update connector state before AUX transfers Sean Anderson
2025-10-24 19:17 ` Sean Anderson [this message]
2025-10-24 19:17 ` [PATCH 3/3] drm: zynqmp_dp: Retrain link after HPD if necessary Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024191707.2310589-3-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).