From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6609CD5B866 for ; Mon, 15 Dec 2025 20:42:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB1E610E4B3; Mon, 15 Dec 2025 20:42:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="EPh/oprn"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B8F910E4B3 for ; Mon, 15 Dec 2025 20:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765831321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vIugujDFg05cEDjSFPsNuy7/nXwlnSCGQEq9oeQZt8U=; b=EPh/oprnsVUrz2G+idS1ZC2AM/rwA1+1CYkP4vO+y+Y9/Ks+UhZD8GQD8uiF7UNWRmm+Q8 lYIJDilFvfrR2WTE+Al8Yo+CZTbbsG+JMUiIqor8rbyfp6JC2rk0SbDtLjgj40Qo1Qhd62 7HXSH1GHpkG+G8IPBcGjz75EAvWohL4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-BMaDb4RxNWa7GGNcrT26UQ-1; Mon, 15 Dec 2025 15:41:59 -0500 X-MC-Unique: BMaDb4RxNWa7GGNcrT26UQ-1 X-Mimecast-MFC-AGG-ID: BMaDb4RxNWa7GGNcrT26UQ_1765831318 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47910af0c8bso29564055e9.2 for ; Mon, 15 Dec 2025 12:41:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765831318; x=1766436118; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIugujDFg05cEDjSFPsNuy7/nXwlnSCGQEq9oeQZt8U=; b=m6xfO77iAOeNl8pBaah9ulFevpvs08edr/xrheRXEHl3aKAwozTzFQV3P3ZLPL3yfi +r6gx1m7gtx3BACq//QrcvebhD+2Q42H4wfWjFJFM0kGoQSKwAjfjjX2/d30OchCz1ZY ndkr6SIe/LU4rchxUJ7cqDDvSIYInMP1nZeqV6VyZv6RnfDWG7plIUC0YTzBf7o+wBgK kQk1D942FY7jzEv30O9Gq4iRFvZrZ4YZ3yTncR0k1byMFrB2+fwYxkg588CEj5w29uWw c+BzeCxrBABW1Z2m1Jh5fD7KstF10gG81jMPPujF9UaTgJ/uMR2vzDihFdGITIyCyDm8 4Ctw== X-Forwarded-Encrypted: i=1; AJvYcCWQpBq0Ef2r4gN7B9u4lXwf4/jHklaDaAzDBIAV0+CrM0V/O0awIVw5+xGx6T839D9IXwfnFZMXU9E=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzI3vbZjSfa3TOiW51fEq7SWP8nuyw6i41MVLk4Mhpe4PXeIakH nsD/1/W9OJmFrRuQ8JSrTfE+hQtwxfqvOKcrZJ428yH8aiJJquTxKumXDGXKUZU5B1hupvezZ97 jyF8by2f7OWIZFHPIWDtfzUnVnt8Z7LA8Cq3tSwmIyfFVzPFfduyp5KT4kKuErFL2HtvlPQ== X-Gm-Gg: AY/fxX4Q5n2Z3AJJCTQV4EJiQyCNsjIa4AQgV01zVYSZbOAjj63bm9shOVPcQFqGc+L WoKi8s4JH8recmTtIll/vtNzBLq28MjHCpGecBQlcqZcKHoczi2+fnig0n8gpwbS5W24SNLyTHx WnHwtBdR1VqFP0M4Q24rBUaclTWxLRhtnMlu7HgrKONdEN44e4kHnDTcbFEbqtN4I5VTZH/xbjR 4VVzQZHQAYOytL6IxTn/c2HwCPXhp2V0am0Vo6IlZen4LJNTB+LWryuzNxoSj9eIGqvdFoHfa3+ Qibg2ps/Kn8PqKx+hRKFzzw55NDD8bA/prRedM43JgqAf7Wny72itvZnFx0w3nogoKyIHNEz/Ky f5BgYUx6FbRM5j7Bjbsq9LXNYOrTfUHWf5Q== X-Received: by 2002:a05:600c:6290:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-47a8f8cdfd1mr164694455e9.16.1765831318211; Mon, 15 Dec 2025 12:41:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFpvKxyv9KrTZN+I+gLKkWZxXPblkRG4VaB9KOKEG2SIjVVbTsH1HJ4pcy9Q9bDzIs00zZydQ== X-Received: by 2002:a05:600c:6290:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-47a8f8cdfd1mr164694005e9.16.1765831317597; Mon, 15 Dec 2025 12:41:57 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f6f26ebsm211656485e9.14.2025.12.15.12.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 12:41:56 -0800 (PST) Date: Mon, 15 Dec 2025 15:41:49 -0500 From: "Michael S. Tsirkin" To: Bagas Sanjaya Cc: Linux Kernel Mailing List , Linux AMDGPU , Linux DRI Development , Linux Filesystems Development , Linux Media , linaro-mm-sig@lists.linaro.org, kasan-dev@googlegroups.com, Linux Virtualization , Linux Memory Management List , Linux Network Bridge , Linux Networking , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthew Brost , Danilo Krummrich , Philipp Stanner , Alexander Viro , Christian Brauner , Jan Kara , Sumit Semwal , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Uladzislau Rezki , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Taimur Hassan , Wayne Lin , Alex Hung , Aurabindo Pillai , Dillon Varone , George Shen , Aric Cyr , Cruise Hung , Mario Limonciello , Sunil Khatri , Dominik Kaszewski , David Hildenbrand , Peter Zijlstra , Lorenzo Stoakes , Max Kellermann , "Nysal Jan K.A." , Ryan Roberts , Alexey Skidanov , Vlastimil Babka , Kent Overstreet , Vitaly Wool , Harry Yoo , Mateusz Guzik , NeilBrown , Amir Goldstein , Jeff Layton , Ivan Lipski , Tao Zhou , YiPeng Chai , Hawking Zhang , Lyude Paul , Daniel Almeida , Luben Tuikov , Matthew Auld , Roopa Prabhu , Mao Zhu , Shaomin Deng , Charles Han , Jilin Yuan , Swaraj Gaikwad , George Anthony Vernon Subject: Re: [PATCH 06/14] virtio: Describe @map and @vmap members in virtio_device struct Message-ID: <20251215154141-mutt-send-email-mst@kernel.org> References: <20251215113903.46555-1-bagasdotme@gmail.com> <20251215113903.46555-7-bagasdotme@gmail.com> MIME-Version: 1.0 In-Reply-To: <20251215113903.46555-7-bagasdotme@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RFVtW2eSav8d0KqDlLEHbl0HsvtWxx6MnXl6eZE6rvI_1765831318 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 15, 2025 at 06:38:54PM +0700, Bagas Sanjaya wrote: > Sphinx reports kernel-doc warnings: > > WARNING: ./include/linux/virtio.h:181 struct member 'map' not described in 'virtio_device' > WARNING: ./include/linux/virtio.h:181 struct member 'vmap' not described in 'virtio_device' > > Describe these members. > > Fixes: bee8c7c24b7373 ("virtio: introduce map ops in virtio core") > Signed-off-by: Bagas Sanjaya Acked-by: Michael S. Tsirkin > --- > include/linux/virtio.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > index 132a474e59140a..68ead8fda9c921 100644 > --- a/include/linux/virtio.h > +++ b/include/linux/virtio.h > @@ -150,11 +150,13 @@ struct virtio_admin_cmd { > * @id: the device type identification (used to match it with a driver). > * @config: the configuration ops for this device. > * @vringh_config: configuration ops for host vrings. > + * @map: configuration ops for device's mapping buffer > * @vqs: the list of virtqueues for this device. > * @features: the 64 lower features supported by both driver and device. > * @features_array: the full features space supported by both driver and > * device. > * @priv: private pointer for the driver's use. > + * @vmap: device virtual map > * @debugfs_dir: debugfs directory entry. > * @debugfs_filter_features: features to be filtered set by debugfs. > */ > -- > An old man doll... just what I always wanted! - Clara