From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2018DCE9D7D for ; Tue, 6 Jan 2026 16:43:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0402110E4FF; Tue, 6 Jan 2026 16:43:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="QlTkB4ct"; dkim-atps=neutral Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) by gabe.freedesktop.org (Postfix) with ESMTPS id 232CA10E0BD for ; Tue, 6 Jan 2026 16:43:12 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1767717790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NkZs5zdh+IB8LwYC9eN3BRgGph4b858iwLQZ9mtjEw0=; b=QlTkB4ctl3Lk0JPk81oKR5iSzGxZW6KC9kuKtr3fVp0v+CQs0/y5iLS72FMldN2n3pHMdL nn69V2rcdReXOmRpOgbJgGFsHnF05pmgFzmCHd5iGVYjhZfeHFSu6vsIEK5eFEPzi1CBNi scXS28HikHVHZfRIKuC5Jwzfu43KmCE= From: Sean Anderson To: Laurent Pinchart , Tomi Valkeinen , dri-devel@lists.freedesktop.org Cc: Simona Vetter , Thomas Zimmermann , linux-kernel@vger.kernel.org, Maxime Ripard , David Airlie , linux-arm-kernel@lists.infradead.org, Michal Simek , Anatoliy Klymenko , Maarten Lankhorst , Mike Looijmans , Sean Anderson Subject: [PATCH v2 2/4] drm: zynqmp: Check property creation status Date: Tue, 6 Jan 2026 11:42:45 -0500 Message-Id: <20260106164247.472544-3-sean.anderson@linux.dev> In-Reply-To: <20260106164247.472544-1-sean.anderson@linux.dev> References: <20260106164247.472544-1-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Make sure to return an error in the event that we can't create our properties. Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support") Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to userspace") Signed-off-by: Sean Anderson Reviewed-by: Anatoliy Klymenko Reviewed-by: Thomas Zimmermann --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index 02f3a7d78cf8..816bea4ea986 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -175,9 +175,15 @@ static int zynqmp_dpsub_create_planes(struct zynqmp_dpsub *dpsub) drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs); - drm_plane_create_zpos_immutable_property(plane, i); - if (i == ZYNQMP_DPSUB_LAYER_GFX) - drm_plane_create_alpha_property(plane); + ret = drm_plane_create_zpos_immutable_property(plane, i); + if (ret) + return ret; + + if (i == ZYNQMP_DPSUB_LAYER_GFX) { + ret = drm_plane_create_alpha_property(plane); + if (ret) + return ret; + } } return 0; -- 2.35.1.1320.gc452695387.dirty