From: dongwon.kim@intel.com
To: dri-devel@lists.freedesktop.org, airlied@redhat.com,
kraxel@redhat.com, dmitry.osipenko@collabora.com
Cc: nirmoyd@nvidia.com, vivek.kasireddy@intel.com
Subject: [PATCH v7 0/3] Virtio-GPU S4 support
Date: Wed, 7 Jan 2026 10:27:42 -0800 [thread overview]
Message-ID: <20260107182745.229481-1-dongwon.kim@intel.com> (raw)
From: Dongwon Kim <dongwon.kim@intel.com>
This patch series implements functions for .freeze and .restore hooks for
virtio-gpu driver as well as pm-notifier to handle object restoration in
S4(hiberation) case.
First patch adds `virtgpu_freeze` and `virtgpu_restore` functions.
These functions handle the deletion of virtio queues before suspension and
their recreation during the restoration process.
Second patch implements a mechanism for restoring `virtio_gpu_object` instances.
This is necessary because the host (QEMU) deletes all associated resources during
the virtio-gpu reset, which occurs as part of hiberation/resume process.
Third patch adds pm-notifier to the driver that handles resubmission of virtio-gpu
objects to the QEMU once the guest resumes from hibenation.
These changes ensure that the virtio-gpu driver can properly handle hibernation
scenarios without resource loss.
v2: 10ms sleep is added in virtgpu_freeze to avoid the situation
the driver is locked up during resumption.
v3: Plain 10ms delay (v2) is replaced with wait calls which wait until
the virtio queue is empty.
(Dmitry Osipenko)
v4: New version of patchset only covers S4 case because loss of resources in S3
case can be avoided by skipping virtio-gpu-reset in QEMU (hw/display/virtio-gpu.c).
To skip virtio-gpu-reset (soft-reset), virtio-gpu-pci device should be attached to
PCIE bus AND a PCIE option, 'x-pcie-pm-no-soft-reset' should added and set to 'true'.
(e.g. -device virtio-gpu-pci,bus=port,x-pcie-pm-no-soft-reset=true)
v5: Remove virtio_gpu_object from the restore list before freeing the object
to prevent an use-after-free situation.
(Nirmoy Das)
Protect restore list operations with a spinlock
(Nirmoy Das)
Move restore list node into virtio_gpu_bo struct to reduce memory usage
(Dmitry Osipenko)
Remove unused header - drm_atomic_helper.h
(Dmitry Osipenko)
v6: Include object backed by imported dmabuf
(Dmitry Osipenko)
Not storing virgl objects in the restore_list as virgl 3D objects are not
recoverable.
(Dmitry Osipenko)
Change the name 'list',a node in restore_list to 'restore_node'
(Nirmoy Das)
Use mutex instead of spinlock when updating restore_list
(Nirmoy Das)
Initialize restore_node when virtio_gpu_object is created - this is to
check if the node is in the list with 'list_empty' before removing it.
Restoring objects in the PM notifier is too late, as virtio-gpu
message communication begins in virtgpu_restore once virtqueues
are re-established. To address this, a 'hibernation' flag is set
during the PM_HIBERNATION_PREPARE phase in the notifier. This flag
is then used in virtgpu_restore to detect if the system is resuming
from S4, allowing objects to be recovered immediately after virtqueues
are reconfigured.
v7: Add a helper, virtio_gpu_add_object_to_restore_list
(Dmitry Osipenko)
Unreference all objects before hibernation so they can be removed
on the host side, since they will be fully restored anyway. This
prevents the situation where host-side hibernation fails (leaving
all associated resources still alive) while the virtio-gpu driver
still attempts to restore those objects.
(Dmitry Osipenko)
Dongwon Kim (3):
drm/virtio: Freeze and restore hooks to support suspend and resume
drm/virtio: Add support for saving and restoring virtio_gpu_objects
drm/virtio: Add PM notifier to restore objects after hibernation
drivers/gpu/drm/virtio/virtgpu_drv.c | 74 +++++++++++++++++++++-
drivers/gpu/drm/virtio/virtgpu_drv.h | 23 ++++++-
drivers/gpu/drm/virtio/virtgpu_kms.c | 54 ++++++++++++++--
drivers/gpu/drm/virtio/virtgpu_object.c | 83 ++++++++++++++++++++++++-
drivers/gpu/drm/virtio/virtgpu_prime.c | 43 ++++++++++++-
drivers/gpu/drm/virtio/virtgpu_vq.c | 13 +++-
drivers/gpu/drm/virtio/virtgpu_vram.c | 4 +-
7 files changed, 280 insertions(+), 14 deletions(-)
--
2.34.1
next reply other threads:[~2026-01-07 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 18:27 dongwon.kim [this message]
2026-01-07 18:27 ` [PATCH v7 1/3] drm/virtio: Freeze and restore hooks to support suspend and resume dongwon.kim
2026-02-25 16:06 ` Dmitry Osipenko
2026-01-07 18:27 ` [PATCH v7 2/3] drm/virtio: Add support for saving and restoring virtio_gpu_objects dongwon.kim
2026-01-09 16:40 ` kernel test robot
2026-01-12 4:03 ` kernel test robot
2026-01-12 8:16 ` kernel test robot
2026-02-25 16:07 ` Dmitry Osipenko
2026-01-07 18:27 ` [PATCH v7 3/3] drm/virtio: Add PM notifier to restore objects after hibernation dongwon.kim
2026-02-25 16:06 ` Dmitry Osipenko
2026-02-25 16:06 ` Dmitry Osipenko
2026-02-25 16:05 ` [PATCH v7 0/3] Virtio-GPU S4 support Dmitry Osipenko
2026-02-25 17:06 ` Kim, Dongwon
2026-04-30 22:39 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107182745.229481-1-dongwon.kim@intel.com \
--to=dongwon.kim@intel.com \
--cc=airlied@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=nirmoyd@nvidia.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox