From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B16DD46C0F for ; Wed, 28 Jan 2026 23:21:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AD3F10E23F; Wed, 28 Jan 2026 23:21:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="HoqwOzwN"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33E2210E23F for ; Wed, 28 Jan 2026 23:21:29 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D7D7C43C95; Wed, 28 Jan 2026 23:21:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6464CC4CEF1; Wed, 28 Jan 2026 23:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769642488; bh=Gr4t3B1tqgCoEK96h0WSs3SbBJgDd9kUcab5OUuwJSk=; h=From:To:Cc:Subject:Date:From; b=HoqwOzwNUew+Rn/PHZBdSGkXdaqb3YgmIlp8joF3Ml9qQuH449w4GikGSkv/PGFt+ ZUNRYuEscIgjVbaeoSTYVDBUiiOfcrkVg6x23YU161gh0IRJ71Vrp+Ycjd/qE5X2Ji +TnMWBLERTlID3hiYYeF1+QAYNmDTmdM5ldzQ5H1ls9RgTMy/2uECxFrLa/uCTN+FY ka59RuiQmg+eoPrHNPzFZP0Yzv2UiLumBILfCelEZnTXouFPDrSIQtWmDZoAZeDsWG w5hZ1vdmbYMx2zXxmpv0vB6sfbNO7FSO8dsComeQBK0/+OE8+2yWSuy01yXaxM9v09 66q9eJ8awV87A== From: Danilo Krummrich To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, louis.chauvet@bootlin.com, hamohammed.sa@gmail.com, melissa.srw@gmail.com, lyude@redhat.com, gregkh@linuxfoundation.org, rafael@kernel.org Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Danilo Krummrich Subject: [PATCH 1/2] drm: vgem: do not use devres groups Date: Thu, 29 Jan 2026 00:20:33 +0100 Message-ID: <20260128232038.2399-1-dakr@kernel.org> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Using devres groups in vgem is unnecessary, as the corresponding cleanup happens automatically when the device is unbound through faux_device_destroy(). Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/vgem/vgem_drv.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 260c64733972..d75f2ee56cf6 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -133,11 +133,6 @@ static int __init vgem_init(void) if (!fdev) return -ENODEV; - if (!devres_open_group(&fdev->dev, NULL, GFP_KERNEL)) { - ret = -ENOMEM; - goto out_unregister; - } - dma_coerce_mask_and_coherent(&fdev->dev, DMA_BIT_MASK(64)); @@ -145,20 +140,18 @@ static int __init vgem_init(void) struct vgem_device, drm); if (IS_ERR(vgem_device)) { ret = PTR_ERR(vgem_device); - goto out_devres; + goto out; } vgem_device->faux_dev = fdev; /* Final step: expose the device/driver to userspace */ ret = drm_dev_register(&vgem_device->drm, 0); if (ret) - goto out_devres; + goto out; return 0; -out_devres: - devres_release_group(&fdev->dev, NULL); -out_unregister: +out: faux_device_destroy(fdev); return ret; } @@ -168,7 +161,6 @@ static void __exit vgem_exit(void) struct faux_device *fdev = vgem_device->faux_dev; drm_dev_unregister(&vgem_device->drm); - devres_release_group(&fdev->dev, NULL); faux_device_destroy(fdev); } base-commit: a50007089e078a1b7a826559a02277b1601ee189 -- 2.52.0