From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CADCE83054 for ; Tue, 3 Feb 2026 05:24:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9041410E51F; Tue, 3 Feb 2026 05:24:43 +0000 (UTC) Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 190D610E51F for ; Tue, 3 Feb 2026 05:24:41 +0000 (UTC) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-62K1K7aYM6OsturRujr02A-1; Tue, 03 Feb 2026 00:24:39 -0500 X-MC-Unique: 62K1K7aYM6OsturRujr02A-1 X-Mimecast-MFC-AGG-ID: 62K1K7aYM6OsturRujr02A_1770096278 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A75F19560A3; Tue, 3 Feb 2026 05:24:38 +0000 (UTC) Received: from dreadlord.redhat.com (unknown [10.67.32.75]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC3EC1800665; Tue, 3 Feb 2026 05:24:35 +0000 (UTC) From: Dave Airlie To: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Subject: nouveau : fix r570 suspend/resume regression Date: Tue, 3 Feb 2026 15:21:10 +1000 Message-ID: <20260203052431.2219998-1-airlied@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 79aVnPk_mqrarZDNrC6JkNVE1bpv7L_tmGYHdJoQD_U_1770096278 X-Mimecast-Originator: gmail.com Content-Transfer-Encoding: quoted-printable content-type: text/plain; charset=WINDOWS-1252; x-default=true X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since R570 firmware got enabled, a number of GPUs have not being successfully suspend/resuming. Lyude showed it on RTX6000, which I reproduced and wasted a lot of time down various rabbit holes. There are two required fixes, the first one adds proper sequence numbers to the rpc messages, which fixes a bunch of NOCAT asserts. Then we have to pass the runtime vs non-runtime state down to the GSP fbsr code. This however requires replacing a bool with an enum which refactors quite a bunch of interfaces unfortunately, but it was the cleanest way to do it. The final patch hooks up the interface so normal suspend doesn't set the GCOFF flags. Dave.