From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B24EEF070F for ; Mon, 9 Feb 2026 07:02:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E8CE10E1F9; Mon, 9 Feb 2026 07:02:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OS8W6XHY"; dkim-atps=neutral Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87F7110E1F9 for ; Mon, 9 Feb 2026 07:02:26 +0000 (UTC) Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-2b86d3c909dso919641eec.1 for ; Sun, 08 Feb 2026 23:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770620546; x=1771225346; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QTQsukcOvGgA1IOwGu0V6U/4Hj9O7nggXaNLrVfcPCU=; b=OS8W6XHYEAzU5eQxj1lRdC3YW10uHDlfwwjFadqF4MT168/OXzWTKpsex/TmXDDp1C FUjlheJLLQz7mFX4cRrdNT0VQ/1PaRKuvmuWySsg5e39+vy43ALawrCiRvLAlZF151En pTonNgY1Xn40j7TCOtQiHfg4IFGRcDDvmSYqrnzRuF1BI1GJYD4V+0Obr75SDEuLkYZo VcW8MKG9sISXfz+++COiVNVQkf/Gy35Yb2kOXaJQQP5nvN7WH0/bEqIyQ7v0paHWamCU kOKJB4xfA9WcGSJAl2J8Y8TTTpd9QafqrzcrDP7Sfk7XmifdCWRgfCD227VCahI44bQo 1mBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770620546; x=1771225346; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QTQsukcOvGgA1IOwGu0V6U/4Hj9O7nggXaNLrVfcPCU=; b=sW8j1mVlPXrDE7GO4DRc9o3w/KAg6jQkKCxC2xDP/tpZHRYM4zYitva55jyxYgWY6c fHm8z9e8Fz1UHXNy/fCZl/urRVlgncAvti+g/q4ZpTTAc4bD/7bIbX/RbbbMGt75znn1 KBAdJ43FtHKqTjWg96IqoriAsKRLeM8mQywqkhx3cBuiUNVeKxsR9xRUAEbYtaHeHR1t PGDnL8ItcGfVWlYrYNBX5tOLvFXiNp34wPEQOhStP6uHXbCD5JO5ZoAoaIR/0BfYr8dc N6xs69SJk2W0ud5pQR/THaFj3TVmQRoNUeTtOrBlW/w8/oUbrX6F4hZnw5cAMHls+l49 qseA== X-Gm-Message-State: AOJu0Yw1eEV3SMmo3lPHCZVvFT8N+wEDZiBYBzoiMTNoICMgkfvEYBpd 7NoxMZZARix5WYue5V8QMammElyknWz6Z14kLiTDMOMFQpxQjYf3G/W0 X-Gm-Gg: AZuq6aKQhettx5SN99k8INacpak9L3XlBGi+/mIKKbHiSIF6oKF26ac8QhV1wvgmWN5 G1/qvP9my2AEN6AHfVb8luhfbkI0gzHRK6Zk9Yi5vum+atWedGo2KTa6UwMZoAKFAYTqlG8HlKv rI/OmZm1PsFG4JwEpqSRv753chPiC7tTl99o+JS0LQiiZbLBTiXrG5yMx+0BnwdvYsLM5c+7NcG DCLfiUTx9UP6ZIHpT2q+tYTKXPNLfmDzoN62QuDwcDyM4m9JShwHsTte4ODrvzqfge9mAYfNwjQ CQN/NGxHo0CBTw86NJjY0cJDSMfqB4D57yQl17ieBJ30RXX8sC64byMVl4f0Es/0ENRXJ9pJxAq GsSMZY8t0O21Xa8Ytsn4/EyojRAHKhx481GI0yty8VgXla7PaCwBqpFNsGOGBGUlXJPRqAQ0Stn S0SrYfrh89WO4HPZRYOKW1wPj+VWAzvg== X-Received: by 2002:a05:7301:38a6:b0:2b8:31e5:918 with SMTP id 5a478bee46e88-2b856a4c311mr3244690eec.37.1770620545505; Sun, 08 Feb 2026 23:02:25 -0800 (PST) Received: from mhkubun.search.charter.net ([66.91.163.55]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12706faa047sm6966305c88.14.2026.02.08.23.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 23:02:25 -0800 (PST) From: mhkelley58@gmail.com X-Google-Original-From: mhklinux@outlook.com To: drawat.floss@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ryasuoka@redhat.com, jfalempe@redhat.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/2] Drivers: hv: vmbus: Provide option to skip VMBus unload on panic Date: Sun, 8 Feb 2026 23:02:00 -0800 Message-Id: <20260209070201.1492-1-mhklinux@outlook.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: mhklinux@outlook.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Michael Kelley Currently, VMBus code initiates a VMBus unload in the panic path so that if a kdump kernel is loaded, it can start fresh in setting up its own VMBus connection. However, a driver for the VMBus virtual frame buffer may need to flush dirty portions of the frame buffer back to the Hyper-V host so that panic information is visible in the graphics console. To support such flushing, provide exported functions for the frame buffer driver to specify that the VMBus unload should not be done by the VMBus driver, and to initiate the VMBus unload itself. Together these allow a frame buffer driver to delay the VMBus unload until after it has completed the flush. Ideally, the VMBus driver could use its own panic-path callback to do the unload after all frame buffer drivers have finished. But DRM frame buffer drivers use the kmsg dump callback, and there are no callbacks after that in the panic path. Hence this somewhat messy approach to properly sequencing the frame buffer flush and the VMBus unload. Fixes: 3671f3777758 ("drm/hyperv: Add support for drm_panic") Signed-off-by: Michael Kelley --- drivers/hv/channel_mgmt.c | 1 + drivers/hv/hyperv_vmbus.h | 1 - drivers/hv/vmbus_drv.c | 25 ++++++++++++++++++------- include/linux/hyperv.h | 3 +++ 4 files changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 74fed2c073d4..5de83676dbad 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -944,6 +944,7 @@ void vmbus_initiate_unload(bool crash) else vmbus_wait_for_unload(); } +EXPORT_SYMBOL_GPL(vmbus_initiate_unload); static void vmbus_setup_channel_state(struct vmbus_channel *channel, struct vmbus_channel_offer_channel *offer) diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h index cdbc5f5c3215..5d3944fc93ae 100644 --- a/drivers/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -440,7 +440,6 @@ void hv_vss_deinit(void); int hv_vss_pre_suspend(void); int hv_vss_pre_resume(void); void hv_vss_onchannelcallback(void *context); -void vmbus_initiate_unload(bool crash); static inline void hv_poll_channel(struct vmbus_channel *channel, void (*cb)(void *)) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 6785ad63a9cb..97dfa529d250 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -69,19 +69,29 @@ bool vmbus_is_confidential(void) } EXPORT_SYMBOL_GPL(vmbus_is_confidential); +static bool skip_vmbus_unload; + +/* + * Allow a VMBus framebuffer driver to specify that in the case of a panic, + * it will do the VMbus unload operation once it has flushed any dirty + * portions of the framebuffer to the Hyper-V host. + */ +void vmbus_set_skip_unload(bool skip) +{ + skip_vmbus_unload = skip; +} +EXPORT_SYMBOL_GPL(vmbus_set_skip_unload); + /* * The panic notifier below is responsible solely for unloading the * vmbus connection, which is necessary in a panic event. - * - * Notice an intrincate relation of this notifier with Hyper-V - * framebuffer panic notifier exists - we need vmbus connection alive - * there in order to succeed, so we need to order both with each other - * [see hvfb_on_panic()] - this is done using notifiers' priorities. */ static int hv_panic_vmbus_unload(struct notifier_block *nb, unsigned long val, void *args) { - vmbus_initiate_unload(true); + if (!skip_vmbus_unload) + vmbus_initiate_unload(true); + return NOTIFY_DONE; } static struct notifier_block hyperv_panic_vmbus_unload_block = { @@ -2848,7 +2858,8 @@ static void hv_crash_handler(struct pt_regs *regs) { int cpu; - vmbus_initiate_unload(true); + if (!skip_vmbus_unload) + vmbus_initiate_unload(true); /* * In crash handler we can't schedule synic cleanup for all CPUs, * doing the cleanup for current CPU only. This should be sufficient diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index dfc516c1c719..b0502a336eb3 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.h @@ -1334,6 +1334,9 @@ int vmbus_allocate_mmio(struct resource **new, struct hv_device *device_obj, bool fb_overlap_ok); void vmbus_free_mmio(resource_size_t start, resource_size_t size); +void vmbus_initiate_unload(bool crash); +void vmbus_set_skip_unload(bool skip); + /* * GUID definitions of various offer types - services offered to the guest. */ -- 2.25.1