From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD22BEA8128 for ; Tue, 10 Feb 2026 14:57:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09ECC10E1D0; Tue, 10 Feb 2026 14:57:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="kcJXaioD"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F9EC10E1D0 for ; Tue, 10 Feb 2026 14:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770735475; bh=8fqNgMt4GEKsfnrjQVVwOS/ylSwIghuovg1fPQrBZHY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kcJXaioDfCmRrGoBA4yLRF1rGkr7VcLOPZqqAKn5DOlnLn8nAgCGUp5zNqi2W8mqN G3RF4gHiQVfbWuWB7710GMHrYbzpmwHpCKn7eXLDJnKcfHlWfEarilutNP1cTuxRzJ lXK4E7cPAN8Vuux76JDQIZUNbGi0N+AkFToQQgVqVME52GQ37Y2x+nTzMqnnwdsC21 dq+9grSd4rDLYT6IyP1oooguVRB4y3sq+OccYfbv7tiWe5HA/4qiymg2UWnniZoYSi 984QIemsUm7QMwrau2zgVRrytOdSzvJuLbTYBgGB7BX9jiCTHADYdkHurJUAMeI6Nr SpL7UYQYZEn3g== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 083D417E1305; Tue, 10 Feb 2026 15:57:54 +0100 (CET) Date: Tue, 10 Feb 2026 15:57:50 +0100 From: Boris Brezillon To: Philipp Stanner Cc: David Airlie , Simona Vetter , Danilo Krummrich , Alice Ryhl , Gary Guo , Benno Lossin , Christian =?UTF-8?B?S8O2bmln?= , Daniel Almeida , Joel Fernandes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org Subject: Re: [RFC PATCH 3/4] rust/drm: Add DRM Jobqueue Message-ID: <20260210155750.5cdbe6cc@fedora> In-Reply-To: <20260203081403.68733-5-phasta@kernel.org> References: <20260203081403.68733-2-phasta@kernel.org> <20260203081403.68733-5-phasta@kernel.org> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 3 Feb 2026 09:14:02 +0100 Philipp Stanner wrote: > +/// A jobqueue Job. > +/// > +/// You can stuff your data in it. The job will be borrowed back to your driver > +/// once the time has come to run it. > +/// > +/// Jobs are consumed by [`Jobqueue::submit_job`] by value (ownership transfer). > +/// You can set multiple [`DmaFence`] as dependencies for a job. It will only > +/// get run once all dependency fences have been signaled. > +/// > +/// Jobs cost credits. Jobs will only be run if there are is enough capacity in > +/// the jobqueue for the job's credits. It is legal to specify jobs costing 0 > +/// credits, effectively disabling that mechanism. > +#[pin_data] > +pub struct Job { > + cost: u32, > + #[pin] > + pub data: T, > + done_fence: Option>>, > + hardware_fence: Option>>, > + nr_of_deps: AtomicU32, > + dependencies: List, Given how tricky Lists are in rust, I'd recommend going for an XArray, like we have on the C side. There's a bit of overhead when the job only has a few deps, but I think simplicity beats memory-usage-optimizations in that case (especially since the overhead exists and is accepted in C). > +} > +