From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60329ECD6F9 for ; Thu, 12 Feb 2026 00:14:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B652010E678; Thu, 12 Feb 2026 00:14:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GyVQC/L7"; dkim-atps=neutral Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id C668610E680 for ; Thu, 12 Feb 2026 00:14:24 +0000 (UTC) Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-45eabce608dso1693836b6e.2 for ; Wed, 11 Feb 2026 16:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770855264; x=1771460064; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SIJdokQ3Nls8jtxlVsBJj78xvmKdzMFXYs5sBSKxrlk=; b=GyVQC/L7OLIecge0xNzjqseNBVH5OZPHXdaAstjLg+ObMHNyCmc2fzd1QXCB8jed1h +cditFZ5sY7PoVjU0/sO1bUBuLcKOlyXSKRXTujsXcPQE1RptFXBWrnCA2cy3Qba0pH5 fkXeCSewqet57Iwf8YFd+uW2Zm4E5DeP2Lk9Ex0DYQn6fRxD1K5TsJV7i5eoIDunj7O8 gv8YghWj/IR4+VySEnwQo3NIR02Fqjwb0ucB9ac7LzxzzroYSgWrfMxjyzU1HPEOsO/w +9/r/ugHlaOXULN7HPMN37U64x/NBC48x3/BrDVzez/wwNLBZ7/W9SSpCjxOPKPfuSgS 8qRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770855264; x=1771460064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SIJdokQ3Nls8jtxlVsBJj78xvmKdzMFXYs5sBSKxrlk=; b=shFYKfxItBkUd4J8gUXOrE82WS8iS1QGjnhQ2LK0PQoSsRuL8dbdR5jr3N7xH+w9Cv NhLOJAbKXd9sDcru841EqAyR6TrnoSZ+NrpIfULBET2r+xHZZ21FCeyyyCneouv+7i8S R7kltwN0kojwaKGCupjlomm5kiSAAseqPpecqd/lbFS//C28bpegj0apRRdyNjIUQadM uCIkuS6R0blo617lbtLCkYFYO68wthUp448c+5koYQEGNCj0z5+XMEbg8SfsVcO2gHxc 29P/dO+pum819EOKhmSIRJB2Llz45jthzLXrLXY3b+9RUpfz4rL3nNrWeZ4Yz+22O7HT 6j6g== X-Gm-Message-State: AOJu0YwwpDitF4wGkfZSD4+5ieEbglq6Q6b5JOwCnKeFoBsT3Z44mVat nZ+dB/FYQdbtZ9XXu7/GHggD8DOmAMxknVCYXCDrymRxw6GqvYxdARBcUcW8Qw== X-Gm-Gg: AZuq6aKkEHys6moFnV32TLcjH+mCiYMiRYYketRYwhyn6pjIN02qUZ9YYNtn8Ty8XHt 3BGh0/pFT75oGbNg0UABC6IUuN4Qygva9OPRl4QeKmI07m3tvrJTSo7A633mi6WmVEMGH7kuNvL RPKOScw7xYw0cFVm343Lr5/cNWfZus2fVzfqCFdcS7VHhCFQUVjldVRC5sooTIAnKx2XzbRx+Qq fmGcKTplyA6d0UNsAHXANbRGjitZq1knM0iTqIIoM3tBcXIzTaX7vv2zuqonI1LryMtjigHwdoe inDCrzpXjRup63R6SdDB4OG9kg9feE/sDwj/ktmgVMspBw9Alzxf5o41zub9ltkENI4XXD9+78K T1ozL/S5g4ah0aWiRunjNK2oLmOOoVBZkQ6Nf1iogf0r35WzHz9RnxuFJ8iILMNt7wZucnla63a TkQIqXvi9Q+Ewko2/zd4BeVfb+t+vx6GvSqx4Q1MHxEl7Cx8aNGGHD X-Received: by 2002:a05:6820:f00b:b0:663:4d6:1cc0 with SMTP id 006d021491bc7-675db33dd7emr174619eaf.24.1770855263755; Wed, 11 Feb 2026 16:14:23 -0800 (PST) Received: from godzilla (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-40eaf1062ffsm2331939fac.13.2026.02.11.16.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 16:14:23 -0800 (PST) From: Jim Cromie To: dri-devel@lists.freedesktop.org, intel-gfx-trybot@lists.freedesktop.org Cc: Jim Cromie , Louis Chauvet Subject: [PATCH 11/61] dyndbg: reduce verbose/debug clutter Date: Wed, 11 Feb 2026 17:13:06 -0700 Message-ID: <20260212001359.97296-12-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260212001359.97296-11-jim.cromie@gmail.com> References: <20260212001359.97296-1-jim.cromie@gmail.com> <20260212001359.97296-2-jim.cromie@gmail.com> <20260212001359.97296-3-jim.cromie@gmail.com> <20260212001359.97296-4-jim.cromie@gmail.com> <20260212001359.97296-5-jim.cromie@gmail.com> <20260212001359.97296-6-jim.cromie@gmail.com> <20260212001359.97296-7-jim.cromie@gmail.com> <20260212001359.97296-8-jim.cromie@gmail.com> <20260212001359.97296-9-jim.cromie@gmail.com> <20260212001359.97296-10-jim.cromie@gmail.com> <20260212001359.97296-11-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' flags=0x1 *flagsp=0x1 *maskp=0xffffffff dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index fbe18b1f0b73..b5a3184288b0 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -276,9 +276,6 @@ static int ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } @@ -511,7 +508,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -525,7 +521,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x\n", modifiers->flags); /* calculate final flags, mask based upon op */ switch (op) { @@ -541,7 +536,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask); return 0; } @@ -551,7 +546,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) struct flag_settings modifiers = {}; struct ddebug_query query = {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; nwords = ddebug_tokenize(query_string, words, MAXWORDS); @@ -569,10 +564,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound = ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } /* handle multiple queries in query string, continue on error, return @@ -1246,11 +1238,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); dt = kzalloc(sizeof(*dt), GFP_KERNEL); if (dt == NULL) { -- 2.53.0