From: Jim Cromie <jim.cromie@gmail.com>
To: dri-devel@lists.freedesktop.org, intel-gfx-trybot@lists.freedesktop.org
Cc: Jim Cromie <jim.cromie@gmail.com>,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH 06/61] test-dyndbg: fixup CLASSMAP usage error
Date: Wed, 11 Feb 2026 17:13:01 -0700 [thread overview]
Message-ID: <20260212001359.97296-7-jim.cromie@gmail.com> (raw)
In-Reply-To: <20260212001359.97296-6-jim.cromie@gmail.com>
commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes")
A closer look at test_dynamic_debug.ko logging output reveals a macro
usage error:
lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID
lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI
lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =_ "HI msg\n" class unknown, _id:13
107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew.
DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value,
in this case it was _base + 1. This leaves HI class un-selectable.
NB: the macro could better validate its arguments.
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Tested-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/test_dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 77c2a669b6af..396144cf351b 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p);
DD_SYS_WRAP(disjoint_bits, T);
/* symbolic input, independent bits */
-enum cat_disjoint_names { LOW = 11, MID, HI };
+enum cat_disjoint_names { LOW = 10, MID, HI };
DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, 10,
"LOW", "MID", "HI");
DD_SYS_WRAP(disjoint_names, p);
--
2.53.0
next prev parent reply other threads:[~2026-02-12 0:14 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 0:12 [PATCH v10 00/61] drm/dyndbg: Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y MIME-Version: 1.0 Jim Cromie
2026-02-12 0:12 ` [PATCH 01/61] dyndbg: fix NULL ptr on i386 due to section alignment Jim Cromie
2026-02-12 0:12 ` [PATCH 02/61] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-02-12 0:12 ` [PATCH 03/61] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-02-12 0:12 ` [PATCH 04/61] docs/dyndbg: update examples \012 to \n Jim Cromie
2026-02-12 0:13 ` [PATCH 05/61] docs/dyndbg: explain flags parse 1st Jim Cromie
2026-02-12 0:13 ` Jim Cromie [this message]
2026-02-12 0:13 ` [PATCH 07/61] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2026-02-12 0:13 ` [PATCH 08/61] dyndbg: make ddebug_class_param union members same size Jim Cromie
2026-02-12 0:13 ` [PATCH 09/61] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2026-02-12 0:13 ` [PATCH 10/61] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2026-02-12 0:13 ` [PATCH 11/61] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-02-12 0:13 ` [PATCH 12/61] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-02-12 0:13 ` [PATCH 13/61] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-02-12 0:13 ` [PATCH 14/61] dyndbg: replace classmap list with a vector Jim Cromie
2026-02-12 0:13 ` [PATCH 15/61] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-02-12 0:13 ` [PATCH 16/61] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-02-12 0:13 ` [PATCH 17/61] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2026-02-12 0:13 ` [PATCH 18/61] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-02-12 0:13 ` [PATCH 19/61] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-02-12 0:13 ` [PATCH 20/61] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-02-12 0:13 ` [PATCH 21/61] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2026-02-12 0:13 ` [PATCH 22/61] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-02-12 0:13 ` [PATCH 23/61] dyndbg: detect class_id reservation conflicts Jim Cromie
2026-02-12 0:13 ` [PATCH 24/61] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time Jim Cromie
2026-02-12 0:13 ` [PATCH 25/61] dyndbg-test: change do_prints testpoint to accept a loopct Jim Cromie
2026-02-12 0:13 ` [PATCH 26/61] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie
2026-02-12 0:13 ` [PATCH 27/61] dyndbg: treat comma as a token separator Jim Cromie
2026-02-12 0:13 ` [PATCH 28/61] dyndbg: split multi-query strings with % Jim Cromie
2026-02-12 0:13 ` [PATCH 29/61] selftests-dyndbg: add test_mod_submod Jim Cromie
2026-02-12 0:13 ` [PATCH 30/61] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie
2026-02-12 0:13 ` [PATCH 31/61] dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(dd_class_name, offset) Jim Cromie
2026-02-12 0:13 ` [PATCH 32/61] docs/dyndbg: add classmap info to howto Jim Cromie
2026-02-12 0:13 ` [PATCH 33/61] drm: use correct ccflags-y spelling Jim Cromie
2026-02-12 0:13 ` [PATCH 34/61] drm-dyndbg: adapt drm core to use dyndbg classmaps-v2 Jim Cromie
2026-02-12 0:13 ` [PATCH 35/61] drm-dyndbg: adapt DRM to invoke DYNAMIC_DEBUG_CLASSMAP_PARAM Jim Cromie
2026-02-12 0:13 ` [PATCH 36/61] drm-print: modernize an archaic comment Jim Cromie
2026-02-12 0:13 ` [PATCH 37/61] drm-print: fix config-dependent unused variable Jim Cromie
2026-02-12 0:13 ` [PATCH 38/61] drm-dyndbg: DRM_CLASSMAP_USE in amdgpu driver Jim Cromie
2026-02-12 0:13 ` [PATCH 39/61] drm-dyndbg: DRM_CLASSMAP_USE in i915 driver Jim Cromie
2026-02-12 0:13 ` [PATCH 40/61] drm-dyndbg: DRM_CLASSMAP_USE in drm_crtc_helper Jim Cromie
2026-02-12 0:13 ` [PATCH 41/61] drm-dyndbg: DRM_CLASSMAP_USE in drm_dp_helper Jim Cromie
2026-02-12 0:13 ` [PATCH 42/61] drm-dyndbg: DRM_CLASSMAP_USE in nouveau Jim Cromie
2026-02-12 0:13 ` [PATCH 43/61] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver Jim Cromie
2026-02-12 0:13 ` [PATCH 44/61] drm-dyndbg: add DRM_CLASSMAP_USE to virtio_gpu Jim Cromie
2026-02-12 0:13 ` [PATCH 45/61] drm-dyndbg: add DRM_CLASSMAP_USE to simpledrm Jim Cromie
2026-02-12 0:13 ` [PATCH 46/61] drm-dyndbg: add DRM_CLASSMAP_USE to bochs Jim Cromie
2026-02-12 0:13 ` [PATCH 47/61] drm-dyndbg: add DRM_CLASSMAP_USE to etnaviv Jim Cromie
2026-02-12 0:13 ` [PATCH 48/61] drm-dyndbg: add DRM_CLASSMAP_USE to gma500 driver Jim Cromie
2026-02-12 0:13 ` [PATCH 49/61] drm-dyndbg: add DRM_CLASSMAP_USE to radeon Jim Cromie
2026-02-12 0:13 ` [PATCH 50/61] drm-dyndbg: add DRM_CLASSMAP_USE to vmwgfx driver Jim Cromie
2026-02-12 0:13 ` [PATCH 51/61] drm-dyndbg: add DRM_CLASSMAP_USE to vkms driver Jim Cromie
2026-02-12 0:13 ` [PATCH 52/61] drm-dyndbg: add DRM_CLASSMAP_USE to udl driver Jim Cromie
2026-02-12 0:13 ` [PATCH 53/61] drm-dyndbg: add DRM_CLASSMAP_USE to mgag200 driver Jim Cromie
2026-02-12 0:13 ` [PATCH 54/61] drm-dyndbg: add DRM_CLASSMAP_USE to the gud driver Jim Cromie
2026-02-12 0:13 ` [PATCH 55/61] drm-dyndbg: add DRM_CLASSMAP_USE to the qxl driver Jim Cromie
2026-02-12 0:13 ` [PATCH 56/61] drm-dyndbg: add DRM_CLASSMAP_USE to the drm_gem_shmem_helper driver Jim Cromie
2026-02-12 0:13 ` [PATCH 57/61] accel: add -DDYNAMIC_DEBUG_MODULE to subdir-ccflags Jim Cromie
2026-02-12 0:13 ` [PATCH 57/59] accel/ivpu: implement IVPU_DBG_* as a dyndbg classmap Jim Cromie
2026-02-12 0:13 ` [PATCH 58/59] accel: add -DDYNAMIC_DEBUG_MODULE to subdir-cflags - RFC Jim Cromie
2026-02-12 0:13 ` [PATCH 58/61] accel/ivpu: implement IVPU_DBG_* as a dyndbg classmap Jim Cromie
2026-02-12 0:13 ` [PATCH 59/61] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie
2026-02-12 0:13 ` [PATCH 60/61] accel/ethosu: enable drm.debug control Jim Cromie
2026-02-12 0:13 ` [PATCH 61/61] accel/rocket: " Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212001359.97296-7-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx-trybot@lists.freedesktop.org \
--cc=louis.chauvet@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox