From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35CDFEB4913 for ; Thu, 12 Feb 2026 12:23:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 921B910E28B; Thu, 12 Feb 2026 12:23:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="fdJ9OmYb"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8450810E28B for ; Thu, 12 Feb 2026 12:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770899017; bh=3nk+50fd7HlNWHaDdsGj1623qHGABv7bsMKtZYB0Qro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fdJ9OmYbui5EdEhkPHlyiUTMobzX/RqGMxCzijigSl3ToGUY5IJE2iy7d0RXXekY/ ONyeP8Jqy7GqXnBGXGJxfpL6kuELXYUCuZoZsfM2iN9YF4j4Xc4ssstBMoAw1lyJ2p dRjf0qoG6fTg8iJne2wqE/6cMSlf5NUAk7/cWF87iUQBLAM0NT7ZbrTZdkq6Ab1zQf pjLDZkpcxh3Qrp9qfaE5kuyACcPDTYWOQ8If9He4d1U6YfqSaja23u9iRRWKjmoK9w ezdFwjTvLKS/GV9OpYo7eYUzofA8qKWYIbQgHo8HR0EIlARGZYFC48N0r6hdzKkiWy cSF9+L2fHUnBw== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id B403717E0E90; Thu, 12 Feb 2026 13:23:36 +0100 (CET) Date: Thu, 12 Feb 2026 13:22:22 +0100 From: Boris Brezillon To: Onur =?UTF-8?B?w5Z6a2Fu?= Cc: Mark Brown , daniel.almeida@collabora.com, aliceryhl@google.com, dakr@kernel.org, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, ojeda@kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v2 1/1] drm/tyr: make SRAM supply optional like panthor Message-ID: <20260212132222.0708d190@fedora> In-Reply-To: <20260212151644.4c179594@nimda> References: <20260212100538.170445-1-work@onurozkan.dev> <20260212100538.170445-2-work@onurozkan.dev> <4b00826f-52b1-48a1-b6b5-70ee62f7c014@sirena.org.uk> <20260212151644.4c179594@nimda> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 12 Feb 2026 15:16:44 +0300 Onur =C3=96zkan wrote: > On Thu, 12 Feb 2026 11:34:41 +0000 > Mark Brown wrote: >=20 > > On Thu, Feb 12, 2026 at 01:05:38PM +0300, Onur =C3=96zkan wrote: =20 > > > On rk3588s, `dmesg | grep 'tyr'` logs: > > >=20 > > > tyr fb000000.gpu: supply SRAM not found, using dummy regulator > > >=20 > > > This happens because Tyr calls Regulator::get() for SRAM, > > > which goes through the non-optional regulator_get() path. If the > > > device tree doesn't provide sram-supply, regulator core falls back > > > to a dummy regulator and writes that log. =20 > > =20 > > > Panthor handles SRAM as optional and tolerates missing sram-supply. = =20 > >=20 > > Does the RAM really work without power? =20 >=20 > If the platform has no separate sram-supply (meaning that rail is > coupled to mali), RAM should still be powered and work fine. Panthor > already relies on this model by treating sram-supply as optional and > as far as I can see there are no RAM issues on Panthor. Yep, some SoC integration have just one power-rail for everything in the GPU, others have two. The sram-supply is documented as optional in the DT bindings, so I think that's the right thing to do. Reviewed-by: Boris Brezillon >=20 > - Onur