From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E45AFC636A0 for ; Sun, 22 Feb 2026 18:13:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F020C10E126; Sun, 22 Feb 2026 18:13:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="PA2+g5+O"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E1D410E126 for ; Sun, 22 Feb 2026 18:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1771784002; bh=hIqgXZd5FMqfLfyGvz8FJHmE2JgWnHUAv7jzjheKI78=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PA2+g5+OYkSH93cy3Mr5PEscRkgXSw2PpmmUOiGH+kDQfBTztSWSx3ey4B8pdSA79 pT3EnMLB01ULwTaf0IitFG8iUopRi1oRbwqGB78i+a3ZvHZoSNjDcRPDgj/84a/PNu d2ZMCdTBVw1SiYBHEA0Wb4vYdPdTRmc/byBi2WW/7xJLbIPKjLPcioGQK6IEx80BVf E5lMv3lx/vFMC7TSZzMLnPKe+3jM8EDq2m45gNnXYnvxrgUIcp5Bh4KyplcxqCCmqG nH02AtJP8iEk8sI/saGMbg/S7AqDdWUPsrG6HbLrf7NJ2OSmX8ZTbBcmAzIoWCbbSM rqg3eOb22Du4Q== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id AB03917E12B9; Sun, 22 Feb 2026 19:13:21 +0100 (CET) Date: Sun, 22 Feb 2026 19:13:18 +0100 From: Boris Brezillon To: Alice Ryhl Cc: Deborah Brouwer , dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, daniel.almeida@collabora.com, beata.michalska@arm.com, lyude@redhat.com Subject: Re: [PATCH 05/12] drm/tyr: add MMU address space registers Message-ID: <20260222191318.0ddf8eee@fedora> In-Reply-To: References: <20260212013713.304343-1-deborah.brouwer@collabora.com> <20260212013713.304343-6-deborah.brouwer@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 21 Feb 2026 09:09:23 +0000 Alice Ryhl wrote: > On Wed, Feb 11, 2026 at 05:37:06PM -0800, Deborah Brouwer wrote: > > From: Boris Brezillon > > > > Add register definitions and constants for managing MMU address space, > > including: > > - Address space translation configuration (page table format, attributes) > > - Memory attributes (cacheability, shareability) > > - Address space commands (update, lock, flush) > > - AsRegister helper for per-AS register access > > > > These will be used by the MMU/VM manager to configure page tables and > > control address space operations. > > > > Signed-off-by: Boris Brezillon > > Co-developed-by: Deborah Brouwer > > Signed-off-by: Deborah Brouwer > > Reviewed-by: Alice Ryhl > > > +/// Maximum number of hardware address space slots. > > +/// The actual number of slots available is usually much lower. > > +pub(crate) const MAX_AS_REGISTERS: usize = 32; > > Not necessarily a problem, but this constant is not present in Panthor's > header file. BTW, I think the max is 16 not 32.