From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23BF3FD9E37 for ; Fri, 27 Feb 2026 05:00:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6353110E1E2; Fri, 27 Feb 2026 05:00:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="V4TCSJMl"; dkim-atps=neutral Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86A4A10E1E2 for ; Fri, 27 Feb 2026 05:00:01 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-824b32875e7so881130b3a.3 for ; Thu, 26 Feb 2026 21:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772168401; x=1772773201; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kWzBer8K/lUNOlKz33ehPBmEnMKwxXodb/hUWZrwOGc=; b=V4TCSJMlggknHrKDtiVlD5Waqo94c2VE5VqJ3A2b5EF6m3UT09+rGxLYuj79kTc5li Z8I1luORB/S6k1+RPT4GuoG5Q/MN4EHCKM9JvJF4tOYonEbz+wDkX27QtzpM9X1wSh6R 6ulMN5RQa9QeePj1h+bYtFmr+dJW5GaXsFwRSmqCuKOW/V+vRwecGRjCLWLY76jat/qC 61pThvfRWCzG7rSa/2KcYO8YqLu9Dn4aSEfEOdCA6V4vXZVPJc0ppjR86TC64Anowzaz 1xQr+N/wMMQCzqbSRW70iM+X6eSuKhsyml9KUuziuEsZmiHQw3Rdd1uxMv634fy+U/Ww GxUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772168401; x=1772773201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kWzBer8K/lUNOlKz33ehPBmEnMKwxXodb/hUWZrwOGc=; b=bdTol7WdHKNh/DI+SRBthRkaUzuvc/356FXNzDQmjAuqGaneulb5G4qEBBKVB0E2Zq KRujHlZ5bCXXBqf7tuLFiaQabIiRqH/yb1J/QRMt8vTbIDlfzUXfUl9suTCOHrANC2pG r2Zp1Kp1M3n0W7Kssf+7AW8WwG0VPSOezUgEQhM8WUIIaxGklXQuWOhWXKrAOJB9flJq vSjSnale+FhuQCa1KhvI982KFCKLWUZ+mKn02dHIiCYdNzrUhs3zY+mg+6eL63s5Cz6O /HcANn8SjS6dJ40mCfVUYOjfAZrFniDu+78JTC4oXbFOqnUEZtPhwlIkq28mK2uY82c4 4fkA== X-Forwarded-Encrypted: i=1; AJvYcCXALxInOmtszWqh7JIkpSe0REN+jgz53BGtn3fc2PR+D4NmAD/h1yOGGPu64QIWOaiP4YtpA8mfJ7I=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxBfeDglkJVM2lesBfyCa66UDpQ3vJBwFHEVxbpVx/51mHJIzEv DFcOqxzBa8dJadzfOxSqz7/nqzaM3BILpIVRT4f71K/ENhb7+tyNABSH X-Gm-Gg: ATEYQzyf84tQVoUodq7WvyfiW1DIrB2pbhKmsu3E3bf/kf+JLvoG3OqLjEkMl/GNzPG LNfvWEm60hGKhcpCbQbrvu+/eKrG+lyG0drKtddGK48nfuJvk/xv8swXajR2D2zvAgNUvugl4PV ue+m1n9IUJYLw3AMei8nUlNrgebvITY70RLkImC852I3jzWqHZAl8Jzgmebj4j5Z5MXpKc+IFc7 PrWHEkz+XdbmHgYkm3FjmYB6mbp9JWx/GtK4+lZHvCP4JzN4WOlwMjvKnUGnR5/YbTm16JMZYO7 CZvjJhWPy9ghJ077kbv1xQdg66f77cwjXhYURhKJ7p0c+lS1lTaR4u59lN8S/24vMQnTmP463X8 ZMjvd2GjwG2q2Ao7W2Cr2K6j2hc65oOdIJMnpVZ5lj1QMjWlWARYbQVvMoelnrpcTEgIJOZfZx7 qCECrRaKowEPwvnqtobddRi3NycD9+Oyc2FvmTDjGxrfb8LORaMw== X-Received: by 2002:a05:6a00:9518:b0:823:30a1:d5ba with SMTP id d2e1a72fcca58-8274da04bfbmr1455329b3a.51.1772168401020; Thu, 26 Feb 2026 21:00:01 -0800 (PST) Received: from name2965-Precision-7820-Tower.. ([175.201.112.127]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d94de6sm3966543b3a.24.2026.02.26.20.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 21:00:00 -0800 (PST) From: Jeongjun Park To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jeongjun Park Subject: [PATCH 6.6.y 1/3] drm/exynos: vidi: use priv->vidi_dev for ctx lookup in vidi_connection_ioctl() Date: Fri, 27 Feb 2026 13:59:51 +0900 Message-Id: <20260227045953.165751-2-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260227045953.165751-1-aha310510@gmail.com> References: <20260227045953.165751-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [ Upstream commit d3968a0d85b211e197f2f4f06268a7031079e0d0 ] vidi_connection_ioctl() retrieves the driver_data from drm_dev->dev to obtain a struct vidi_context pointer. However, drm_dev->dev is the exynos-drm master device, and the driver_data contained therein is not the vidi component device, but a completely different device. This can lead to various bugs, ranging from null pointer dereferences and garbage value accesses to, in unlucky cases, out-of-bounds errors, use-after-free errors, and more. To resolve this issue, we need to store/delete the vidi device pointer in exynos_drm_private->vidi_dev during bind/unbind, and then read this exynos_drm_private->vidi_dev within ioctl() to obtain the correct struct vidi_context pointer. Cc: Signed-off-by: Jeongjun Park Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 + drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index 23646e55f142..06c29ff2aac0 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -199,6 +199,7 @@ struct drm_exynos_file_private { struct exynos_drm_private { struct device *g2d_dev; struct device *dma_dev; + struct device *vidi_dev; void *mapping; /* for atomic commit */ diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 6de0cced6c9d..b31eefb3a8b1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -223,9 +223,14 @@ ATTRIBUTE_GROUPS(vidi); int vidi_connection_ioctl(struct drm_device *drm_dev, void *data, struct drm_file *file_priv) { - struct vidi_context *ctx = dev_get_drvdata(drm_dev->dev); + struct exynos_drm_private *priv = drm_dev->dev_private; + struct device *dev = priv ? priv->vidi_dev : NULL; + struct vidi_context *ctx = dev ? dev_get_drvdata(dev) : NULL; struct drm_exynos_vidi_connection *vidi = data; + if (!ctx) + return -ENODEV; + if (!vidi) { DRM_DEV_DEBUG_KMS(ctx->dev, "user data for vidi is null.\n"); @@ -374,6 +379,7 @@ static int vidi_bind(struct device *dev, struct device *master, void *data) { struct vidi_context *ctx = dev_get_drvdata(dev); struct drm_device *drm_dev = data; + struct exynos_drm_private *priv = drm_dev->dev_private; struct drm_encoder *encoder = &ctx->encoder; struct exynos_drm_plane *exynos_plane; struct exynos_drm_plane_config plane_config = { 0 }; @@ -381,6 +387,8 @@ static int vidi_bind(struct device *dev, struct device *master, void *data) int ret; ctx->drm_dev = drm_dev; + if (priv) + priv->vidi_dev = dev; plane_config.pixel_formats = formats; plane_config.num_pixel_formats = ARRAY_SIZE(formats); @@ -426,8 +434,12 @@ static int vidi_bind(struct device *dev, struct device *master, void *data) static void vidi_unbind(struct device *dev, struct device *master, void *data) { struct vidi_context *ctx = dev_get_drvdata(dev); + struct drm_device *drm_dev = data; + struct exynos_drm_private *priv = drm_dev->dev_private; del_timer_sync(&ctx->timer); + if (priv) + priv->vidi_dev = NULL; } static const struct component_ops vidi_component_ops = { --