From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A46EEB7ED9 for ; Wed, 4 Mar 2026 11:43:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8613510E9C0; Wed, 4 Mar 2026 11:43:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="SXOmIPJb"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D382010E9BF; Wed, 4 Mar 2026 11:43:26 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 84F9343627; Wed, 4 Mar 2026 11:43:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BC93C19423; Wed, 4 Mar 2026 11:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772624606; bh=RdeQxpM446a30snr6DksUquAKJ3HbafVGgNp+XRn85U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SXOmIPJbVZrOiDQdxxHApj/MW4tElG/4y1VDKOns6EUYefWrdr3Nr/hORg0FG/nKl sf1jwiYbcTZbeo7mP4eRySpZJ31b4r6vFlDZoXwGsaYxUbLpzcmLCpyPBnaQMF2w6D zSU46tKdc/tDIq/9Axq5QIFsmPRUOfKWlu4Ek0SCjV2XwQQi5WJbOW0k2GOs11f74U HNyTzaWEX5p6CpRYLaPACt5i/fuBO1I2z9ZS7nlX24pj9dCw8AZa5ERaK5bSsLmVrP zWxfSaQ2ripq1cTH+j0Ox0ed/JrZaAKczpFk/forHoP1khftNCM5CvekS5OYqimc8h OnrLrF99lt4nw== Date: Wed, 4 Mar 2026 11:43:19 +0000 From: Simon Horman To: Yury Norov Cc: Tony Nguyen , "David S. Miller" , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Andrew Lunn , Andrew Morton , David Airlie , Eric Dumazet , Jakub Kicinski , Matthew Brost , Paolo Abeni , Przemek Kitszel , Rodrigo Vivi , Simona Vetter , Yury Norov , Rasmus Villemoes , dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, David Laight Subject: Re: [PATCH v2 4/4] drm/xe: switch xe_pagefault_queue_init() to using bitmap_weighted_or() Message-ID: <20260304114319.GI71509@kernel.org> References: <20260302011159.61778-1-ynorov@nvidia.com> <20260302011159.61778-5-ynorov@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302011159.61778-5-ynorov@nvidia.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Mar 01, 2026 at 08:11:58PM -0500, Yury Norov wrote: > The function calls bitmap_or() immediately followed by bitmap_weight(). > Switch to using the dedicated bitmap_weighted_or() and save one bitmap > traverse. > > Signed-off-by: Yury Norov It's not entirely clear to me why this patch is included in a patchset for the ice driver. And it's also not clear to me why, but allmodconfigs - fo4 at least x86_32 and x86_64 - fail with this patch applied to net-next [1]. ERROR: modpost: "__bitmap_weighted_or" [drivers/gpu/drm/xe/xe.ko] undefined! [1] 2b12ffb66955 ("net: mana: Trigger VF reset/recovery on health check failure due to HWC timeout")