From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EDC4FC9EF4 for ; Sat, 7 Mar 2026 11:13:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4888C10E358; Sat, 7 Mar 2026 11:13:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="U+oOPbng"; dkim-atps=neutral Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00A1B10E358 for ; Sat, 7 Mar 2026 11:13:36 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ab46931cf1so69492065ad.0 for ; Sat, 07 Mar 2026 03:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772882016; x=1773486816; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RfZvykbj+Munv01zyroOwx0N1ICA5mAYoReNuZjedZg=; b=U+oOPbngC1sFiQwPwBR6ghgqctUS7IO9IQXEUwGgteTmk1QNh/g8cRj02RAM5xU2nv WbN5C87tirBeN2abnmK80+OYxiOfORpox532LUmSPPXAlvUn95zSpfOwiUNmdfuTqdfE QnuEXLoVVNcrWxfQph8jGF5G4KDC4hvAvH/7exSK5DIokuE7GTE1grYsSOAY4HRRSKZH hK64Jf2mTHJyXSXxD1DiCnLIjv0K0EfF+e7KaI29mHnWj7OHuCOBjDLuQRgLgOhfeTBu rNYeRw6y9tlYXcAzh6rFKB5/Gf9oIsfQNNKLhNtrYHjWvWTLhYc1xSlV5nrM25JdSVH8 J2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772882016; x=1773486816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RfZvykbj+Munv01zyroOwx0N1ICA5mAYoReNuZjedZg=; b=wW1vTz/LV4SyxhzPYgqvDqTB9e44uyPy8H7kZEQlZTtfLvNJOTXVlq2SoiQy/iM1N8 z8qa+iSwL1LH51BvcF0gn6N6UpoESqc8LMvhIwQPo+ImmiL6IebB4NXIZUda4if4ncwO mcKe7NcV9jq/PE0a6UMd322cxWe1jSi5jUbjv4zAm9g+KnsDGbUVnymI1v+Abt1A98O4 TwacE7sDDlpnFk2vCA9MZ18ZBMJBe7ASDtOjewIvN4kxro6gpUPs0cFMRW1GuBNCQPeI o6EcidU+NZgOIMWdkm5VSRrebAORxT8hyKPF60zayEAiZ2hIwXoGFIs7Vt9+rboGA4m0 Q3Vg== X-Forwarded-Encrypted: i=1; AJvYcCWRbgDEAlh0JkgCe0EDgPNlcfPPsOUMhG1UfxuJq8QSqZu0KB5yi2Ol1lwzjvLppJgSyjpzMv8/mBo=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwZcA62hlFE7sluBd6IENip4Y43NxNacmqj3nPi+7WKT9jQFJE9 4yhgqXiNZlcJ0GLCv67wcpHXZQFIusIQ2he64DpZk+zkHCGAFkFw473w X-Gm-Gg: ATEYQzzQ3NG+42aws4RIMbmiskdLfy49H1w93wMkA1l6h/1wpEwhds4ZPodV/bpHdSa A+zeCnygEqkMW0MVUwwnfu82wfoxB2pURze6C/1AXliAfqzL30RM9WaF7wSwUk7xlBNH+wBDfqn MGIJOo22CMvUvuEi9K12l1kudAmO+bAQoSYBYx9/xxqHzbZUo8LxrvO4SuT8YnR/knHM7L333k7 jYfM6ahHlW2gOUXxwc0j4NEUF5H8MbCUFCUre0lg9xsVk5AQnVpxls5sMykQC7XXBCoUgs+9Txt t7EJpw/yDF0HFV3sybgG7D2DgYtRIAK3ucI6e9B1dDFEs1CLKJMx3s29An9ZK5zkCNdBrTkbseE weAde90WJw1aGTn+IBaDdmbpFtuq78nT4OC1uDlSo9y86GcBqbd2Bpp0H38ZEH7nOCOCgK6yzM3 90wvDXAxLRwBm7WYApTA== X-Received: by 2002:a17:903:1a07:b0:2ae:5d90:9d95 with SMTP id d9443c01a7336-2ae829cdecbmr51388105ad.14.1772882016362; Sat, 07 Mar 2026 03:13:36 -0800 (PST) Received: from nuvole ([109.166.36.159]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f74e7bsm47350265ad.46.2026.03.07.03.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 03:13:35 -0800 (PST) From: Pengyu Luo To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: Pengyu Luo , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] drm/msm/dsi: fix hdisplay calculation for CMD mode panel Date: Sat, 7 Mar 2026 19:12:49 +0800 Message-ID: <20260307111250.105772-2-mitltlatltl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307111250.105772-1-mitltlatltl@gmail.com> References: <20260307111250.105772-1-mitltlatltl@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ac47870fd795 incorrecly broke hdisplay calculation for CMD mode, fix it. Fixes: ac47870fd795 ("drm/msm/dsi: fix hdisplay calculation when programming dsi registers") Signed-off-by: Pengyu Luo --- drivers/gpu/drm/msm/dsi/dsi_host.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 7c16216e8b..f63165c7ce 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1016,8 +1016,9 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) /* * DPU sends 3 bytes per pclk cycle to DSI. If widebus is * enabled, MDP always sends out 48-bit compressed data per - * pclk and on average, DSI consumes an amount of compressed - * data equivalent to the uncompressed pixel depth per pclk. + * pclk and on average, for video mode, DSI consumes only an + * amount of compressed data equivalent to the uncompressed + * pixel depth per pclk. * * Calculate the number of pclks needed to transmit one line of * the compressed data. @@ -1029,10 +1030,14 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) * unused anyway. */ h_total -= hdisplay; - if (wide_bus_enabled) - bits_per_pclk = dsc->bits_per_component * 3; - else + if (wide_bus_enabled) { + if (msm_host->mode_flags & MIPI_DSI_MODE_VIDEO) + bits_per_pclk = dsc->bits_per_component * 3; + else + bits_per_pclk = 48; + } else { bits_per_pclk = 24; + } hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc) * 8, bits_per_pclk); -- 2.53.0