From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6389F36C41 for ; Mon, 20 Apr 2026 08:08:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3157A10EBD3; Mon, 20 Apr 2026 08:08:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="JxqOsqms"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68F8D10EBD6 for ; Mon, 20 Apr 2026 08:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1776672535; bh=xeiMmgHNb7XeXU5idRE++64Apuo6X8UZ90B/UyRdM3o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JxqOsqmszginUPEl+ZJCv+2MuTbw1KA7dlEuwIxUUPDu52ZZToHe0ic70JM+uzuie N4Kyu7jajMWhgCpDQFVNUnGDrIWsj8XbiHoZldId0Ilv/RJosSKuP0R6nToKCLBVSG w8mSgJyFf4wbFfXyNAr5U5K5+l6zC3ZcYtZbvTSNBfuEJWFw2CpuH+qNrVp2SsOL0q wIQBofTy4F4j4xW24XOLH3VbeS711l3uBJ02DaItylX33tGaOMmKgqC6oYc08+HpuU 1Tc+i5yBhWcTS9SEjHb08hT56bminSrZsiAO1tqesA0h49hg1c69Y1eBm0MQDTQAI9 Q9ZRhCjvX1/7Q== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id C503117E0CA9; Mon, 20 Apr 2026 10:08:54 +0200 (CEST) Date: Mon, 20 Apr 2026 10:08:51 +0200 From: Boris Brezillon To: Gyeyoung Baek Cc: Tomeu Vizoso , Rob Herring , Steven Price , =?UTF-8?B?QWRyacOhbg==?= Larumbe , Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v1 2/2] drm/panfrost: Fix wait_bo ioctl leaking positive return from dma_resv_wait_timeout() Message-ID: <20260420100851.5bf42dee@fedora> In-Reply-To: References: Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 19 Apr 2026 16:17:16 +0900 Gyeyoung Baek wrote: > dma_resv_wait_timeout() returns a positive 'remaining jiffies' value > on success, 0 on timeout, and -errno on failure. > > panfrost_ioctl_wait_bo() returns this 'long' result from an int-typed > ioctl handler, so positive values reach userspace as bogus errors. > Explicitly set ret to 0 on the success path. > > Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") > Cc: stable@vger.kernel.org > Signed-off-by: Gyeyoung Baek Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 3d0bdba2a..784e36d72 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -390,6 +390,8 @@ panfrost_ioctl_wait_bo(struct drm_device *dev, void *data, > true, timeout); > if (!ret) > ret = timeout ? -ETIMEDOUT : -EBUSY; > + else if (ret > 0) > + ret = 0; > > drm_gem_object_put(gem_obj); >