From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2986FF5A8DF for ; Tue, 21 Apr 2026 04:04:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86B0810E7AA; Tue, 21 Apr 2026 04:04:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.b="AHGilf6b"; dkim-atps=neutral Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010065.outbound.protection.outlook.com [52.101.56.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24F7A10E7AA; Tue, 21 Apr 2026 04:04:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kus0sjzvXS8VZWap2LTo5n0uurOD4lxFwh3IO9pCiAPeC090n62IfToh/HsfKDjpQA8P+joTm5wtwUEYUpXMajMpSxw18Wcq/JfzcYfa0vP+CTOAcgjWEAMGYRIBBNX7j35plniafvFki2YKVHZz8Gvw1FCLPOEhjoM2J3LZslusL4GaM3FtNe1oaoh2Z9tsbofOqybUtVR8fgL8AK/sihBQI7gbG6CHCPQHc954IalznjH+uv0Ez8f8vOVBD6Om9wSnaRmaR5XISV0DgJrlCLCRKCWdm4LfTB87R0tRwYBAWksQPHIJ6m/JtiKS6VOWkwjO/2YYvyPMjT1cYxOrEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sqBcVdJMakuT8noCXfaWDRdIuh3sO/nrVZcPlwUnK0g=; b=H0jQWUr4JMoUG/145Z+LKyMtNW9s2Hs/3SG/Em63gffwoAugjWtkGc2hqRs/yG/E54bZ5RwrpYfu5wXFQp+rgrfb3hH5UO05LQcBm2NCrneSXL1foPbf+GJP2TvmpTcByB1rw4YQ5y6cuMkFbiZeJhgOt4mtT824ypqERPAd6Mkqb2rKEZmiXMtqzPvYpZ99xIYiPy4oOWSSpNJ9DNKpkUooN3bDAiP+k2vLF5Bl5Tg2hOjoCJaZeNeYMUtm59Ow4Fvd41sK0czThxwLOiXmNiyVc90BaZ0gWK2YsOMvr6Guy2pP4f1AOrUG3hHaCEMTmO6Ks8bh0nxPZGYGUmrVAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sqBcVdJMakuT8noCXfaWDRdIuh3sO/nrVZcPlwUnK0g=; b=AHGilf6bvfwVxHtyji18lpBKYlaluqEPEWeViR1FE63TCLOlSW6+hYuErGrWflGj4cv6q97tuyqgzev1GzGLMKRTF/POi2vYQrohDlmHH8z7WMSC+30tSX5dbDrmOPqJgIqt8WrJirwk051p8Zjemkgxx0XJZoWTL1+/yEeq5t5SyFoh6BsVotnjLHlwKnMdpVKdUTtUHoJN7mPulge8fZM7GhAwfu9NNsC+HC0VFSHT647+5739fFC8WKGMTw36iWZSULE6DL2Ec2TfT0qIlm5ErgEShUvp4VMH97YhD7tLXy1sHug1UilFx3GJSEx7ph/6kmPJRs8ZYbfHIGc4hA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20) by PH7PR12MB7985.namprd12.prod.outlook.com (2603:10b6:510:27b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.15; Tue, 21 Apr 2026 04:03:59 +0000 Received: from SJ2PR12MB9161.namprd12.prod.outlook.com ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9846.014; Tue, 21 Apr 2026 04:03:59 +0000 From: Mikko Perttunen Date: Tue, 21 Apr 2026 13:02:38 +0900 Subject: [PATCH 3/4] drm/msm: Fix iommu_map_sgtable() return value check and avoid WARN Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260421-iommu_map_sgtable-return-v1-3-fb484c07d2a1@nvidia.com> References: <20260421-iommu_map_sgtable-return-v1-0-fb484c07d2a1@nvidia.com> In-Reply-To: <20260421-iommu_map_sgtable-return-v1-0-fb484c07d2a1@nvidia.com> To: Thierry Reding , David Airlie , Simona Vetter , Jonathan Hunter , Dmitry Osipenko , Mauro Carvalho Chehab , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Mikko Perttunen X-Mailer: b4 0.16-dev X-ClientProxiedBy: TY4P286CA0114.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37c::12) To SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB9161:EE_|PH7PR12MB7985:EE_ X-MS-Office365-Filtering-Correlation-Id: 295e1fda-fb65-435d-26b5-08de9f5b03f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|376014|10070799003|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: Ay37eBPsT/c2cizWONx10Hy0fI7hN3oyidIsuwF99AKdosM16/bnpolpPrb6+pgIcjxfnucZhLdoaUar5T4dU1/0RTgorb6Qx0gdNNlPXCRYj++b+6XY02/fzqG+7fiPMptbzt98dSfpOeN/gcQn300s/bvxZZH64lii5dskN86LKnHUQQXWIT4YSKLuj9a8UTmyuByOeQ6xWkxoyBpQPYcneBU4SzenwfNHPTjGfyaV8LaN2qAqpbnTP0HJhwqIwJlh+aCX2L7opj2BSdu/wFUPJ/puxBoAtzj/PoltFz9xM5Tl9N8DTiU4ma1wCptTxtq4eFZaXXyUPyoxRa5Y6gMqSvtJqhYVmBz/cbekK7kYwsuG/fjxizZ+itMfDST6wcFSFF0qchoQrv3VxBxEvAiY0GRGbbe8naAUl0AH8SsqBn0xgZnAaWzoznZgaZtn0SBT7ETugdi97MZNQG5I1oOqHh0v0B4POgw6ZqFhWMvWe8MohetVKfQZVtb21fT/b2vIbBfYKggmB9F6X8YSWw0uz5cibXTbfKAmAoBHTM8oQ2cT7dC7kVhiF9F68zaBGY8pB2aAGFd5UpOMCm+VDz+TJLLjUX75h9WUBATkive3Z6no376rCHWIbGkBTC2ttYhNd6oKWzml/bg3BJELx08SMkFhsq3pnsG4addR+mdghCkdwFUTf7P1TW3GPs+giKl7hUHoNZ5MYxiIahnuMMgFyXsL/Z8X7lIiQqEP+r3tJRFsXqFCQOVHErYvt0yWY1uKlesJp8puvMCYeokF1g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB9161.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(376014)(10070799003)(921020)(22082099003)(18002099003)(56012099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFVyazBKVGlVczlaaUQ0dDBVQnYwaEo5NmRxdm5mb1FZRDVaWXZ6MTIraldt?= =?utf-8?B?cm5sa2RGa0hiczI0NUdEN1M1Y1hRa1dUVWwwWkMzMmkrV2lNMkZSdjN0dDNN?= =?utf-8?B?KzJ1UTdOemJ6bzlMcHd2NGNkcUF5RmtMTy9kS1BBSXhsWWg5dUtUdUp0elZB?= =?utf-8?B?eEJlYWZ3b0tURGRyb2c2Z3VYNjZQVmdlQWVROFp6YjdDLytWTkFjUCtjRm1F?= =?utf-8?B?OElBMmc2MDAvYy96S0pjc2Fnb0lHL0IyanQyRXQzNzErcnFhSGhCNVY3L2kx?= =?utf-8?B?R3R4Z2JTUytqK1JOUlVUSFByeGN0M2pYMFJsZHlvdEQ5WXZxaVM5NUFjRjdT?= =?utf-8?B?Mm1WSWVJUG9YdmpKczhEOFkxSUtvM1VxVE1pcS84c29MaHVtaThaVnl3ZExK?= =?utf-8?B?cnpyTzdnQ05ZM3Ewa3p2cVJwOWtoZ0I5NXcxMEx2WldhcWRYbFVjRHNnQnhH?= =?utf-8?B?Rk16dlBQOHprK2RhR0t2Q3pYbDJtYzZIRjJmWGxhK1BYd3JIWjNVVkxYaS80?= =?utf-8?B?K1VnY2l3Sjg5MkNCRXJRZGtiUmFNTm9PbkY0cDFRWkw2OTlzMEtoM0NjVGVr?= =?utf-8?B?VUtpRkVPWWlpcDV6ajczTlA0RFcxbUpzYmh2ODh3b0MwT0lKZzZpV09zSk9y?= =?utf-8?B?OGt6N3pKN3BNZjVhQ0VUVWxpZzA5N3laTFNSRTdHT2QzMDRIVXFuZVhYV0My?= =?utf-8?B?a3dldmlIRUtlRGhESnNCZS9pSVNlOVR5V3dua3BERmROc2c5N3hvbnN6ejNz?= =?utf-8?B?eEtzUy9XNlh2Wk53L25qZm1mM0hJd2FGdjlBRW5tQzJhZk96S0VkTkViTzFZ?= =?utf-8?B?c1NSRzZPeHRZNWdWSFZ6bStGSzI2NVBiZlZXVDVPQms3WlAwWHgvVERvZWdI?= =?utf-8?B?YjlRaDBQaW44bEJ3aHk5N3ZTN3NjOFNlMVRnTGZmdENpb3ZCWk9iOVpMNmVv?= =?utf-8?B?a2FZTUhvV2JEZ0FlVEhRdEZoblJLYW9FWDdtVkZNQ09lVjdVellna2ZXY1Vu?= =?utf-8?B?V3liYU1zNzQycGpsZ0wzcEtVbllNZWJqaVVmbUZoZkJ5dTNFd1NJcXJsLy8w?= =?utf-8?B?aWova0VrOUl6eldua3BoZE10QXoyMkJsTlpJSVhJaDcydXhra05UZkhrWE9J?= =?utf-8?B?NkhvOGdDNGNuY2JaZjRtSGNhL2tqTk4vVTVWWk5aWnlBQ1VYWFV5ZjhGMnN3?= =?utf-8?B?MGM1bGFraHlaQmtucXE1RjFtVFdxVnpzbWxaNmNDWm9ydUhYK1A1bUh1SnVV?= =?utf-8?B?SFJpWUdZdUJKQVZDcnFvbHFRZktkSW5scFZjb09lYVdPWUh4a1grUWdSTmZs?= =?utf-8?B?Vmpldmp6dThlQUlxZFFQM0ZJRWhNWHVZeERDT3UxQmxaV2NMUEp3eHcwVWdz?= =?utf-8?B?bVIycGZFaW1GMTBoemRqZFU4RjBSYWtRc3NkanBLMGt5aEhEYjFaZnRzZUlF?= =?utf-8?B?UHE0VUx1c3lZc0tGbXpsYlJ2R0V6ZDdtUDVVSEJvSmkvZnhjZUZYK2lOeTND?= =?utf-8?B?YXAzQU1RYncwdjZEWjFkTENva216Y0lFdnVNRUkycHJnNDJwc1JaTXhzMElv?= =?utf-8?B?bCsxUUVEVUh2bCtrRXJEbVdtRWttS3VWbkI1WlJrcjM2Mkt0WG9WemtFbHhi?= =?utf-8?B?VWpXWnIwcG1HQkRRZzNKOGtMZ3JhRlZXdXR3TFRaWDZhdFZpSU9aa3RrRFFT?= =?utf-8?B?dnJpOWxEMndML2paNFoxRFM3aWtZaDlVOC9USG1wZHB0QjkyMjVScFE0T0lp?= =?utf-8?B?UlgrZXI2QXluTC9JYlYwYThINjViSGcrUmxEYzR0WitFMVBVYnk5WWthUFA1?= =?utf-8?B?aWpzemNlVnA4SitQb2xoQzRLV1M2YUd5aG5GbG5neW1XZVVKNWxFREEvR0NH?= =?utf-8?B?Q0NxVHBMYU9udlRidzdhZUVWZUpSS3Rqdkc5YTZnWTV5N0lFZDZHRVRqR1VZ?= =?utf-8?B?bE53YXZvVDliU3pZZ25NUnkwdk9VZkJNeUNnVGk5RXdPWFM3c1dqdFAySmkz?= =?utf-8?B?Z3VCMGtTRFkwZ2FTOHYxQWFXMUtLZVMwV0NKbEhEcmhmcDZtL3BwTC9yVUxR?= =?utf-8?B?dFN0NjdRcGxhVXJYYWZhU1QvMEtKKzRSZkEzU1hLcElEUm50NGg0U3ZGYmFn?= =?utf-8?B?WTBxdnZkaXU1ZSt4WndDMGVHYlRScVVVYTZWOHU2RVpOMDJ3ekpJUTNtSlJM?= =?utf-8?B?UUl3VkU4MWtZZVNDTDIrTm9rQ0xDV0J2SXc0THRUanRRaWlHbStrOEtqWW9S?= =?utf-8?B?WmNoRU1RWmJETENrN3JlN3orQlduQ01qVzRQdUxQUzEwTGZzRjd1SzBzak9h?= =?utf-8?B?R3ZsOFEyRGtNTy8vdDZ0SC9YRWJFQjRoS2FjbXIvNFlhZnRDYlFPNG9uWXJN?= =?utf-8?Q?O/QqYLKS4W6P7GAoGfHJvvpzM+emJwN9DuizxZdTE3ImB?= X-MS-Exchange-AntiSpam-MessageData-1: DK9LBH/rD6HoRg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 295e1fda-fb65-435d-26b5-08de9f5b03f5 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB9161.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2026 04:03:59.1759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 04ZnpuNriuolhL+xGN/8kjJJXAhxc2pm/LHWtbDQ67lttgerxAFXsKu0y8ObPxFygT8eByKzXDHUGeuEk0n9MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7985 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Commit "iommu: return full error code from iommu_map_sg[_atomic]()" changed iommu_map_sgtable() to return an ssize_t and negative values in error cases, rather than a size_t and a zero. Store the return value in the appropriate type and in case of error, return it rather than WARNing. Fixes: ad8f36e4b6b1 ("iommu: return full error code from iommu_map_sg[_atomic]()") Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/msm/msm_iommu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index 7d449e5202c5..058c71c82cf5 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -677,7 +677,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, int prot) { struct msm_iommu *iommu = to_msm_iommu(mmu); - size_t ret; + ssize_t ret; WARN_ON(off != 0); @@ -686,7 +686,8 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, iova |= GENMASK_ULL(63, 49); ret = iommu_map_sgtable(iommu->domain, iova, sgt, prot); - WARN_ON(!ret); + if (ret < 0) + return ret; return (ret == len) ? 0 : -EINVAL; } -- 2.53.0