Re: [PATCH v2 04/13] dt-bindings: media: qcom, glymur-iris: Add glymur video codec

Krzysztof Kozlowski
2026-04-24T17:10:13Z

On 23/04/2026 15:29, Vishnu Reddy wrote:
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - dma-coherent
> + - interconnects
> + - interconnect-names
> + - interrupts
> + - iommus
> + - memory-region
> + - power-domains
> + - power-domain-names
> + - resets
> + - reset-names
> +
> +unevaluatedProperties: false
> +
I think I commented around here but probably not specific enough. You
miss here either reference to venus or usage of additionalProperties
instead of unevaluatedProperties.

If you intend not to use qcom,venus-common.yaml, then explain WHY in
commit msg and switch to additionalProperties: false.

Otherwise, you miss $ref.

Rest looked good.

Best regards,
Krzysztof