From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javierm@redhat.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
David Airlie <airlied@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Phong LE <ple@baylibre.com>, Robert Foss <rfoss@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: [PATCH 1/3] drm/bridge: it66121: Add bridge_to_it66121_ctx() helper
Date: Sun, 10 May 2026 21:14:47 +0200 [thread overview]
Message-ID: <20260510191459.90769-2-javierm@redhat.com> (raw)
In-Reply-To: <20260510191459.90769-1-javierm@redhat.com>
The driver just calls container_of() to obtain the it66121_ctx from a
drm_bridge, but follow the convention of other bridge drivers and add
a helper function to wrap this duplicated logic.
No functional change.
Assisted-by: Cursor:claude-4.6-opus
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/gpu/drm/bridge/ite-it66121.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 19a027d75b61..038a67a32e39 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -315,6 +315,11 @@ struct it66121_ctx {
enum chip_id id;
};
+static inline struct it66121_ctx *bridge_to_it66121_ctx(struct drm_bridge *bridge)
+{
+ return container_of(bridge, struct it66121_ctx, bridge);
+}
+
static const struct regmap_range_cfg it66121_regmap_banks[] = {
{
.name = "it66121",
@@ -589,7 +594,7 @@ static int it66121_bridge_attach(struct drm_bridge *bridge,
struct drm_encoder *encoder,
enum drm_bridge_attach_flags flags)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
int ret;
if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
@@ -700,7 +705,7 @@ static u32 *it66121_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
u32 output_fmt,
unsigned int *num_input_fmts)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
u32 *input_fmts;
*num_input_fmts = 0;
@@ -724,7 +729,7 @@ static u32 *it66121_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
static void it66121_bridge_enable(struct drm_bridge *bridge,
struct drm_atomic_commit *state)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
ctx->connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
@@ -734,7 +739,7 @@ static void it66121_bridge_enable(struct drm_bridge *bridge,
static void it66121_bridge_disable(struct drm_bridge *bridge,
struct drm_atomic_commit *state)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
it66121_set_mute(ctx, true);
@@ -746,7 +751,7 @@ static int it66121_bridge_check(struct drm_bridge *bridge,
struct drm_crtc_state *crtc_state,
struct drm_connector_state *conn_state)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
if (ctx->id == ID_IT6610) {
/* The IT6610 only supports these settings */
@@ -765,7 +770,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge,
const struct drm_display_mode *adjusted_mode)
{
u8 buf[HDMI_INFOFRAME_SIZE(AVI)];
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
int ret;
mutex_lock(&ctx->lock);
@@ -829,7 +834,7 @@ static enum drm_mode_status it66121_bridge_mode_valid(struct drm_bridge *bridge,
const struct drm_display_info *info,
const struct drm_display_mode *mode)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
unsigned long max_clock;
max_clock = (ctx->bus_width == 12) ? 74250 : 148500;
@@ -846,7 +851,7 @@ static enum drm_mode_status it66121_bridge_mode_valid(struct drm_bridge *bridge,
static enum drm_connector_status
it66121_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
return it66121_is_hpd_detect(ctx) ? connector_status_connected
: connector_status_disconnected;
@@ -854,7 +859,7 @@ it66121_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector
static void it66121_bridge_hpd_enable(struct drm_bridge *bridge)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
int ret;
ret = regmap_write_bits(ctx->regmap, IT66121_INT_MASK1_REG, IT66121_INT_MASK1_HPD, 0);
@@ -864,7 +869,7 @@ static void it66121_bridge_hpd_enable(struct drm_bridge *bridge)
static void it66121_bridge_hpd_disable(struct drm_bridge *bridge)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
int ret;
ret = regmap_write_bits(ctx->regmap, IT66121_INT_MASK1_REG,
@@ -876,7 +881,7 @@ static void it66121_bridge_hpd_disable(struct drm_bridge *bridge)
static const struct drm_edid *it66121_bridge_edid_read(struct drm_bridge *bridge,
struct drm_connector *connector)
{
- struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge);
+ struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge);
const struct drm_edid *drm_edid;
int ret;
--
2.54.0
next prev parent reply other threads:[~2026-05-10 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 19:14 [PATCH 0/3] drm/bridge: it66121: Fix display output on DVI monitors Javier Martinez Canillas
2026-05-10 19:14 ` Javier Martinez Canillas [this message]
2026-05-10 19:14 ` [PATCH 2/3] drm/bridge: it66121: Add bridge-private atomic state Javier Martinez Canillas
2026-05-10 19:14 ` [PATCH 3/3] drm/bridge: it66121: Select HDMI or DVI mode based on sink type Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510191459.90769-2-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=ple@baylibre.com \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox