From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53A94CD6E52 for ; Sun, 31 May 2026 13:59:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DB3A112B6D; Sun, 31 May 2026 13:59:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pjspPxCo"; dkim-atps=neutral Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5D8D10E562 for ; Sun, 31 May 2026 09:12:46 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5aa68dbd44fso258749e87.2 for ; Sun, 31 May 2026 02:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780218765; x=1780823565; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dGE7IsvRZpWhFx/mDtlwm79soIqXLEK47Cso1wBFxbI=; b=pjspPxCoctN3rXUgAGb9kp4dFp0Uymw63N9Uz93BvsoFNRNkMJo+Ka6YT3mQEZPjJz M47/uMjph+ThRWFgL0lOzdF7bv7GInSC4D7CtVCk6yHCJrdWLML6F9yHVMeaCXYGWAXl H2NT8M1uIN90scMnvLni3kQDXRz1+S5Zk2+1eVlZNpUqMVjLVXzb670oPEWezOpQ9sYZ Hm19akZYjdYLU603Ct/cDdRXx08CunqTilwLPi2CzQOZcYgHVIrpVdvFcdk2ZheHSFUx qvgg8cRwCVZjicAjDKsqrhhPNJmDHTxCMuQYowuQoy/YVT2t9ACChSN82mVh9dzmDKnQ VooA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780218765; x=1780823565; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dGE7IsvRZpWhFx/mDtlwm79soIqXLEK47Cso1wBFxbI=; b=kShdNYUkRXdw+Lo30viAY7eBD2OocVmTV7ozniAvYEkZO/WwkDKqyu2MUuAnEy+N+s m7f/gyr0Zal8DVRcY4ZqrFu/Hsd8/rfF/u5tCCs7fa4/zFqBmyQkEngs4BjjF2zs0Jcj 2QNNiPrPawjHvR9+58keLVlr+o2Inh29vd6qhxMJhqQE4jjYtqK0239sU2Of3cHJLYZG 7Y7y0wAMCDMZM1nPgESKaM4J4jzEWuJ61/pfS6J2XbkLUp0+25oMC5l7RmvjkMyCDJkV wX8WaS6zvS7KeuEojnPBcG1ZdNlwYHyKlqbo9yFKRw/tKOFFMp8nMi7qtEqqdrBU3l0x M0pg== X-Forwarded-Encrypted: i=1; AFNElJ9K/2xWvwNb9KDMKEWPvNaLA3x6CK2XSfB7FLpI3ytjtrR/95NJVbEu1C8p6QfSP6BtVsdgBWE1SwQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx9CjWtthPZuO8oTjkB7aoL1zYIJd1X/7v9nC2/6KnrJyzZdRTA ARgQpAqrsgPMyjmkvpet4bHHtXmCAnKMaekHqAz7CTD2pDlRzS+SJQ9I X-Gm-Gg: Acq92OHn071Ik9NFHfbuRR5AYCw1I3lfe7d4KOp59JldleqznMkoAK3R+l5KC3w8kbu fA0YJ0UIpz0Yfx1PpfO5KHWmRAz5wAbB35MSTzYXxsJC8RD6P+zca2jM8XgJZycCgtyr4mDTVKC PITx+ma83KXny6zHgBR4bHsFBF2E9ieV6+vgW71rk5yR6/KzuLpN2ZT6DugGfe37zkwktT3hFZM vPbjwrDI57+xris5vjb8yiDWUnXnftN9TRgqZhEeCqTOHkogLJvoTwxYWBgCrHx//p983eGz8i2 zvxCIMS1Cu1nOsU+acP9+UI67KkM0klJHDZPeCbzn0ADu6duwrp2awod95foA0HYioOiYxSYeln OnlnIbbOAmdLIZLx4f71nINtUOYzE4NXj/CUSteEdXTg+47Ewke8R7e73cW5g7KTaE5YMZM9FYP TgRBBc1FrDBQB8r+wC69STCgkpIYlxOFxm/cRkga0yZOAsZ7J4Jnj84lLYecb9fGt1dr8= X-Received: by 2002:a05:6512:1090:b0:5aa:6939:1ba5 with SMTP id 2adb3069b0e04-5aa69391c51mr437282e87.29.1780218764665; Sun, 31 May 2026 02:12:44 -0700 (PDT) Received: from Shofiq.home (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa5b071f33sm1455331e87.20.2026.05.31.02.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 02:12:43 -0700 (PDT) From: Md Shofiqul Islam To: mamin506@gmail.com, lizhi.hou@amd.com Cc: ogabbay@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Md Shofiqul Islam Subject: [PATCH 1/2] drm/accel/amdxdna: add debugfs support Date: Sun, 31 May 2026 12:12:41 +0300 Message-ID: <20260531091241.1764-1-shofiqtest@gmail.com> X-Mailer: git-send-email 2.51.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sun, 31 May 2026 13:58:32 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Expose driver state through debugfs to aid debugging and development. Three read-only entries are created under /sys/kernel/debug/accel//: - fw_version: firmware version as major.minor.sub.build - device_info: device VBNV string and device type identifier - clients: per-fd info (pid, heap usage, total BO usage) Resolves the TODO item in drivers/accel/amdxdna/TODO. Signed-off-by: Md Shofiqul Islam --- drivers/accel/amdxdna/Makefile | 1 + drivers/accel/amdxdna/amdxdna_debugfs.c | 63 +++++++++++++++++++++++++ drivers/accel/amdxdna/amdxdna_debugfs.h | 17 +++++++ drivers/accel/amdxdna/amdxdna_pci_drv.c | 3 ++ 4 files changed, 84 insertions(+) create mode 100644 drivers/accel/amdxdna/amdxdna_debugfs.c create mode 100644 drivers/accel/amdxdna/amdxdna_debugfs.h diff --git a/drivers/accel/amdxdna/Makefile b/drivers/accel/amdxdna/Makefile index cf9bf19de..01a809d88 100644 --- a/drivers/accel/amdxdna/Makefile +++ b/drivers/accel/amdxdna/Makefile @@ -10,6 +10,7 @@ amdxdna-y := \ aie2_smu.o \ aie2_solver.o \ amdxdna_ctx.o \ + amdxdna_debugfs.o \ amdxdna_gem.o \ amdxdna_iommu.o \ amdxdna_mailbox.o \ diff --git a/drivers/accel/amdxdna/amdxdna_debugfs.c b/drivers/accel/amdxdna/amdxdna_debugfs.c new file mode 100644 index 000000000..bd55a9aee --- /dev/null +++ b/drivers/accel/amdxdna/amdxdna_debugfs.c @@ -0,0 +1,63 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2026 Md Shofiqul Islam + */ + +#include +#include + +#include "amdxdna_debugfs.h" +#include "amdxdna_pci_drv.h" + +static inline struct amdxdna_dev *seq_to_xdna(struct seq_file *s) +{ + struct drm_debugfs_entry *entry = s->private; + + return to_xdna_dev(entry->dev); +} + +static int fw_version_show(struct seq_file *s, void *v) +{ + struct amdxdna_dev *xdna = seq_to_xdna(s); + + seq_printf(s, "%d.%d.%d.%d\n", + xdna->fw_ver.major, xdna->fw_ver.minor, + xdna->fw_ver.sub, xdna->fw_ver.build); + return 0; +} + +static int device_info_show(struct seq_file *s, void *v) +{ + struct amdxdna_dev *xdna = seq_to_xdna(s); + + seq_printf(s, "vbnv: %s\n", xdna->dev_info->vbnv); + seq_printf(s, "device_type: %d\n", xdna->dev_info->device_type); + return 0; +} + +static int clients_show(struct seq_file *s, void *v) +{ + struct amdxdna_dev *xdna = seq_to_xdna(s); + struct amdxdna_client *client; + + mutex_lock(&xdna->dev_lock); + list_for_each_entry(client, &xdna->client_list, node) + seq_printf(s, "pid %d heap_usage %zu total_bo_usage %zu\n", + client->pid, client->heap_usage, + client->total_bo_usage); + mutex_unlock(&xdna->dev_lock); + + return 0; +} + +static const struct drm_debugfs_info amdxdna_debugfs_list[] = { + { "fw_version", fw_version_show, 0 }, + { "device_info", device_info_show, 0 }, + { "clients", clients_show, 0 }, +}; + +void amdxdna_debugfs_init(struct amdxdna_dev *xdna) +{ + drm_debugfs_add_files(&xdna->ddev, amdxdna_debugfs_list, + ARRAY_SIZE(amdxdna_debugfs_list)); +} diff --git a/drivers/accel/amdxdna/amdxdna_debugfs.h b/drivers/accel/amdxdna/amdxdna_debugfs.h new file mode 100644 index 000000000..e742a81fe --- /dev/null +++ b/drivers/accel/amdxdna/amdxdna_debugfs.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2024, Advanced Micro Devices, Inc. + */ + +#ifndef _AMDXDNA_DEBUGFS_H_ +#define _AMDXDNA_DEBUGFS_H_ + +struct amdxdna_dev; + +#ifdef CONFIG_DEBUG_FS +void amdxdna_debugfs_init(struct amdxdna_dev *xdna); +#else +static inline void amdxdna_debugfs_init(struct amdxdna_dev *xdna) {} +#endif + +#endif /* _AMDXDNA_DEBUGFS_H_ */ diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.c b/drivers/accel/amdxdna/amdxdna_pci_drv.c index b50a7d1f8..19866dbed 100644 --- a/drivers/accel/amdxdna/amdxdna_pci_drv.c +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c @@ -15,6 +15,7 @@ #include #include "amdxdna_ctx.h" +#include "amdxdna_debugfs.h" #include "amdxdna_gem.h" #include "amdxdna_pci_drv.h" #include "amdxdna_pm.h" @@ -319,6 +320,8 @@ static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id) goto failed_sysfs_fini; } + amdxdna_debugfs_init(xdna); + return 0; failed_sysfs_fini: -- 2.51.1