Re: [PATCH POC v4 6/6] gpu: drm: nova: demonstrate interaction with nova-core

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The external crate import `nova_core::driver::AuxData` is placed after local `crate::` imports.
--

commit 11d167edf5ebf94c9cb9d05943e976e68fe80753
Author: Alexandre Courbot <acourbot@nvidia.com>

gpu: drm: nova: demonstrate interaction with nova-core

This commit exports a few items from nova-core and uses them from nova-drm
to print the chipset of the GPU being probed. It also adds some documentation
items to satisfy Clippy.

> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index 48933d86ddda9..de1ad7032b6c3 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -9,12 +9,15 @@
>          ioctl, //
>      },
>      prelude::*,
> -    sync::aref::ARef, //
> +    sync::aref::ARef,
> +    types::ForLt, //
>  };
>  
>  use crate::file::File;
>  use crate::gem::NovaObject;
>  
> +use nova_core::driver::AuxData;

[Severity: Low]
This isn't a bug, but should the external crate import be placed before the
local crate imports to follow the kernel vertical import style? The Rust
subsystem coding guidelines mention grouping external crate imports above local
ones.

> +
>  pub(crate) struct NovaDriver;
>  
>  pub(crate) struct Nova {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-nova-exports-v4-0-e948c287407c@nvidia.com?part=6