Re: [PATCH 05/76] drm/atomic-state-helper: Add drm_atomic_helper_bridge_create_state()

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]

On Fri, Jun 05, 2026 at 05:29:29PM +0300, Laurent Pinchart wrote:
> Hi Maxime,
> 
> Thank you for the patch.
> 
> On Sat, May 30, 2026 at 03:59:10PM +0200, Maxime Ripard wrote:
> > The drm_atomic_helper_bridge_reset() helper is deprecated in favour
> > of the new atomic_create_state callback.
> > 
> > Add drm_atomic_helper_bridge_create_state() as the counterpart helper
> > for this new callback.
> 
> I'd write here that drivers will be converted to the new helper in
> subsequent changes, and drm_atomic_helper_bridge_reset() then removed.
> 
> > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > ---
> >  drivers/gpu/drm/drm_atomic_state_helper.c | 25 +++++++++++++++++++++++++
> >  include/drm/drm_atomic_state_helper.h     |  2 ++
> >  2 files changed, 27 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> > index f0688f2d83fe..b99dedbc4140 100644
> > --- a/drivers/gpu/drm/drm_atomic_state_helper.c
> > +++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> > @@ -925,5 +925,30 @@ drm_atomic_helper_bridge_reset(struct drm_bridge *bridge)
> >  
> >  	__drm_atomic_helper_bridge_state_init(bridge_state, bridge);
> >  	return bridge_state;
> >  }
> >  EXPORT_SYMBOL(drm_atomic_helper_bridge_reset);
> > +
> > +/**
> > + * drm_atomic_helper_bridge_create_state - default &drm_bridge_funcs.atomic_create_state hook for bridges
> 
> Line wrap.
> 
> "default" is a bit misleading, I would assume it would be used by the
> core if the .atomic_create_state() pointer was null. Maybe
> 
>  * drm_atomic_helper_bridge_create_state - Implementation of &drm_bridge_funcs.atomic_create_state
>  *	for bridge drivers that do no subclass the state
> 
> But maybe that's a bit long. Up to you.

This is how it's documented for most other similar helpers in this file (see
drm_atomic_helper_crtc_reset(), drm_atomic_helper_plane_duplicate_state(),
drm_atomic_helper_connector_destroy_state(), etc.) so I'll keep it for consistency.

> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]