From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7812BCDB46F for ; Mon, 22 Jun 2026 16:36:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC4F710E785; Mon, 22 Jun 2026 16:36:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kemnade.info header.i=@kemnade.info header.b="wCYN+CoS"; dkim-atps=neutral Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA3F510E785 for ; Mon, 22 Jun 2026 16:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=wKnWeeOCic1ziv0Y+FlLgy2VKu/O8y1iY0IZvQmpxU4=; t=1782146171; x=1783355771; b=wCYN+CoSByO5f/6Wxbzf02nYQUtMPYGiogw8jFGYH0BjqmAaLL0KilSI8B/vYQE+bjGni05qPYg K50L2If6SYFVYCxlfPxjeEdG1ohkCwzixyLFE/5pzQ7Jhkg6PCttORfPrfF9gpNBgbPZBizU5ANXk q1kzNmVl1/i8G6uSUHb1XH+PjGR5jbrdh3Enjgw1NfdS3g+MUqgSn1y5Mgp0uUJJqX6FRwh97wmxe ifZXzfO+lQWKJgDUenqqR4qO3kNkDwyHaBSTzXzxf0fDK1o2dFDZRTChjHtjC2RKSiic8JViwTTcG 0FYz0odxMvUh+6PBWbDChh8RRZMfZEMKNt+g==; Date: Mon, 22 Jun 2026 18:35:49 +0200 From: Andreas Kemnade To: Tomi Valkeinen Cc: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson Subject: Re: [PATCH v3 05/13] drm/bridge: tc358762: Drop SPICMR write Message-ID: <20260622183549.30e17a12@kemnade.info> In-Reply-To: <25115d05-5868-45d5-9110-695347948a1f@ideasonboard.com> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-5-6698b55008b9@ideasonboard.com> <20260619082350.2ebc0cf7@kemnade.info> <20260621084150.6ea494ff@kemnade.info> <25115d05-5868-45d5-9110-695347948a1f@ideasonboard.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 22 Jun 2026 10:45:17 +0300 Tomi Valkeinen wrote: > Hi, > > On 21/06/2026 09:41, Andreas Kemnade wrote: > > On Fri, 19 Jun 2026 08:23:50 +0200 > > Andreas Kemnade wrote: > > > >> On Wed, 13 May 2026 16:10:14 +0300 > >> Tomi Valkeinen wrote: > >> > >>> Drop write to SPICMR. It's unclear why the write is there, as SPI is not > >>> supported in the driver, and it's mostly just writing zeroes to already > >>> zero fields (reset defaults). None of the zero bits written disable > >>> anything wrt. SPI. > >>> > >>> Signed-off-by: Tomi Valkeinen > >> > >> Comparing it with something out of tree where SPI is apparently working. > >> It does not touch SPIMR, > >> > > ok, looking what that code really does, it sets bit 1 called SPI_SEL_CS0, > > apparently in that register. But that belongs into an spi_init function. > > Sorry, what sets bit 1? The write removed here just writes zeroes to a "Comparing it with something out of tree where SPI is apperntly working. I just wanted to correct my claim about SPIMR not being used there. That was not meant as an objection to this patch. Regards, Andreas