Re: [PATCH v5 27/38] drm/vkms: Introduce config for connector type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing parameter documentation for @connector_cfg in vkms_connector_init().
--

commit 7b78b90cde59a7b9192c3c5358636914942ee62e
Author: Louis Chauvet <louis.chauvet@bootlin.com>

drm/vkms: Introduce config for connector type

This commit introduces a connector type configuration for VKMS to emulate
connector-specific behavior. It adds the configuration structure, updates
the connector initialization to use the specified type, and provides tests
for the new functionality.

> diff --git a/drivers/gpu/drm/vkms/vkms_connector.h b/drivers/gpu/drm/vkms/vkms_connector.h
> index ed312f4eff3a7..33253d29b1ccd 100644
> --- a/drivers/gpu/drm/vkms/vkms_connector.h
> +++ b/drivers/gpu/drm/vkms/vkms_connector.h

[ ... ]

> @@ -24,7 +25,8 @@ struct vkms_connector {
>   * Returns:
>   * The connector or an error on failure.
>   */
> -struct vkms_connector *vkms_connector_init(struct vkms_device *vkmsdev);
> +struct vkms_connector *vkms_connector_init(struct vkms_device *vkmsdev,
> +					   struct vkms_config_connector *connector_cfg);

[Severity: Low]
This isn't a bug, but the kernel-doc comment above vkms_connector_init() in
drivers/gpu/drm/vkms/vkms_connector.h is missing the description for the newly
added connector_cfg parameter.

It appears this remains undocumented even in the subsequent patch that
renames the function to vkms_connector_init_static().

Should an @connector_cfg: entry be added to the kernel-doc to prevent build
warnings when compiling with W=1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260627-vkms-all-config-v5-0-854aa0840926@bootlin.com?part=27