From: sashiko-bot@kernel.org
To: "Guru Das Srinagesh" <linux@gurudas.dev>
Cc: ojeda@kernel.org, dri-devel@lists.freedesktop.org,
"Danilo Krummrich" <dakr@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>
Subject: Re: [PATCH 3/7] cpufreq: rcpufreq_dt: use vertical import style
Date: Tue, 30 Jun 2026 07:09:14 +0000 [thread overview]
Message-ID: <20260630070914.DBB771F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260628-b4-rust-vertical-imports-v1-3-98bc71d4810b@gurudas.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete conversion to vertical import style.
--
commit 515257218c25a2eecc8bad4b4c78d96ae90b1e95
Author: Guru Das Srinagesh <linux@gurudas.dev>
cpufreq: rcpufreq_dt: use vertical import style
This commit updates the device imports in rcpufreq_dt.rs to use a vertical
layout for better readability.
> diff --git a/drivers/cpufreq/rcpufreq_dt.rs b/drivers/cpufreq/rcpufreq_dt.rs
> index 10106fa13095e..6f83cf8955a68 100644
> --- a/drivers/cpufreq/rcpufreq_dt.rs
> +++ b/drivers/cpufreq/rcpufreq_dt.rs
> @@ -6,7 +6,10 @@
> clk::Clk,
> cpu, cpufreq,
> cpumask::CpumaskVar,
> - device::{Core, Device},
> + device::{
> + Core,
> + Device, //
> + },
> error::code::*,
> macros::vtable,
> module_platform_driver, of, opp, platform,
[Severity: Low]
This isn't a bug, but since this commit touches the imports to convert them
to a vertical layout, should the rest of this outer block also be updated?
Items like cpu, cpufreq, and module_platform_driver, of, opp, platform, are
still grouped horizontally. The Rust subsystem guidelines prefer a fully
vertical style when an import block is modified.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev?part=3
next prev parent reply other threads:[~2026-06-30 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 3:38 [PATCH 0/7] rust: Use kernel style vertical imports in various drivers Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 1/7] samples: rust_dma: use vertical import style Guru Das Srinagesh
2026-06-30 9:48 ` Danilo Krummrich
2026-06-29 3:38 ` [PATCH 2/7] pwm: th1520: " Guru Das Srinagesh
2026-06-30 7:09 ` sashiko-bot
2026-06-29 3:38 ` [PATCH 3/7] cpufreq: rcpufreq_dt: " Guru Das Srinagesh
2026-06-29 12:43 ` Zhongqiu Han
2026-06-30 8:35 ` Miguel Ojeda
2026-06-30 7:09 ` sashiko-bot [this message]
2026-06-29 3:38 ` [PATCH 4/7] block: rnull: " Guru Das Srinagesh
2026-06-30 7:09 ` sashiko-bot
2026-06-29 3:38 ` [PATCH 5/7] net: phy: ax88796b: " Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 6/7] net: phy: qt2025: " Guru Das Srinagesh
2026-06-29 3:38 ` [PATCH 7/7] drm/nova: " Guru Das Srinagesh
2026-06-29 14:06 ` [PATCH 0/7] rust: Use kernel style vertical imports in various drivers Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630070914.DBB771F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@gurudas.dev \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox