Re: [PATCH v9 1/5] drm/gpusvm: split MM state flags out of drm_gpusvm_pages_flags

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing READ_ONCE() when reading the lockless bitfield `migrate_devmem` in `xe_svm_alloc_vram()` causes a data race.
--

commit e500b2422f5c84b340b191071b2b62f1ff1b58ca
Author: Honglei Huang <honghuan@amd.com>

drm/gpusvm: split MM state flags out of drm_gpusvm_pages_flags

This commit splits MM state flags from drm_gpusvm_pages_flags into a new
drm_gpusvm_range_flags structure. It introduces a union with a __flags
member to allow WRITE_ONCE and READ_ONCE for lockless readers, aiming
to keep concurrent bitfield access data-race free.

Link: https://gitlab.freedesktop.org/mbrost/xe-kernel-driver-svn-perf-6-15-2025/-/commit/623f6a50c037d9e44f6c9fbe6859a0ba7ad50177

> diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c

[ ... ]

> @@ -1621,7 +1629,7 @@ int xe_svm_alloc_vram(struct xe_svm_range *range, const struct drm_gpusvm_ctx *c
>  	int err, retries = 1;
>  	bool write_locked = false;
>  
> -	xe_assert(range_to_vm(&range->base)->xe, range->base.pages.flags.migrate_devmem);
> +	xe_assert(range_to_vm(&range->base)->xe, range->base.flags.migrate_devmem);

[Severity: Medium]
Does this plain bitfield read trigger a KCSAN data race warning?

The commit message states that lockless readers should use READ_ONCE() on
the __flags member. However, xe_svm_alloc_vram() reads the migrate_devmem
bitfield directly without holding the notifier_lock.

Since drm_gpusvm_range_set_unmapped() modifies this overlapping memory using
WRITE_ONCE(range->flags.__flags, range_flags.__flags), could this concurrent
access trigger KCSAN warnings and violate the intended data-race free design?

>  	range_debug(range, "ALLOCATE VRAM");
>  
>  	migration_state = drm_gpusvm_scan_mm(&range->base,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630083307.381909-1-honghuan@amd.com?part=1