From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2915FC43458 for ; Tue, 30 Jun 2026 12:40:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7891910EC72; Tue, 30 Jun 2026 12:40:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="mfKdy+/8"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86DB810EC5C for ; Tue, 30 Jun 2026 12:40:23 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 705884055C; Tue, 30 Jun 2026 12:40:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D95651F000E9; Tue, 30 Jun 2026 12:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782823223; bh=rLEOxETaNhnEfcXp3Fz1GLdaUFQ6Efo0pDXRpbhYQto=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mfKdy+/8OsIS2Dteakg5jgJgCjNNbSS5iYE/NPy16UlJg7YieYGh0eoIT/XS91SBi /Za0HtsXnH+RfCHhHFqjHRY4cGLCX1EyCQLWzR6++Y6xBeMlVZLHQBrHpTYrQnsFyr uQ7oIdWmqCPBb65dYlSgViwatFaSR4i1yqGFmTKQmmwyUgfFK6drQFbDwkRDDztVMV jlQ3IjpnwXDLdLFsIuC14wJbPtyDb89CNuxry8e4w24Q4Vn8omkBF+8cskwwsYD3j0 lB4JM9RJZy3yDnNaIWW3jH2WooUxUkb8/cphl2YpVYVY4ekKEdxk3UmivZhRryY8eN EutbKTKB2DWng== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 10/11] rust: driver: remove duplicate ID table To: "Gary Guo" Cc: "Danilo Krummrich" , robh@kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, "Alexandre Courbot" , dri-devel@lists.freedesktop.org, conor+dt@kernel.org, ojeda@kernel.org In-Reply-To: <20260629-id_info-v2-10-56fccbe9c5ef@garyguo.net> References: <20260629-id_info-v2-0-56fccbe9c5ef@garyguo.net> <20260629-id_info-v2-10-56fccbe9c5ef@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 30 Jun 2026 12:40:22 +0000 Message-Id: <20260630124022.D95651F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Previously, `IdArray` contains both device ID table and info table so we > keep a separate copy for MODULE_DEVICE_TABLE for hotplug (which needs to = be > just the device ID table). With the info being changed to be carried via > pointers, `IdArray` is now layout compatible with raw ID table and hence > there is no longer a need to keep the distinction. >=20 > Deduplicate the code, and remove the redundant copy for hotplug purpose by > just giving the `IdArray` instance a proper symbol name. >=20 > While at it, also update the macro to use `::core::line!()` instead of ju= st > `line!()`. >=20 > Signed-off-by: Gary Guo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629-id_info-v2= -0-56fccbe9c5ef@garyguo.net?part=3D10