From: sashiko-bot@kernel.org
To: "Bobby Eshleman" <bobbyeshleman@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH net-next v4 2/3] selftests/net: ncdevmem: add -b option to set rx-buf-size on bind
Date: Fri, 03 Jul 2026 07:52:01 +0000 [thread overview]
Message-ID: <20260703075201.B84601F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260701-tcpdm-large-niovs-v4-2-ca4654f37570@meta.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add 'CONFIG_HUGETLBFS=y' to 'drivers/net/hw/config', but this file modification is missing from the patch.
--
commit c7b1ce8ddda374f6cdcda3fac83aafea966343ab
Author: Bobby Eshleman <bobbyeshleman@meta.com>
selftests/net: ncdevmem: add -b option to set rx-buf-size on bind
This commit adds a -b <bytes> option to request a non-default niov size via
NETDEV_A_DMABUF_RX_BUF_SIZE. When the value exceeds PAGE_SIZE, it switches
to a hugetlb-backed memfd to produce naturally-aligned sg entries.
> Add CONFIG_HUGETLBFS=y to drivers/net/hw/config so the new path is
> reachable in the CI kernels built for these tests.
[Severity: Medium]
Is the commit message out of sync with the actual patch?
The message explicitly states that CONFIG_HUGETLBFS=y is being added to
tools/testing/selftests/drivers/net/hw/config, but this file modification is
completely missing from the patch.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-tcpdm-large-niovs-v4-0-ca4654f37570@meta.com?part=2
next prev parent reply other threads:[~2026-07-03 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 19:22 [PATCH net-next v4 0/3] net: devmem: allow rx-buf-size > PAGE_SIZE per binding Bobby Eshleman
2026-07-01 19:22 ` [PATCH net-next v4 1/3] net: devmem: allow rx-buf-size > PAGE_SIZE per dmabuf binding Bobby Eshleman
2026-07-03 7:52 ` sashiko-bot
2026-07-07 20:36 ` Mina Almasry
2026-07-08 10:50 ` Paolo Abeni
2026-07-08 20:35 ` Bobby Eshleman
2026-07-01 19:22 ` [PATCH net-next v4 2/3] selftests/net: ncdevmem: add -b option to set rx-buf-size on bind Bobby Eshleman
2026-07-03 7:52 ` sashiko-bot [this message]
2026-07-01 19:22 ` [PATCH net-next v4 3/3] selftests/net: devmem.py: add check_rx_large_niov Bobby Eshleman
2026-07-07 19:24 ` [PATCH net-next v4 0/3] net: devmem: allow rx-buf-size > PAGE_SIZE per binding Mina Almasry
2026-07-07 22:02 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703075201.B84601F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bobbyeshleman@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox