From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E371DC43458 for ; Fri, 10 Jul 2026 22:18:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5200510F966; Fri, 10 Jul 2026 22:18:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="InuFxunC"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id D82FA10F966 for ; Fri, 10 Jul 2026 22:18:05 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5CC3460052; Fri, 10 Jul 2026 22:18:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF3D51F000E9; Fri, 10 Jul 2026 22:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783721885; bh=WyuC7eTRcH9wYpufhQagScxCEyGYQefSa3R4NZZHnDQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=InuFxunCCeBhsT8PmfYOgmNUvsnb0LdxuRuUaDRDueLwV0eYj/C2nGFzvB0BqevuJ rLLzz2gHZ0OA5w55ztzhpsUII6A4saAFejw5NP0MSAuFwUV+D7Dg89wHpRcCwmueXN cySGLh5JKPnpzWHXV9PVekhCTipWJb8msLa7If1VDxTOqPfoefItqla1Pg5hEvsfFa 0ZtHSVWG2IRnOMAEkVyaUdnp/EsVGqS8xCfpBTVbZ+HKjz5wSg/UUtIpneBlrZjoJv LGi6qxwKyobEi+k7/4kQXPfkHhPYwpg0j5XLiGe9TTeMgS7klt7tQ8ZcvGcwKiYm+6 uLhs+yioXXZmg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 24/33] drm/xe: Add defrag profiling tracepoints To: "Matthew Brost" Cc: dri-devel@lists.freedesktop.org In-Reply-To: <20260710215442.2444235-25-matthew.brost@intel.com> References: <20260710215442.2444235-1-matthew.brost@intel.com> <20260710215442.2444235-25-matthew.brost@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 10 Jul 2026 22:18:04 +0000 Message-Id: <20260710221804.CF3D51F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] 64-bit integer division in TP_printk causes a link error (__udivdi3= undefined) on 32-bit architectures. -- --- Patch [24]: [PATCH v2 24/33] drm/xe: Add defrag profiling tracepoints -= -- commit 414478b1f94933fc988a5668d191a4c7976fd319 Author: Matthew Brost drm/xe: Add defrag profiling tracepoints This commit adds two tracepoints, xe_bo_defrag_worker and xe_bo_defrag_one, to profile the page defragmentation worker and break down the cost of a defrag attempt. > diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_tra= ce_bo.h > index 86323cf3be2c0..a169a322464b2 100644 > --- a/drivers/gpu/drm/xe/xe_trace_bo.h > +++ b/drivers/gpu/drm/xe/xe_trace_bo.h [ ... ] > +TRACE_EVENT(xe_bo_defrag_one, [ ... ] > + TP_printk("dev=3D%s size=3D%zu budget=3D%llu prealloc=3D%u/%u lock_= us=3D%llu lockwait_us=3D%llu prealloc_us=3D%llu consumed=3D%llu ret=3D%d", > + __get_str(dev), __entry->size, __entry->budget, > + __entry->prealloc_got, __entry->prealloc_want, > + __entry->lock_ns / 1000, __entry->lockwait_ns / 1000, > + __entry->prealloc_ns / 1000, __entry->consumed, > + __entry->ret) > +); [Severity: Low] Will doing 64-bit integer divisions (__entry->lock_ns / 1000, etc.) in TP_printk cause build failures on 32-bit architectures? The C code generated by TP_printk for TRACE_EVENT(xe_bo_defrag_one) performs direct u64 division. On 32-bit platforms, this translates to a dependency on the __udivdi3 libgcc function. Since the kernel does not export this functi= on, this will result in a linking error during 32-bit builds (such as when COMPILE_TEST is enabled). --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260710215442.2444= 235-1-matthew.brost@intel.com?part=3D24