From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22FE2C44501 for ; Sat, 11 Jul 2026 06:10:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EC0F10E2ED; Sat, 11 Jul 2026 06:10:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="fa1wihgb"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CF3D10E2E4 for ; Sat, 11 Jul 2026 06:10:11 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 75700600C3; Sat, 11 Jul 2026 06:10:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B91F81F000E9; Sat, 11 Jul 2026 06:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783750210; bh=ZAM2jUdN308a8tY5WtHFBt7X2lKYF3lXXnVeda7cjrg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fa1wihgbKovt39uvq61xPeycP8ILlzXO5XYxedWGo8yThvumGysxNuLnPY1yyjyig /CLQlr9+3LY90aHlhvp2CyFWmeZqp64nGpw/es7Fg5Z38qqBz0n6HQ424G+0bYzW/c jW8l0UjG/mTh3yoyZhcR068ziFD9rz3QL5aiVjPpUmKpp7OL4icGUrVMGZmckZdgv+ R1GixHb+twJhqaIrxBeeVXmDip6FOg5eaf+Es3+g04B91zwY40UtwhNs/2E/xbwI3P eWZxHfIjEGuiz4p5TvH2tUqUbYi4WATGHlKuqB8HmJ3MuwtU4SQc1c+iolNJnC/Vg7 /RneWxrgi7PBw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 09/16] ASoC: dt-bindings: add OpenPandora Sound Card To: "H. Nikolaus Schaller" Cc: mfd@lists.linux.dev, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, lee@kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <7989e699de400c0fe3f0cb7af77a54077784df78.1783749722.git.hns@goldelico.com> References: <7989e699de400c0fe3f0cb7af77a54077784df78.1783749722.git.hns@goldelico.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 11 Jul 2026 06:10:09 +0000 Message-Id: <20260711061009.B91F81F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] The `$id` and `$schema` fields in the YAML schema contain invali= d URIs, breaking schema validation. - [Low] The `status` property is explicitly and unnecessarily defined in th= e binding schema. -- --- Patch [9]: [PATCH 09/16] ASoC: dt-bindings: add OpenPandora Sound Card = --- commit 94d05b63d0a0b038d3a5355e6b58cc3b78b60eeb Author: H. Nikolaus Schaller ASoC: dt-bindings: add OpenPandora Sound Card The OpenPandora audio subsystem describes the routing links between the OMAP3 McBSP interface, the external PCM1773 DAC, and the TWL4030 audio codec, alongside amplifiers and power supplies. > diff --git a/Documentation/devicetree/bindings/sound/openpandora,omap3pan= dora-sound.yaml b/Documentation/devicetree/bindings/sound/openpandora,omap3= pandora-sound.yaml > new file mode 100644 > index 0000000000000..d3c747e5c58d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-so= und.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org > +$schema: http://devicetree.org [Severity: Medium] Is the $id field missing the full path? As per the device tree binding guidelines, an incorrect $id field breaks the schema cross-reference system and causes dt_binding_check to silently skip validation. It typically needs to begin with http://devicetree.org/schemas/ and exactly match the file pat= h. Additionally, shouldn't $schema be set to the standard meta-schema (http://devicetree.org/meta-schemas/core.yaml#) instead of the base URL? > + > +title: OpenPandora OMAP3 Audio Complex > + > +maintainers: > + - H. Nikolaus Schaller > + > +description: > + The OpenPandora audio subsystem describes the routing links between the > + OMAP3 McBSP interface, the external PCM1773 DAC, and the TWL4030 audio = codec, > + alongside amplifiers and power supplies. > + > +properties: > + compatible: > + const: openpandora,omap3pandora-sound > + > + status: true [Severity: Low] This isn't a bug, but is it necessary to explicitly define the status property here? Since status is a core standard device tree property, it is implicitly handled by the core dt-schema. Redefining it here without constraints is redundant. [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1783749722.gi= t.hns@goldelico.com?part=3D9